@ontrails/warden 1.0.0-beta.14 → 1.0.0-beta.16

package/src/__tests__/prefer-schema-inference.test.ts

@@ -1,84 +0,0 @@
-import { describe, expect, test } from 'bun:test';
-
-import { preferSchemaInference } from '../rules/prefer-schema-inference.js';
-
-describe('prefer-schema-inference', () => {
-  test('warns when a fields label only repeats the derived humanized label', () => {
-    const code = `
-trail("entity.show", {
-  input: z.object({ firstName: z.string() }),
-  fields: {
-    firstName: { label: "First Name" },
-  },
-  blaze: (input) => Result.ok(input),
-})`;
-
-    const diagnostics = preferSchemaInference.check(code, 'src/entity.ts');
-
-    expect(diagnostics).toHaveLength(1);
-    expect(diagnostics[0]?.rule).toBe('prefer-schema-inference');
-    expect(diagnostics[0]?.message).toContain('firstName');
-  });
-
-  test('warns when enum options only repeat schema-derived values', () => {
-    const code = `
-trail("entity.paint", {
-  input: z.object({
-    color: z.enum(["red", "green"]),
-  }),
-  fields: {
-    color: {
-      options: [{ value: "red" }, { value: "green" }],
-    },
-  },
-  blaze: (input) => Result.ok(input),
-})`;
-
-    const diagnostics = preferSchemaInference.check(code, 'src/entity.ts');
-
-    expect(diagnostics).toHaveLength(1);
-    expect(diagnostics[0]?.message).toContain('schema-derived options');
-  });
-
-  test('allows custom labels and enriched enum options', () => {
-    const code = `
-trail("entity.paint", {
-  input: z.object({
-    color: z.enum(["red", "green"]),
-    displayName: z.string().describe("Display name"),
-  }),
-  fields: {
-    color: {
-      options: [
-        { value: "red", label: "Red" },
-        { value: "green", hint: "Safe default" },
-      ],
-    },
-    displayName: { label: "Public name" },
-  },
-  blaze: (input) => Result.ok(input),
-})`;
-
-    const diagnostics = preferSchemaInference.check(code, 'src/entity.ts');
-
-    expect(diagnostics).toHaveLength(0);
-  });
-
-  test('does not warn when the override carries other field metadata', () => {
-    const code = `
-trail("entity.show", {
-  input: z.object({ firstName: z.string() }),
-  fields: {
-    firstName: {
-      label: "First Name",
-      message: "Who should we greet?",
-    },
-  },
-  blaze: (input) => Result.ok(input),
-})`;
-
-    const diagnostics = preferSchemaInference.check(code, 'src/entity.ts');
-
-    expect(diagnostics).toHaveLength(0);
-  });
-});

package/src/__tests__/provision-declarations.test.ts

@@ -1,318 +0,0 @@
-import { describe, expect, test } from 'bun:test';
-
-import { provisionDeclarations } from '../rules/provision-declarations.js';
-
-const TEST_FILE = 'test.ts';
-
-describe('provision-declarations', () => {
-  describe('clean cases', () => {
-    test('declared provisions match provision.from(ctx) usage', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    return Result.ok({ source: db.from(ctx).source });
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-
-    test('local helper named provision() is not treated as ctx lookup', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    const provision = (id: string) => id;
-    return Result.ok({
-      resolved: provision('db.main'),
-      source: db.from(ctx).source,
-    });
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-
-    test('declared provisions match ctx.provision() usage', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    const resolved = ctx.provision('db.main');
-    return Result.ok(resolved);
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-
-    test('recognizes destructured provision() calls', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    const { provision } = ctx;
-    return Result.ok(provision('db.main'));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-
-    test('recognizes ctx.provision(db) lookups by declared provision object', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    return Result.ok(ctx.provision(db));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-  });
-
-  describe('error cases', () => {
-    test('provision.from(ctx) without a declaration produces an error', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  blaze: async (_input, ctx) => {
-    return Result.ok({ source: db.from(ctx).source });
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(1);
-      expect(diagnostics[0]?.severity).toBe('error');
-      expect(diagnostics[0]?.rule).toBe('provision-declarations');
-      expect(diagnostics[0]?.message).toContain('db.from(ctx)');
-      expect(diagnostics[0]?.message).toContain('not declared in provisions');
-    });
-
-    test('ctx.provision() without a declaration produces an error', () => {
-      const code = `
-trail('entity.show', {
-  blaze: async (_input, ctx) => {
-    return Result.ok(ctx.provision('db.main'));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(1);
-      expect(diagnostics[0]?.severity).toBe('error');
-      expect(diagnostics[0]?.message).toContain("ctx.provision('db.main')");
-    });
-
-    test('unresolved imported provision declarations do not suppress lookup diagnostics', () => {
-      const code = `
-import { Result, trail } from '@ontrails/core';
-import { db } from './provisions';
-
-// const db = provision('db.main', {
-//   create: () => Result.ok({ source: 'factory' }),
-// });
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    return Result.ok(ctx.provision('db.main'));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(1);
-      expect(diagnostics[0]?.severity).toBe('error');
-      expect(diagnostics[0]?.message).toContain("ctx.provision('db.main')");
-    });
-
-    test('ctx.provision(db) without a declaration produces an error', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  blaze: async (_input, ctx) => {
-    return Result.ok(ctx.provision(db));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(1);
-      expect(diagnostics[0]?.severity).toBe('error');
-      expect(diagnostics[0]?.message).toContain('ctx.provision(db)');
-    });
-  });
-
-  describe('warn cases', () => {
-    test('declared but unused provision produces a warning', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async () => {
-    return Result.ok({ ok: true });
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(1);
-      expect(diagnostics[0]?.severity).toBe('warn');
-      expect(diagnostics[0]?.rule).toBe('provision-declarations');
-      expect(diagnostics[0]?.message).toContain("'db' declared in provisions");
-      expect(diagnostics[0]?.message).toContain('never used');
-    });
-  });
-
-  describe('single-object overload', () => {
-    test('recognizes trail({ id, provisions, blaze }) form', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail({
-  id: 'entity.show',
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    return Result.ok({ source: db.from(ctx).source });
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-  });
-
-  describe('context parameter naming', () => {
-    test('recognizes database.from(context) when second param is named context', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const database = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [database],
-  blaze: async (_input, context) => {
-    return Result.ok(database.from(context));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-  });
-
-  describe('nested run false positives', () => {
-    test('meta.run does not trigger false positives', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  meta: { blaze: async () => ctx.provision('phantom') },
-  blaze: async (_input, ctx) => {
-    return Result.ok(db.from(ctx));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-  });
-
-  test('skips test files', () => {
-    const code = `
-trail('entity.show', {
-  blaze: async (_input, ctx) => {
-    return Result.ok(ctx.provision('db.main'));
-  },
-});
-`;
-
-    expect(provisionDeclarations.check(code, 'entity.test.ts')).toEqual([]);
-  });
-});

package/src/__tests__/provision-exists.test.ts

@@ -1,122 +0,0 @@
-import { describe, expect, test } from 'bun:test';
-
-import { provisionExists } from '../rules/provision-exists.js';
-
-const TEST_FILE = 'entity.ts';
-
-describe('provision-exists', () => {
-  test('passes when a locally declared provision exists', () => {
-    const code = `
-import { Result, provision, trail } from '@ontrails/core';
-import type { Provision } from '@ontrails/core';
-
-const db: Provision<{ source: string }> = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => Result.ok(db.from(ctx)),
-});
-`;
-
-    expect(provisionExists.check(code, TEST_FILE)).toEqual([]);
-  });
-
-  test('ignores commented-out provision declarations when resolving local ids', () => {
-    const code = `
-import { Result, trail } from '@ontrails/core';
-
-trail('entity.show', {
-  provisions: ['db.main'],
-  blaze: async (_input, ctx) => Result.ok(ctx.provision('db.main')),
-});
-
-// const db = provision('db.main', {
-//   create: () => Result.ok({ source: 'factory' }),
-// });
-`;
-
-    const diagnostics = provisionExists.check(code, TEST_FILE);
-
-    expect(diagnostics).toHaveLength(1);
-    expect(diagnostics[0]?.rule).toBe('provision-exists');
-    expect(diagnostics[0]?.message).toContain('db.main');
-  });
-
-  test('flags a declared provision missing from project context', () => {
-    const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => Result.ok(db.from(ctx)),
-});
-`;
-
-    const diagnostics = provisionExists.checkWithContext(code, TEST_FILE, {
-      knownProvisionIds: new Set(['db.other']),
-      knownTrailIds: new Set(['entity.show']),
-    });
-
-    expect(diagnostics).toHaveLength(1);
-    expect(diagnostics[0]?.rule).toBe('provision-exists');
-    expect(diagnostics[0]?.message).toContain('db.main');
-  });
-
-  test('passes when project context includes the declared provision', () => {
-    const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => Result.ok(db.from(ctx)),
-});
-`;
-
-    const diagnostics = provisionExists.checkWithContext(code, TEST_FILE, {
-      knownProvisionIds: new Set(['db.main']),
-      knownTrailIds: new Set(['entity.show']),
-    });
-
-    expect(diagnostics).toEqual([]);
-  });
-
-  test('skips unresolved imported provisions instead of guessing', () => {
-    const code = `
-import { trail } from '@ontrails/core';
-import { db } from './provisions';
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => Result.ok(db.from(ctx)),
-});
-`;
-
-    expect(
-      provisionExists.checkWithContext(code, TEST_FILE, {
-        knownProvisionIds: new Set(['db.main']),
-        knownTrailIds: new Set(['entity.show']),
-      })
-    ).toEqual([]);
-  });
-
-  test('skips test files', () => {
-    const code = `
-trail('entity.show', {
-  provisions: ['db.main'],
-  blaze: async (_input, ctx) => Result.ok(ctx.provision('db.main')),
-});
-`;
-
-    expect(provisionExists.check(code, 'entity.test.ts')).toEqual([]);
-  });
-});