@ontemper/edi 1.2.0-beta.4 → 1.2.0-beta.5

package/README.md

@@ -362,9 +362,9 @@ sequence. Sandbox and staging allocations do not consume production control numb
 
 ### Automatic environment routing
 
-Temper injects `TEMPER_ENVIRONMENT` into workflows. The SDK uses `UNNBOUND_ENVIRONMENT` only when
-`TEMPER_ENVIRONMENT` is absent. The value must be `sandbox`, `staging`, or `production`. A missing or invalid value
-causes a `ControlNumberError` with the `control_number_environment_missing` code before any HTTP request.
+Current workflow deployments inject `UNNBOUND_ENVIRONMENT`. The SDK also accepts `TEMPER_ENVIRONMENT` as the
+future canonical name and prefers it when present. The value must be `sandbox`, `staging`, or `production`. A missing
+or invalid value causes a `ControlNumberError` with the `control_number_environment_missing` code before any HTTP request.
 
 `getNextControlNumber()`, `getCurrentControlNumber()`, and `toX12()` use this environment. They do not accept an
 environment override. ISA15 (`UsageIndicator_15`) does not select a counter, and `toX12()` does not change it.
@@ -397,7 +397,7 @@ These helpers require `UNNBOUND_API_URL`. Temper configures it in workflow envir
 - TypeScript (for TypeScript projects)
 - The EDI connection env — `UNNBOUND_EDI_BASE_URL`, plus `UNNBOUND_EDI_API_KEY` where the path needs a credential — is platform-injected per environment in Temper workflows; nothing to configure. Supply a key yourself only for the standalone legacy EDINation-cloud path.
 - `UNNBOUND_API_URL` (for control number auto-stamping, pre-configured in workflow environments)
-- `TEMPER_ENVIRONMENT` for counter routing, with `UNNBOUND_ENVIRONMENT` as the legacy fallback
+- `UNNBOUND_ENVIRONMENT` for current counter routing; `TEMPER_ENVIRONMENT` is the preferred future name
 
 ## Dependencies
 

package/dist/control-numbers.js

@@ -127,19 +127,6 @@ function unwrapControlNumberError(error, environmentScoped = false) {
         cause: error,
     });
 }
-async function requestControlNumber(operation, input) {
-    const environment = requireEnvironment();
-    const path = `/api/v2/internal/edi/control-numbers/${environment}/${operation}`;
-    try {
-        const response = operation === 'count'
-            ? await getApiClient().get(path, { params: input })
-            : await getApiClient().post(path, input);
-        return response.data;
-    }
-    catch (error) {
-        return unwrapControlNumberError(error, true);
-    }
-}
 /**
  * Get the next control number for an EDI counter.
  *
@@ -153,22 +140,36 @@ async function requestControlNumber(operation, input) {
  */
 /** @public */
 async function getNextControlNumber(counterName, senderId, receiverId, maxDigits = 9) {
-    const data = await requestControlNumber('increment', {
-        tradingPartnerKey: `${senderId}:${receiverId}`,
-        counterName,
-    });
-    return String(data.value).padStart(maxDigits, '0');
+    const environment = requireEnvironment();
+    try {
+        const { data } = await getApiClient().post(`/api/v2/internal/edi/control-numbers/${environment}/increment`, {
+            tradingPartnerKey: `${senderId}:${receiverId}`,
+            counterName,
+        });
+        return String(data.value).padStart(maxDigits, '0');
+    }
+    catch (error) {
+        return unwrapControlNumberError(error, true);
+    }
 }
 /**
  * Get the current control number value without incrementing.
  */
 /** @public */
 async function getCurrentControlNumber(counterName, senderId, receiverId, maxDigits = 9) {
-    const data = await requestControlNumber('count', {
-        tradingPartnerKey: `${senderId}:${receiverId}`,
-        counterName,
-    });
-    return String(data.value).padStart(maxDigits, '0');
+    const environment = requireEnvironment();
+    try {
+        const { data } = await getApiClient().get(`/api/v2/internal/edi/control-numbers/${environment}/count`, {
+            params: {
+                tradingPartnerKey: `${senderId}:${receiverId}`,
+                counterName,
+            },
+        });
+        return String(data.value).padStart(maxDigits, '0');
+    }
+    catch (error) {
+        return unwrapControlNumberError(error, true);
+    }
 }
 /**
  * Set the last-used production control number through the legacy endpoint.

package/dist/index.d.ts

@@ -41,12 +41,7 @@ export declare class TemperEdiClient {
     private unwrap;
     private unwrapError;
     fromX12({ input }: FromX12Options): Promise<X12Interchange[]>;
-    /**
-     * Stamp ISA13/GS06/ST02 control numbers on the interchange if not already set.
-     * Uses the centralized per-environment service for atomic partner sequencing.
-     * ST02 is always "0001" (one transaction per file per ticket).
-     * Zero-filled values from acknowledgment generation are placeholders, not manual overrides.
-     */
+    /** Allocate every remote number before mutating the interchange. */
     private stampControlNumbers;
     toX12({ input }: ToX12Options): Promise<File>;
     validateX12({ input }: ValidateX12Options): Promise<import("./edination-client").OperationResult>;

package/dist/index.js

@@ -150,30 +150,24 @@ class TemperEdiClient {
                 .catch((error) => this.unwrapError(error, 'edi_read_error'));
         }, (o) => buildEdiX12Payload('fromX12', { input, output: o?.result }));
     }
-    /**
-     * Stamp ISA13/GS06/ST02 control numbers on the interchange if not already set.
-     * Uses the centralized per-environment service for atomic partner sequencing.
-     * ST02 is always "0001" (one transaction per file per ticket).
-     * Zero-filled values from acknowledgment generation are placeholders, not manual overrides.
-     */
+    /** Allocate every remote number before mutating the interchange. */
     async stampControlNumbers(input) {
         const isa = input.ISA;
-        const senderQual = (isa.SenderIDQualifier_5 || '').trim();
-        const senderId = (isa.InterchangeSenderID_6 || '').trim();
-        const receiverQual = (isa.ReceiverIDQualifier_7 || '').trim();
-        const receiverId = (isa.InterchangeReceiverID_8 || '').trim();
+        const senderQual = (isa.SenderIDQualifier_5 ?? '').trim();
+        const senderId = (isa.InterchangeSenderID_6 ?? '').trim();
+        const receiverQual = (isa.ReceiverIDQualifier_7 ?? '').trim();
+        const receiverId = (isa.InterchangeReceiverID_8 ?? '').trim();
         const senderKey = `${senderQual}:${senderId}`;
         const receiverKey = `${receiverQual}:${receiverId}`;
-        // Allocate before mutating so a failed request cannot leave partial stamps.
         const isa13 = needsControlNumber(isa.InterchangeControlNumber_13)
             ? await (0, control_numbers_1.getNextControlNumber)('ISA13', senderKey, receiverKey, 9)
             : null;
+        const groups = input.Groups;
         const gs06Values = [];
-        const groups = input.Groups ?? [];
-        for (let i = 0; i < groups.length; i++) {
-            if (needsControlNumber(groups[i].GS.GroupControlNumber_6)) {
+        for (const group of groups) {
+            if (needsControlNumber(group.GS.GroupControlNumber_6)) {
                 const value = await (0, control_numbers_1.getNextControlNumber)('GS06', senderKey, receiverKey, 9);
-                gs06Values.push({ index: i, value });
+                gs06Values.push({ group, value });
             }
         }
         if (isa13) {
@@ -182,8 +176,7 @@ class TemperEdiClient {
                 input.IEATrailers[0].InterchangeControlNumber_2 = isa13;
             }
         }
-        for (const { index, value } of gs06Values) {
-            const group = groups[index];
+        for (const { group, value } of gs06Values) {
             group.GS.GroupControlNumber_6 = value;
             if (group.GETrailers?.length) {
                 group.GETrailers[0].GroupControlNumber_2 = value;
@@ -201,14 +194,7 @@ class TemperEdiClient {
         }
     }
     async toX12({ input }) {
-        // Auto-stamp control numbers before writing X12
-        try {
-            await this.stampControlNumbers(input);
-        }
-        catch (error) {
-            // Workflows can still serialize documents whose control numbers were set manually.
-            unnbound_logger_sdk_1.logger.warn({ err: error }, '[EDI SDK] Failed to auto-stamp control numbers, proceeding without');
-        }
+        await this.stampControlNumbers(input);
         return (0, unnbound_logger_sdk_1.startSpan)('JSON to X12', () => {
             return this.X12.x12WritePost({ x12Interchange: input })
                 .then(this.unwrap.bind(this))

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ontemper/edi",
   "description": "An EDI client with structured logging.",
-  "version": "1.2.0-beta.4",
+  "version": "1.2.0-beta.5",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "author": "Unnbound Team",