@onrails/biome-plugin 0.1.4 → 0.2.0

package/README.md

@@ -18,7 +18,8 @@ Reference the rule files in `biome.json` plugins:
     "./node_modules/@onrails/biome-plugin/rules/no-promise-result.grit",
     "./node_modules/@onrails/biome-plugin/rules/no-unsafe-unwrap.grit",
     "./node_modules/@onrails/biome-plugin/rules/no-deprecated-synonyms.grit",
-    "./node_modules/@onrails/biome-plugin/rules/fluent-stays-local.grit"
+    "./node_modules/@onrails/biome-plugin/rules/fluent-stays-local.grit",
+    "./node_modules/@onrails/biome-plugin/rules/carrier-sinks-need-from.grit"
   ]
 }
 ```
@@ -31,6 +32,7 @@ Reference the rule files in `biome.json` plugins:
 | `no-unsafe-unwrap`  | `._unsafeUnwrap()` / `._unsafeUnwrapErr()` calls — use `match` / `resolve` / `yieldResult` instead (error) |
 | `no-deprecated-synonyms` | Deprecated synonyms (`chain`, `fold`, `getOrElse`, `of`, …) — use the canonical names (error, partly fixable) |
 | `fluent-stays-local` | Bare `FluentResult<…>` / `FluentMaybe<…>` type references — broader net than the ESLint rule, see `ENGINE_DIVERGENCES` (error) |
+| `carrier-sinks-need-from` | `JSON.parse` / `structuredClone` / `.json()` output cast to `Result<…>` / `Maybe<…>` without `Result.from` / `Maybe.from`; cast form only, see `ENGINE_DIVERGENCES` (error) |
 
 ## Fixes
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onrails/biome-plugin",
-  "version": "0.1.4",
+  "version": "0.2.0",
   "type": "module",
   "description": "Biome GritQL plugin: boundary diagnostics for @onrails/result (Promise<Result<…>>, _unsafeUnwrap*).",
   "license": "MIT",
@@ -40,7 +40,8 @@
     "./rules/no-promise-result.grit": "./rules/no-promise-result.grit",
     "./rules/no-unsafe-unwrap.grit": "./rules/no-unsafe-unwrap.grit",
     "./rules/no-deprecated-synonyms.grit": "./rules/no-deprecated-synonyms.grit",
-    "./rules/fluent-stays-local.grit": "./rules/fluent-stays-local.grit"
+    "./rules/fluent-stays-local.grit": "./rules/fluent-stays-local.grit",
+    "./rules/carrier-sinks-need-from.grit": "./rules/carrier-sinks-need-from.grit"
   },
   "scripts": {
     "typecheck": "echo 'noop (grit files only)'",

package/rules/carrier-sinks-need-from.grit

@@ -0,0 +1,36 @@
+// @onrails/biome-plugin: carrier-sinks-need-from
+//
+// Flag `JSON.parse(…)`, `structuredClone(…)` and `….json()` output cast to
+// `Result<…>` / `Maybe<…>`. Plain data from those sinks has no methods once
+// carriers keep them on a prototype, so the cast lies. Lift with
+// `Result.from` / `Maybe.from` instead.
+//
+// Limitation: matches the direct `as` cast form only. The ESLint rule also
+// follows annotated declarators, carrier-typed returns and parameter defaults,
+// `const` bindings of a sink result, and `res.json<Result<…>>()`; GritQL cannot
+// relate a declarator, return type or binding to its use. Declared in ENGINE_DIVERGENCES
+// (`carrier-sinks-need-from` / `cast-form-only`).
+
+engine biome(1.0)
+language js
+
+or {
+  `$sink as Result<$a, $b>`,
+  `$sink as Maybe<$a>`
+} as $t where {
+  // the sink call itself (optionally awaited / parenthesized), not any call nested inside it:
+  // `Result.from(JSON.parse(raw)) as Result<T, E>` is lifted and must stay quiet
+  $sink <: or {
+    `JSON.parse($_)`,
+    `structuredClone($_)`,
+    `$_.json()`,
+    `await $_.json()`,
+    `($_.json())`,
+    `(await $_.json())`
+  },
+  register_diagnostic(
+    span = $t,
+    message = "Data from JSON.parse/structuredClone/.json() is typed as Result/Maybe but carries no methods — lift it with Result.from / Maybe.from.",
+    severity = "error"
+  )
+}