@onrails/biome-plugin 0.1.0 → 0.1.2

package/README.md

@@ -25,9 +25,9 @@ Reference the rule files in `biome.json` plugins:
 
 | Rule | What it catches |
 |------|------------------|
-| `no-promise-result` | `Promise<Result<T, E>>` in any type position — return `ResultAsync<T, E>` and use `fromAsync` / `tryAsync` at the boundary |
-| `no-unsafe-unwrap`  | `._unsafeUnwrap()` / `._unsafeUnwrapErr()` calls — use `match` / `resolve` / `yieldResult` instead |
+| `no-promise-result` | `Promise<Result<T, E>>` in any type position — return `ResultAsync<T, E>` and use `fromAsync` / `tryAsync` at the boundary (error) |
+| `no-unsafe-unwrap`  | `._unsafeUnwrap()` / `._unsafeUnwrapErr()` calls — use `match` / `resolve` / `yieldResult` instead (error) |
 
 ## Tests
 
-Fixtures under `fixtures/{valid,invalid}/`. Tests in `src/rules.spec.ts` shell out to `biome lint --reporter=json` and assert message substrings.
+Fixtures under `test/fixtures/{valid,invalid}/` (isolated `biome.json` with `root: true`). Tests in `test/rules.spec.ts` shell out to `biome lint --reporter=json` from that directory and assert message substrings.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onrails/biome-plugin",
-  "version": "0.1.0",
+  "version": "0.1.2",
   "type": "module",
   "description": "Biome GritQL plugin: boundary diagnostics for @onrails/result (Promise<Result<…>>, _unsafeUnwrap*).",
   "license": "MIT",
@@ -38,7 +38,8 @@
   ],
   "exports": {
     "./rules/no-promise-result.grit": "./rules/no-promise-result.grit",
-    "./rules/no-unsafe-unwrap.grit": "./rules/no-unsafe-unwrap.grit"
+    "./rules/no-unsafe-unwrap.grit": "./rules/no-unsafe-unwrap.grit",
+    "./rules/no-deprecated-synonyms.grit": "./rules/no-deprecated-synonyms.grit"
   },
   "scripts": {
     "typecheck": "echo 'noop (grit files only)'",
@@ -49,6 +50,6 @@
     "@biomejs/biome": ">=2.0.0"
   },
   "devDependencies": {
-    "@biomejs/biome": "^2.4.15"
+    "@biomejs/biome": "^2.4.16"
   }
 }

package/rules/no-deprecated-synonyms.grit

@@ -0,0 +1,40 @@
+// @onrails/biome-plugin: no-deprecated-synonyms
+//
+// Flag deprecated railway/maybe synonyms. Use canonical versions instead:
+// - chain() -> flatMap() / andThen()
+// - getOrElse() -> unwrapOr()
+// - of() -> ok() / some()
+// - fold() / matchResult() / matchMaybe() -> match()
+// - sequenceTupleAsync() -> ResultAsync.combineTuple()
+// - collect() -> combine()
+// - ResultAsync.isOk() / isErr() -> await and narrow with isOk() / isErr()
+//
+// Limitation: matching is name-based — GritQL cannot scope by import, so
+// same-named calls from other libraries (RxJS `of`, fp-ts `fold`,
+// neverthrow `.isOk()`) are flagged too. Suppress with an inline
+// biome-ignore comment in mixed codebases.
+
+engine biome(1.0)
+language js
+
+or {
+  `$_.chain($_)` as $call,
+  `$_?.chain($_)` as $call,
+  `$_.isOk()` as $call,
+  `$_?.isOk()` as $call,
+  `$_.isErr()` as $call,
+  `$_?.isErr()` as $call,
+  `fold($_)` as $call,
+  `matchResult($_)` as $call,
+  `matchMaybe($_)` as $call,
+  `getOrElse($_)` as $call,
+  `sequenceTupleAsync($_)` as $call,
+  `collect($_)` as $call,
+  `of($_)` as $call
+} where {
+  register_diagnostic(
+    span = $call,
+    message = "Avoid deprecated onrails synonyms/methods. Use the canonical equivalents instead.",
+    severity = "error"
+  )
+}

package/rules/no-promise-result.grit

@@ -11,6 +11,6 @@ language js
   register_diagnostic(
     span = $t,
     message = "Promise<Result<…>> in a type position — use ResultAsync<T, E> at the boundary (fromAsync / tryAsync).",
-    severity = "warn"
+    severity = "error"
   )
 }

package/rules/no-unsafe-unwrap.grit

@@ -9,11 +9,14 @@ language js
 
 or {
   `$_._unsafeUnwrap()` as $call,
-  `$_._unsafeUnwrapErr()` as $call
+  `$_._unsafeUnwrapErr()` as $call,
+  `unwrapOk($_)` as $call,
+  `unwrapErr($_)` as $call,
+  `unwrap($_)` as $call
 } where {
   register_diagnostic(
     span = $call,
-    message = "Avoid _unsafeUnwrap* — use match(), resolve(), or yieldResult() in tryGen.",
-    severity = "warn"
+    message = "Avoid _unsafeUnwrap* and unwrap* outside tests — use match(), resolve(), or yieldResult() in tryGen.",
+    severity = "error"
   )
 }