@onlooker-community/ecosystem 0.43.4 → 0.43.6

package/plugins/inspector/scripts/lib/inspector-project-key.sh

@@ -23,11 +23,68 @@ _inspector_sha256_first12() {
 	fi
 }
 
+# Resolve a path to its physical form — symlinks expanded, no trailing slash.
+#
+# The hook decides whether a touched file lives inside the repo by prefix-
+# matching one canonicalized path against the other. Both sides MUST come
+# through this one function. They used to be canonicalized independently
+# (realpath for the file, `git rev-parse --show-toplevel` for the root), each
+# with its own fallback, and on macOS /var is a symlink to /private/var — so
+# whenever either mechanism fell back, the two sides landed in different
+# namespaces and the prefix match failed. The hook then reported not_in_repo
+# for a file plainly inside the repo, exiting 0 with no output. See
+# ecosystem-foi, where that surfaced as an intermittent test failure.
+#
+# The last resort is `cd` + `pwd -P`, a bash builtin that needs no external
+# tool, so this still returns a physical path when neither realpath nor a
+# GNU-style `readlink -f` is available.
+#
+# Usage: canonical=$(inspector_canonical_path "$some_path")
+inspector_canonical_path() {
+	local p="${1:-}"
+	[[ -z "$p" ]] && return 0
+
+	local out
+	if out=$(realpath "$p" 2>/dev/null) && [[ -n "$out" ]]; then
+		printf '%s' "$out"
+		return 0
+	fi
+	# BSD readlink has no -f, so this silently no-ops there and falls through.
+	if out=$(readlink -f "$p" 2>/dev/null) && [[ -n "$out" ]]; then
+		printf '%s' "$out"
+		return 0
+	fi
+
+	if [[ -d "$p" ]]; then
+		out=$(cd "$p" 2>/dev/null && pwd -P) && [[ -n "$out" ]] && {
+			printf '%s' "$out"
+			return 0
+		}
+	else
+		local dir base
+		dir=$(dirname "$p")
+		base=$(basename "$p")
+		out=$(cd "$dir" 2>/dev/null && pwd -P) && [[ -n "$out" ]] && {
+			printf '%s/%s' "$out" "$base"
+			return 0
+		}
+	fi
+
+	# Nothing resolved it — hand back the input rather than an empty string,
+	# so a caller comparing two of these still compares like with like.
+	printf '%s' "$p"
+}
+
 inspector_project_repo_root() {
 	local cwd="${1:-$(pwd)}"
 	local root
-	root=$(git -C "$cwd" rev-parse --show-toplevel 2>/dev/null) && printf '%s' "$root" && return 0
-	printf '%s' "$cwd"
+	# Canonicalize BOTH the git answer and the fallback. git already returns a
+	# physical path, so the first call is a no-op; the fallback is the caller's
+	# raw cwd, which is exactly the case that used to diverge.
+	root=$(git -C "$cwd" rev-parse --show-toplevel 2>/dev/null) \
+		&& [[ -n "$root" ]] \
+		&& { inspector_canonical_path "$root"; return 0; }
+	inspector_canonical_path "$cwd"
 }
 
 inspector_project_remote_url() {

package/plugins/librarian/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "librarian",
-  "version": "0.13.2",
+  "version": "0.13.3",
   "description": "Consolidation layer between archivist's per-session artifacts and the user's durable typed memory store. Detects which session decisions, dead-ends, and open questions deserve to live across sessions, classifies them into the user/feedback/project/reference types, and queues them as proposals for explicit confirmation. Auto-promotion is opt-in. Builds on the Onlooker ecosystem plugin.",
   "author": {
     "name": "Onlooker Community",

package/plugins/librarian/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [0.13.3](https://github.com/onlooker-community/ecosystem/compare/librarian-v0.13.2...librarian-v0.13.3) (2026-08-22)
+
+
+### Bug Fixes
+
+* **config:** let every config lib find the loader from its own path :broom: ([#198](https://github.com/onlooker-community/ecosystem/issues/198)) ([249fe41](https://github.com/onlooker-community/ecosystem/commit/249fe41bf191db48239c2028ba77a10b3dcb03af))
+* **librarian:** key the declined-ledger guard on the proposal, not the artifact :bug: ([#199](https://github.com/onlooker-community/ecosystem/issues/199)) ([47a195d](https://github.com/onlooker-community/ecosystem/commit/47a195da98a3a565018c35e9e5c6dde2405520de))
+
 ## [0.13.2](https://github.com/onlooker-community/ecosystem/compare/librarian-v0.13.1...librarian-v0.13.2) (2026-08-18)
 
 

package/plugins/librarian/scripts/lib/librarian-config.sh

@@ -16,8 +16,12 @@
 # Settings overlay only touches the `librarian.*` subtree of settings.json so
 # it coexists with other plugins' configuration.
 
-# shellcheck source=../../../scripts/lib/config-loader.sh
-source "${PLUGIN_ROOT}/../../scripts/lib/config-loader.sh"
+# Resolve the shared loader from this file's own location. $PLUGIN_ROOT is
+# whatever the sourcing scope happened to set, so a sub-shell that inherits
+# CLAUDE_PLUGIN_ROOT but not PLUGIN_ROOT would lose every accessor silently.
+_LIBRARIAN_CONFIG_LIB_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck source=scripts/lib/config-loader.sh
+source "${_LIBRARIAN_CONFIG_LIB_DIR}/../../../../scripts/lib/config-loader.sh"
 
 _LIBRARIAN_CONFIG="{}"
 

package/plugins/librarian/scripts/lib/librarian-lesson-promote.sh

@@ -183,19 +183,39 @@ librarian_lesson_promote() {
 		# declined.jsonl, double-counting a rejected artifact in the
 		# rubric-tuning signal the ledger exists to carry.
 		#
+		# Keyed on lesson_id, not artifact_id. The approved branch's guard is
+		# approved/<lesson_id>.json — per-proposal by construction — and this
+		# one has to match it. Keyed on artifact_id it could not tell "this
+		# artifact was already declined" from "a DIFFERENT proposal for the
+		# same artifact was already declined", so the second of two colliding
+		# proposals skipped its append and returned 0: both stamped, one
+		# verdict on disk. That is the inverse of the double-write this guard
+		# exists to stop, and still loses the per-judge detail (ecosystem-bkj).
+		#
+		# The artifact_id clause is the fallback for rows that legitimately
+		# carry no lesson_id: those written before this change, and those the
+		# transform writes for an artifact rejected before any proposal
+		# existed. Dropping it would leave an unstamped pre-change proposal
+		# double-writing on re-run — trading this bug for the older one.
+		#
 		# Same scan shape as librarian_lesson_seen: -R/fromjson? survives a
 		# truncated trailing line from a process killed mid-append, and
 		# `objects` stops a valid-but-non-object line from erroring the whole
 		# invocation.
 		already_declined=false
 		if [[ -f "$declined_path" ]] \
-			&& jq -Re --arg a "$artifact_id" 'fromjson? | objects | select(.artifact_id == $a)' \
+			&& jq -Re --arg a "$artifact_id" --arg l "$lesson_id" \
+				'fromjson? | objects
+				 | select(
+				     ($l != "" and .lesson_id == $l)
+				     or ((.lesson_id // null) == null and .artifact_id == $a)
+				   )' \
 				"$declined_path" >/dev/null 2>&1; then
 			already_declined=true
 		fi
 
 		if [[ "$already_declined" == false ]]; then
-			librarian_lesson_append_declined "$key" "$artifact_id" "$reason" "" "$verdict" || {
+			librarian_lesson_append_declined "$key" "$artifact_id" "$reason" "" "$verdict" "$lesson_id" || {
 				printf 'Lesson %s: cannot append to the declined ledger.\n' "$lesson_id" >&2
 				return 1
 			}

package/plugins/librarian/scripts/lib/librarian-lesson-storage.sh

@@ -83,13 +83,27 @@ librarian_lesson_write_proposal() {
 # written by the transform have no verdict and simply lack the key — a format
 # failure has no jury.
 #
-# Usage: librarian_lesson_append_declined <key> <artifact_id> <reason> [detail] [verdict_json]
+# `lesson_id` names the PROPOSAL this verdict came from, and is null when there
+# is no proposal to name. The transform declines an artifact before any proposal
+# exists (transform_invalid, schema_invalid, and friends), so its rows carry
+# null here and are identified by artifact_id alone.
+#
+# It exists so promote's double-write guard can key on the proposal rather than
+# the artifact. Keyed on artifact_id, that guard could not tell "this artifact
+# was already declined" from "a DIFFERENT proposal for the same artifact was
+# already declined", and silently dropped the second verdict — see
+# ecosystem-bkj. Note this is the opposite of what librarian_lesson_seen wants:
+# that function asks "was this ARTIFACT already handled?" and correctly stays
+# keyed on artifact_id.
+#
+# Usage: librarian_lesson_append_declined <key> <artifact_id> <reason> [detail] [verdict_json] [lesson_id]
 librarian_lesson_append_declined() {
 	local key="$1"
 	local artifact_id="$2"
 	local reason="$3"
 	local detail="${4:-}"
 	local verdict="${5:-}"
+	local lesson_id="${6:-}"
 	[[ -z "$key" || -z "$artifact_id" || -z "$reason" ]] && return 1
 
 	librarian_lesson_storage_init "$key" || return 1
@@ -99,12 +113,14 @@ librarian_lesson_append_declined() {
 	if [[ -n "$verdict" ]]; then
 		line=$(jq -cn \
 			--arg artifact_id "$artifact_id" \
+			--arg lesson_id "$lesson_id" \
 			--arg reason "$reason" \
 			--arg detail "$detail" \
 			--arg at "$now" \
 			--argjson verdict "$verdict" \
 			'{
 				artifact_id: $artifact_id,
+				lesson_id: (if $lesson_id == "" then null else $lesson_id end),
 				reason: $reason,
 				detail: (if $detail == "" then null else $detail end),
 				declined_at: $at,
@@ -113,11 +129,13 @@ librarian_lesson_append_declined() {
 	else
 		line=$(jq -cn \
 			--arg artifact_id "$artifact_id" \
+			--arg lesson_id "$lesson_id" \
 			--arg reason "$reason" \
 			--arg detail "$detail" \
 			--arg at "$now" \
 			'{
 				artifact_id: $artifact_id,
+				lesson_id: (if $lesson_id == "" then null else $lesson_id end),
 				reason: $reason,
 				detail: (if $detail == "" then null else $detail end),
 				declined_at: $at

package/plugins/lineage/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "lineage",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "description": "Per-change provenance for the Onlooker ecosystem. Records session/turn metadata plus a secret-redacted, size-capped snippet for every Edit/Write/MultiEdit at PostToolUse, then answers \"why does this line exist?\" via /lineage by joining change records to historian-preserved transcripts. Emits lineage.* events for audit. Builds on the Onlooker ecosystem plugin.",
   "author": {
     "name": "Onlooker Community",

package/plugins/lineage/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.2.3](https://github.com/onlooker-community/ecosystem/compare/lineage-v0.2.2...lineage-v0.2.3) (2026-08-22)
+
+
+### Bug Fixes
+
+* **config:** let every config lib find the loader from its own path :broom: ([#198](https://github.com/onlooker-community/ecosystem/issues/198)) ([249fe41](https://github.com/onlooker-community/ecosystem/commit/249fe41bf191db48239c2028ba77a10b3dcb03af))
+
 ## [0.2.2](https://github.com/onlooker-community/ecosystem/compare/lineage-v0.2.1...lineage-v0.2.2) (2026-08-02)
 
 

package/plugins/lineage/scripts/lib/lineage-config.sh

@@ -13,8 +13,12 @@
 #   lineage_config_get <jq-path>       # echoes string value (empty if unset)
 #   lineage_config_get_json <jq-path>  # echoes JSON value (null if unset)
 
-# shellcheck source=../../../scripts/lib/config-loader.sh
-source "${PLUGIN_ROOT}/../../scripts/lib/config-loader.sh"
+# Resolve the shared loader from this file's own location. $PLUGIN_ROOT is
+# whatever the sourcing scope happened to set, so a sub-shell that inherits
+# CLAUDE_PLUGIN_ROOT but not PLUGIN_ROOT would lose every accessor silently.
+_LINEAGE_CONFIG_LIB_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck source=scripts/lib/config-loader.sh
+source "${_LINEAGE_CONFIG_LIB_DIR}/../../../../scripts/lib/config-loader.sh"
 
 _lineage_CONFIG="{}"
 

package/plugins/scribe/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "scribe",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "description": "Intent documentation from agent activity. Captures why changes were made — problem context, decisions, tradeoffs — and distills them into readable artifacts at session end.",
   "author": {
     "name": "Onlooker Community",

package/plugins/scribe/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.4.3](https://github.com/onlooker-community/ecosystem/compare/scribe-v0.4.2...scribe-v0.4.3) (2026-08-22)
+
+
+### Bug Fixes
+
+* **config:** let every config lib find the loader from its own path :broom: ([#198](https://github.com/onlooker-community/ecosystem/issues/198)) ([249fe41](https://github.com/onlooker-community/ecosystem/commit/249fe41bf191db48239c2028ba77a10b3dcb03af))
+
 ## [0.4.2](https://github.com/onlooker-community/ecosystem/compare/scribe-v0.4.1...scribe-v0.4.2) (2026-08-02)
 
 

package/plugins/scribe/scripts/lib/scribe-config.sh

@@ -13,8 +13,12 @@
 #   scribe_config_get <jq-path>       # echoes string value (empty if unset)
 #   scribe_config_get_json <jq-path>  # echoes JSON value (null if unset)
 
-# shellcheck source=../../../scripts/lib/config-loader.sh
-source "${PLUGIN_ROOT}/../../scripts/lib/config-loader.sh"
+# Resolve the shared loader from this file's own location. $PLUGIN_ROOT is
+# whatever the sourcing scope happened to set, so a sub-shell that inherits
+# CLAUDE_PLUGIN_ROOT but not PLUGIN_ROOT would lose every accessor silently.
+_SCRIBE_CONFIG_LIB_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck source=scripts/lib/config-loader.sh
+source "${_SCRIBE_CONFIG_LIB_DIR}/../../../../scripts/lib/config-loader.sh"
 
 _scribe_CONFIG="{}"
 

package/plugins/tribunal/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "tribunal",
-  "version": "1.2.7",
+  "version": "1.2.8",
   "description": "Multi-agent execution with LLM-as-a-Judge quality gates. An Actor performs work; a jury of typed Judges scores it against a project-overridable rubric; a Meta-Judge reviews the jury for bias; the gate decides accept, retry, or exhaust. Grounded in LLM-as-a-Judge (Zheng et al. 2023) and LLM-as-a-Meta-Judge (Wu et al. 2024). Builds on the Onlooker ecosystem plugin.",
   "author": {
     "name": "Onlooker Community",

package/plugins/tribunal/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [1.2.8](https://github.com/onlooker-community/ecosystem/compare/tribunal-v1.2.7...tribunal-v1.2.8) (2026-08-22)
+
+
+### Bug Fixes
+
+* **config:** let every config lib find the loader from its own path :broom: ([#198](https://github.com/onlooker-community/ecosystem/issues/198)) ([249fe41](https://github.com/onlooker-community/ecosystem/commit/249fe41bf191db48239c2028ba77a10b3dcb03af))
+
 ## [1.2.7](https://github.com/onlooker-community/ecosystem/compare/tribunal-v1.2.6...tribunal-v1.2.7) (2026-08-16)
 
 

package/plugins/tribunal/scripts/lib/tribunal-config.sh

@@ -13,8 +13,12 @@
 #   tribunal_config_get <jq-path>       # echoes string value (empty if unset)
 #   tribunal_config_get_json <jq-path>  # echoes JSON value (null if unset)
 
-# shellcheck source=../../../scripts/lib/config-loader.sh
-source "${PLUGIN_ROOT}/../../scripts/lib/config-loader.sh"
+# Resolve the shared loader from this file's own location. $PLUGIN_ROOT is
+# whatever the sourcing scope happened to set, so a sub-shell that inherits
+# CLAUDE_PLUGIN_ROOT but not PLUGIN_ROOT would lose every accessor silently.
+_TRIBUNAL_CONFIG_LIB_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck source=scripts/lib/config-loader.sh
+source "${_TRIBUNAL_CONFIG_LIB_DIR}/../../../../scripts/lib/config-loader.sh"
 
 _TRIBUNAL_CONFIG="{}"
 

package/plugins/warden/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "warden",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "Untrusted-content gate. Scans content flowing in through WebFetch and Read for prompt-injection patterns, and when a threat is detected closes a session-scoped gate that blocks Write, Edit, and Bash until the user explicitly clears it. Grounded in Meta's Agents Rule of Two: an agent should hold no more than two of {private data, external actions, untrusted content} at once — warden removes the external-actions property while untrusted content is in play. Builds on the Onlooker ecosystem plugin.",
   "author": {
     "name": "Onlooker Community",

package/plugins/warden/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.3.2](https://github.com/onlooker-community/ecosystem/compare/warden-v0.3.1...warden-v0.3.2) (2026-08-22)
+
+
+### Bug Fixes
+
+* **config:** let every config lib find the loader from its own path :broom: ([#198](https://github.com/onlooker-community/ecosystem/issues/198)) ([249fe41](https://github.com/onlooker-community/ecosystem/commit/249fe41bf191db48239c2028ba77a10b3dcb03af))
+
 ## [0.3.1](https://github.com/onlooker-community/ecosystem/compare/warden-v0.3.0...warden-v0.3.1) (2026-08-01)
 
 

package/plugins/warden/scripts/lib/warden-config.sh

@@ -13,8 +13,12 @@
 #   warden_config_get <jq-path>       # echoes string value (empty if unset)
 #   warden_config_get_json <jq-path>  # echoes JSON value (null if unset)
 
-# shellcheck source=../../../scripts/lib/config-loader.sh
-source "${PLUGIN_ROOT}/../../scripts/lib/config-loader.sh"
+# Resolve the shared loader from this file's own location. $PLUGIN_ROOT is
+# whatever the sourcing scope happened to set, so a sub-shell that inherits
+# CLAUDE_PLUGIN_ROOT but not PLUGIN_ROOT would lose every accessor silently.
+_WARDEN_CONFIG_LIB_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck source=scripts/lib/config-loader.sh
+source "${_WARDEN_CONFIG_LIB_DIR}/../../../../scripts/lib/config-loader.sh"
 
 _warden_CONFIG="{}"
 

package/scripts/lib/config-loader.sh

@@ -6,8 +6,21 @@
 # across the ecosystem.
 #
 # Usage:
-#   # In your plugin's config loader (e.g., plugins/bursar/scripts/lib/bursar-config.sh):
-#   source "${PLUGIN_ROOT}/../../scripts/lib/config-loader.sh"
+#   # In your plugin's config loader (e.g., plugins/bursar/scripts/lib/bursar-config.sh).
+#   # Locate this file from the sourcing file's OWN path, never from a
+#   # caller-supplied $PLUGIN_ROOT: that variable is read at source time from
+#   # whatever scope did the sourcing, so a sub-shell that inherits
+#   # CLAUDE_PLUGIN_ROOT but not PLUGIN_ROOT loses every accessor below while
+#   # still exiting 0 (see ecosystem-88v, ecosystem-7bj). Four levels up from
+#   # plugins/<name>/scripts/lib is the repo root.
+#   _BURSAR_CONFIG_LIB_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+#   # shellcheck source=scripts/lib/config-loader.sh
+#   source "${_BURSAR_CONFIG_LIB_DIR}/../../../../scripts/lib/config-loader.sh"
+#
+#   The shellcheck directive is repo-root-relative, not file-relative: shellcheck
+#   resolves source= against its own working directory, and `npm run
+#   test:shellcheck` runs it from the repo root. A file-relative path there
+#   silently degrades to SC1091 "not following", which `-S error` hides.
 #   config_load_plugin "bursar" "$repo_root" "_BURSAR_CONFIG"
 #   config_get "_BURSAR_CONFIG" '.bursar.window'  # returns value or empty string
 #

package/scripts/lib/validate-path.sh

@@ -530,11 +530,32 @@ turn_state_next_tool() {
   fi
 }
 
-# Safely emit dev-os event (validates emit script exists)
-# Automatically exports turn state if not already set, so every emission
-# gets hook_type/turn/tool_call_seq in the envelope without callers needing
-# to call turn_state_export() explicitly.
-# Usage: echo "$INPUT" | safe_emit "event_type" '{"key":"value"}'
+# Safely emit an Onlooker event through the canonical emitter.
+#
+# Automatically exports turn state if not already set, so a caller does not have
+# to call turn_state_export() itself. Note the turn rides in the PAYLOAD, as
+# turn_number, for the event types whose schema declares it — the envelope has
+# no turn field and is additionalProperties:false.
+#
+# Returns non-zero and writes NOTHING when $ONLOOKER_EMIT is unavailable.
+#
+# There used to be a fallback here that hand-built an envelope with jq and
+# appended it directly. Every line it wrote was unvalidatable: it omitted all
+# five required id/schema_version/runtime/machine_id/sequence fields, and added
+# four the envelope forbids outright (hook_type, tool_name, turn,
+# tool_call_seq). It was reached only when $ONLOOKER_EMIT was missing — a file
+# that ships next to this one, so it never fired in a normal checkout or
+# install — which is how it stayed broken and unnoticed. See ecosystem-0tm.
+#
+# Dropping it rather than teaching it to call the emitter is the same
+# fail-closed choice made for prompt_rules_emit in ecosystem-aaz: an
+# unparseable line on the bus is worse than a missing one, and a second way to
+# build an envelope is a second thing to drift.
+#
+# Callers must tolerate a non-zero return — hooks run under `set -e`, so use
+# `safe_emit ... || true` when the emission is advisory.
+#
+# Usage: safe_emit "event_type" '{"key":"value"}'
 safe_emit() {
   local event_type="$1"
   local payload="$2"
@@ -544,38 +565,8 @@ safe_emit() {
     turn_state_export "$_HOOK_SESSION_ID"
   fi
 
-  if validate_file_exists "$ONLOOKER_EMIT"; then
-    "$ONLOOKER_EMIT" "$event_type" "$payload"
-  else
-    # Fallback: write directly to events log with envelope enrichment.
-    # Uses env vars set by hook_set_context() — NOT stdin (already consumed).
-    ensure_file_exists "$ONLOOKER_EVENTS_LOG" || return 1
-    local timestamp session_id plugin_name hook_type tool_name turn tool_seq
-    timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
-    session_id="${_HOOK_SESSION_ID:-}"
-    if [[ -z "$session_id" ]]; then
-      session_id=$(echo "$payload" | jq -r '.session_id // "unknown"' 2>/dev/null) || session_id="unknown"
-    fi
-    plugin_name="${ONLOOKER_PLUGIN_NAME:-unknown}"
-    hook_type="${ONLOOKER_HOOK_TYPE:-}"
-    tool_name="${ONLOOKER_TOOL_NAME:-}"
-    turn="${ONLOOKER_TURN_NUMBER:-}"
-    tool_seq="${ONLOOKER_TURN_TOOL_SEQ:-}"
-    jq -cn \
-      --arg ts "$timestamp" \
-      --arg sid "$session_id" \
-      --arg plugin "$plugin_name" \
-      --arg type "$event_type" \
-      --arg hook_type "$hook_type" \
-      --arg tool_name "$tool_name" \
-      --arg turn "$turn" \
-      --arg tool_seq "$tool_seq" \
-      --argjson payload "$payload" \
-      '{timestamp: $ts, session_id: $sid, plugin: $plugin, event_type: $type, payload: $payload}
-      + (if $hook_type != "" then {hook_type: $hook_type} else {} end)
-      + (if $tool_name != "" then {tool_name: $tool_name} else {} end)
-      + (if $turn != "" then {turn: ($turn | tonumber)} else {} end)
-      + (if $tool_seq != "" then {tool_call_seq: ($tool_seq | tonumber)} else {} end)
-      ' >> "$ONLOOKER_EVENTS_LOG"
+  if ! validate_file_exists "$ONLOOKER_EMIT"; then
+    return 1
   fi
+  "$ONLOOKER_EMIT" "$event_type" "$payload"
 }

package/test/bats/config-lib-self-locating.bats

@@ -0,0 +1,124 @@
+#!/usr/bin/env bats
+#
+# Guards that every plugin config lib locates config-loader.sh from its OWN
+# path, not from a caller-supplied $PLUGIN_ROOT.
+#
+# These libs used to open with:
+#
+#   source "${PLUGIN_ROOT}/../../scripts/lib/config-loader.sh"
+#
+# PLUGIN_ROOT is read at source time from whatever scope did the sourcing. From
+# a scope that never set it, the path collapses to
+# /../../scripts/lib/config-loader.sh, the source fails, and config_load_plugin
+# and config_get never get defined. The caller then gets empty strings from
+# every accessor while the script keeps going and exits 0 — the config silently
+# falls back to defaults instead of failing loudly.
+#
+# Cartographer hit exactly this (ecosystem-88v): run-audit.sh and both hooks
+# sourced the config lib inside `bash -c` sub-shells that inherited
+# CLAUDE_PLUGIN_ROOT but not PLUGIN_ROOT. It went unnoticed for months because
+# the analyzers take their settings as positional parameters and kept working.
+#
+# The sweep in ecosystem-7bj made every lib self-locating via BASH_SOURCE, which
+# is correct regardless of caller scope, cwd, or sub-shell nesting. These tests
+# cover all 16 at once so plugin 17 cannot quietly reintroduce the pattern.
+
+setup() {
+  source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+  setup_test_env
+}
+
+# Every plugins/<name>/scripts/lib/<name>-config.sh in the repo.
+_config_libs() {
+  find "${REPO_ROOT}/plugins" -path '*/scripts/lib/*-config.sh' -type f | sort
+}
+
+# Without this, a typo in _config_libs would make every test below pass over an
+# empty list and report coverage that does not exist. Not pinned to 16, so
+# adding or removing a plugin does not fail it.
+@test "the config-lib glob matches at least one file" {
+  local count
+  count=$(_config_libs | wc -l | tr -d ' ')
+  [ "$count" -gt 0 ]
+}
+
+@test "no config lib resolves config-loader.sh through \$PLUGIN_ROOT" {
+  local offenders=""
+  local lib
+  while IFS= read -r lib; do
+    if grep -q 'source "\${PLUGIN_ROOT}' "$lib"; then
+      offenders+="${lib#"${REPO_ROOT}/"}"$'\n'
+    fi
+  done < <(_config_libs)
+
+  [ -z "$offenders" ] || {
+    printf 'config libs still sourcing through $PLUGIN_ROOT:\n%s' "$offenders" >&2
+    return 1
+  }
+}
+
+@test "every config lib derives its own directory from BASH_SOURCE" {
+  local missing=""
+  local lib
+  while IFS= read -r lib; do
+    grep -q 'BASH_SOURCE\[0\]' "$lib" || missing+="${lib#"${REPO_ROOT}/"}"$'\n'
+  done < <(_config_libs)
+
+  [ -z "$missing" ] || {
+    printf 'config libs not self-locating via BASH_SOURCE:\n%s' "$missing" >&2
+    return 1
+  }
+}
+
+# The behavioral test the source-text guards above stand in for. Sources each
+# lib in a sub-shell with PLUGIN_ROOT unset and asserts the shared accessors it
+# depends on actually got defined.
+@test "every config lib yields working accessors with PLUGIN_ROOT unset" {
+  local failures=""
+  local lib
+  while IFS= read -r lib; do
+    local plugin_dir plugin_name out
+    plugin_dir="${lib%/scripts/lib/*}"
+    plugin_name="$(basename "$plugin_dir")"
+
+    # CLAUDE_PLUGIN_ROOT is set because config_load_plugin genuinely needs it to
+    # find the plugin's own config.json; PLUGIN_ROOT is deliberately absent,
+    # which is the exact shape of the sub-shell that broke cartographer.
+    out=$(env -u PLUGIN_ROOT CLAUDE_PLUGIN_ROOT="$plugin_dir" HOME="$HOME" \
+      bash -c '
+        set -u
+        source "$1" 2>&1 || exit 1
+        type -t config_load_plugin >/dev/null 2>&1 || { echo "config_load_plugin undefined"; exit 1; }
+        type -t config_get >/dev/null 2>&1 || { echo "config_get undefined"; exit 1; }
+        config_load_plugin "$2" "" _PROBE || { echo "config_load_plugin failed"; exit 1; }
+        # A plugin ships a config.json, so the merged config must be a non-empty
+        # JSON object. "{}" here would mean the load degraded to defaults.
+        printf "%s" "$_PROBE" | jq -e "type == \"object\" and (length > 0)" >/dev/null \
+          || { echo "merged config empty: $_PROBE"; exit 1; }
+      ' _ "$lib" "$plugin_name" 2>&1) \
+      || failures+="${plugin_name}: ${out}"$'\n'
+  done < <(_config_libs)
+
+  [ -z "$failures" ] || {
+    printf 'config libs broken when PLUGIN_ROOT is unset:\n%s' "$failures" >&2
+    return 1
+  }
+}
+
+# Regression guard for the specific reported failure, kept separate so a break
+# names cartographer directly rather than appearing in a list of 16.
+@test "cartographer config survives the sub-shell shape that broke it" {
+  local plugin_dir="${REPO_ROOT}/plugins/cartographer"
+  run env -u PLUGIN_ROOT CLAUDE_PLUGIN_ROOT="$plugin_dir" bash -c '
+    source "'"${plugin_dir}"'/scripts/lib/cartographer-config.sh"
+    cartographer_config_load ""
+    cartographer_config_audit_interval_hours
+  '
+  [ "$status" -eq 0 ] || return 1
+  # The shipped default. Under the old pattern this came back empty, because
+  # the accessor was never defined and the failure was swallowed.
+  [[ -n "$output" ]] || return 1
+  [[ "$output" != *"No such file or directory"* ]] || return 1
+  [[ "$output" != *"command not found"* ]] || return 1
+  [ "$output" -eq "$output" ] 2>/dev/null
+}