@onlooker-community/ecosystem 0.43.3 → 0.43.4

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "ecosystem",
-  "version": "0.43.3",
+  "version": "0.43.4",
   "description": "Observability substrate for Claude Code. Provides the shared $ONLOOKER_DIR storage root (default $HOME/.onlooker), canonical schema-validated event emission, session and tool tracking hooks, and prompt rules. Required by all other Onlooker plugins.",
   "author": {
     "name": "Onlooker Community",

package/.release-please-manifest.json

@@ -1,5 +1,5 @@
 {
-  ".": "0.43.3",
+  ".": "0.43.4",
   "plugins/archivist": "0.3.1",
   "plugins/tribunal": "1.2.7",
   "plugins/echo": "0.3.1",

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.43.4](https://github.com/onlooker-community/ecosystem/compare/ecosystem-v0.43.3...ecosystem-v0.43.4) (2026-08-22)
+
+
+### Bug Fixes
+
+* **events:** route prompt_rule emission through the canonical emitter :relieved: ([#196](https://github.com/onlooker-community/ecosystem/issues/196)) ([c233bfa](https://github.com/onlooker-community/ecosystem/commit/c233bfa466cf400e767f4673e0143081618314a7))
+
 ## [0.43.3](https://github.com/onlooker-community/ecosystem/compare/ecosystem-v0.43.2...ecosystem-v0.43.3) (2026-08-22)
 
 

package/docs/architecture.md

@@ -93,7 +93,9 @@ Every observable event flows through `onlooker-event.mjs` before being written t
 
 The schema is versioned independently and published to npm. Plugin shell scripts invoke `onlooker-event.mjs` at runtime so schema validation always reflects the installed version.
 
-> **Note:** Not all events in the JSONL log are schema-validated. `prompt_rule.*` events are currently emitted outside the canonical schema pipeline (`prompt_rules_emit` in `scripts/lib/prompt-rules.sh` writes straight to `$ONLOOKER_EVENTS_LOG` via `jq`, bypassing `onlooker-event.mjs` entirely). Schema-first emission is the goal for all future event types.
+> **Note:** Every emission path that fires in normal operation routes through `onlooker-event.mjs`. `prompt_rule.*` was the last routine exception — `prompt_rules_emit` hand-built its envelope with `jq` and wrote straight to `$ONLOOKER_EVENTS_LOG`, so those lines carried none of the required `id`/`schema_version`/`runtime`/`machine_id`/`sequence` fields and added a `turn` field the envelope forbids. It now goes through the emitter like everything else.
+>
+> One hand-built envelope remains, in the `safe_emit` fallback in `scripts/lib/validate-path.sh`. It is reached only when `$ONLOOKER_EMIT` is missing, which does not happen in a normal checkout or install, so it is latent rather than live — but if it ever fires it writes the same unvalidatable shape. Route new event types through the emitter rather than writing to the log directly: an envelope assembled anywhere else will drift from the schema without anything noticing.
 
 ### Emission gates
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlooker-community/ecosystem",
-  "version": "0.43.3",
+  "version": "0.43.4",
   "description": "Agents, skills, hooks, commands, rules, and MCP configurations that power [Onlooker](https://onlooker.dev)",
   "author": {
     "name": "Onlooker Community",

package/scripts/hooks/prompt-rule-injector.sh

@@ -6,9 +6,11 @@
 # and injects guidance for rules whose POSIX-ERE pattern matches the prompt.
 # Each rule fires at most once per session per rule_id.
 #
-# Emits canonical-ish events to ~/.onlooker/logs/onlooker-events.jsonl:
+# Emits canonical events to ~/.onlooker/logs/onlooker-events.jsonl:
 #   prompt_rule.matched — every match (including subsequent matches in-session)
 #   prompt_rule.applied — only when guidance is actually injected
+# Both route through onlooker-event.mjs and are schema-validated; a rejected
+# event is dropped rather than written, and never blocks prompt submission.
 #
 # Usage:
 #   echo "$INPUT" | prompt-rule-injector.sh
@@ -74,8 +76,14 @@ while IFS= read -r rule; do
     continue
   fi
 
+  # match_type and trigger_source are required by the prompt_rule.matched
+  # payload schema. Both are fixed for this hook rather than derived: rules
+  # match with bash `[[ =~ ]]`, which is POSIX ERE, and the only thing this
+  # UserPromptSubmit hook ever matches against is the prompt itself. A future
+  # vocabulary or file-path matcher would set them from the rule.
   prompt_rules_emit "$SESSION_ID" "prompt_rule.matched" \
-    "$(jq -cn --arg id "$RULE_ID" '{rule_id: $id}')" || true
+    "$(jq -cn --arg id "$RULE_ID" \
+      '{rule_id: $id, match_type: "regex", trigger_source: "prompt"}')" || true
 
   ALREADY_FIRED=$(echo "$FIRED" | jq --arg id "$RULE_ID" 'index($id) != null' 2>/dev/null)
   if [[ "$FIRE_ONCE" == "true" && "$ALREADY_FIRED" == "true" ]]; then

package/scripts/lib/prompt-rules.sh

@@ -26,6 +26,13 @@
 export ONLOOKER_PROMPT_RULES_DIR="${ONLOOKER_PROMPT_RULES_DIR:-$ONLOOKER_DIR/prompt-rules}"
 export ONLOOKER_PROMPT_RULES_SESSIONS_DIR="$ONLOOKER_PROMPT_RULES_DIR/sessions"
 
+# The canonical emitter is a sibling file, so resolve it from this script's own
+# location rather than from a caller-supplied $CLAUDE_PLUGIN_ROOT. Sourcing this
+# lib from a scope that never set that variable then still yields a working
+# emit path instead of a silent no-op.
+_PROMPT_RULES_LIB_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+_PROMPT_RULES_EVENT_JS="$_PROMPT_RULES_LIB_DIR/onlooker-event.mjs"
+
 # Path to the global rules file.
 # Usage: path=$(prompt_rules_global_path)
 prompt_rules_global_path() {
@@ -142,8 +149,24 @@ prompt_rules_pattern_matches() {
 }
 
 # Append a prompt-rule event to the global events log.
-# These event types (prompt_rule.matched, prompt_rule.applied) are not yet
-# in @onlooker-community/schema; once added, swap to onlooker_append_event.
+#
+# Routes through onlooker-event.mjs like every other emit path in the repo, so
+# the envelope is built once, in one place, and validated against
+# @onlooker-community/schema wherever that package resolves (dev, CI, tests).
+#
+# This used to hand-build a five-field envelope with jq. That envelope was
+# never valid: it omitted every required id/schema_version/runtime/machine_id/
+# sequence field, and it added a `turn` field the envelope forbids outright
+# (event.v1.json is additionalProperties:false and has no `turn`). The canonical
+# emitter carries a turn as `turn_number` INSIDE the payload, and neither
+# prompt_rule payload schema has that property, so a turn number has nowhere
+# valid to go on these two event types and is no longer recorded.
+#
+# Fails closed: if the emitter is missing or rejects the payload, nothing is
+# written. A dropped telemetry event beats an unparseable line on the bus, and
+# both callers in prompt-rule-injector.sh already discard the return with
+# `|| true` so a rejection can never block prompt submission.
+#
 # Usage: prompt_rules_emit "$session_id" "prompt_rule.matched" "$payload_json"
 prompt_rules_emit() {
   local session_id="${1:-unknown}"
@@ -155,22 +178,30 @@ prompt_rules_emit() {
   local payload_json="${3:-}"
   [ -z "$payload_json" ] && payload_json='{}'
   [[ -z "$event_type" ]] && return 1
-  ensure_file_exists "$ONLOOKER_EVENTS_LOG" || return 1
 
-  local timestamp plugin
-  timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
+  local event_js="$_PROMPT_RULES_EVENT_JS"
+  [[ -n "${_ONLOOKER_EVENT_JS:-}" && -f "${_ONLOOKER_EVENT_JS}" ]] && event_js="$_ONLOOKER_EVENT_JS"
+  [[ -f "$event_js" ]] || return 1
+
+  local plugin
   plugin="${ONLOOKER_PLUGIN_NAME:-onlooker}"
 
-  jq -cn \
-    --arg ts "$timestamp" \
-    --arg sid "$session_id" \
+  local params
+  params=$(jq -cn \
     --arg plugin "$plugin" \
+    --arg sid "$session_id" \
     --arg type "$event_type" \
     --argjson payload "$payload_json" \
-    --arg turn "${ONLOOKER_TURN_NUMBER:-}" \
-    '{timestamp: $ts, session_id: $sid, plugin: $plugin, event_type: $type, payload: $payload}
-     + (if $turn != "" then {turn: ($turn | tonumber)} else {} end)
-    ' >> "$ONLOOKER_EVENTS_LOG"
+    '{plugin: $plugin, session_id: $sid, event_type: $type, payload: $payload}') || return 1
+
+  local event
+  event=$(printf '%s' "$params" \
+    | ONLOOKER_DIR="$ONLOOKER_DIR" ONLOOKER_PLUGIN_NAME="$plugin" \
+      node "$event_js" emit 2>/dev/null) || return 1
+  [[ -z "$event" ]] && return 1
+
+  ensure_file_exists "$ONLOOKER_EVENTS_LOG" || return 1
+  printf '%s\n' "$event" >> "$ONLOOKER_EVENTS_LOG"
 }
 
 # Print a human-readable table of merged rules with their fired status.

package/test/bats/prompt-rules.bats

@@ -295,9 +295,13 @@ write_project_rules() {
   [ "$path" = "$expected" ]
 }
 
+# The canonical prompt_rule.matched payload. Both extra fields are required by
+# the schema, so every positive matched-event test has to carry them.
+MATCHED_PAYLOAD='{"rule_id":"rule-1","match_type":"regex","trigger_source":"prompt"}'
+
 @test "emit: appends a JSON event line with type, session, payload, and plugin" {
   : >"$ONLOOKER_EVENTS_LOG"
-  run prompt_rules_emit "sess-emit" "prompt_rule.matched" '{"rule_id":"rule-1"}'
+  run prompt_rules_emit "sess-emit" "prompt_rule.matched" "$MATCHED_PAYLOAD"
   [ "$status" -eq 0 ]
 
   local line
@@ -309,59 +313,92 @@ write_project_rules() {
   [ "$(echo "$line" | jq -r '.plugin')" = "onlooker" ]
 }
 
-@test "emit: honors ONLOOKER_PLUGIN_NAME for the plugin field" {
+@test "emit: writes a full canonical envelope, not a hand-built subset" {
   : >"$ONLOOKER_EVENTS_LOG"
-  ONLOOKER_PLUGIN_NAME="prompt-rules" prompt_rules_emit "sess-plugin" "prompt_rule.applied" '{"rule_id":"r9"}'
+  prompt_rules_emit "sess-envelope" "prompt_rule.matched" "$MATCHED_PAYLOAD"
 
   local line
   line=$(tail -1 "$ONLOOKER_EVENTS_LOG")
-  [ "$(echo "$line" | jq -r '.plugin')" = "prompt-rules" ]
+  # The five fields the old jq-built envelope omitted. Each is required by
+  # event.v1.json, so their absence is what made those lines unvalidatable.
+  [ "$(echo "$line" | jq -r 'has("id")')" = "true" ]
+  [ "$(echo "$line" | jq -r 'has("schema_version")')" = "true" ]
+  [ "$(echo "$line" | jq -r 'has("runtime")')" = "true" ]
+  [ "$(echo "$line" | jq -r 'has("machine_id")')" = "true" ]
+  [ "$(echo "$line" | jq -r 'has("sequence")')" = "true" ]
+  [ "$(echo "$line" | jq -r '.sequence | type')" = "number" ]
 }
 
-@test "emit: defaults payload to an empty object when none is given" {
+@test "emit: honors ONLOOKER_PLUGIN_NAME for the plugin field" {
   : >"$ONLOOKER_EVENTS_LOG"
-  run prompt_rules_emit "sess-nopayload" "prompt_rule.matched"
-  [ "$status" -eq 0 ]
+  ONLOOKER_PLUGIN_NAME="prompt-rules" prompt_rules_emit "sess-plugin" "prompt_rule.applied" '{"rule_id":"r9"}'
 
   local line
   line=$(tail -1 "$ONLOOKER_EVENTS_LOG")
-  [ "$(echo "$line" | jq -c '.payload')" = "{}" ]
+  [ "$(echo "$line" | jq -r '.plugin')" = "prompt-rules" ]
 }
 
 @test "emit: defaults session id to 'unknown' when none is given" {
   : >"$ONLOOKER_EVENTS_LOG"
-  prompt_rules_emit "" "prompt_rule.matched" '{}'
+  prompt_rules_emit "" "prompt_rule.matched" "$MATCHED_PAYLOAD"
 
   local line
   line=$(tail -1 "$ONLOOKER_EVENTS_LOG")
   [ "$(echo "$line" | jq -r '.session_id')" = "unknown" ]
 }
 
-@test "emit: includes a numeric turn field when ONLOOKER_TURN_NUMBER is exported" {
+# The old hand-built envelope added `turn` from ONLOOKER_TURN_NUMBER. event.v1.json
+# is additionalProperties:false and has no `turn`, so that field was one of the
+# reasons those lines could never validate. The canonical emitter carries a turn
+# as `turn_number` inside the payload, and neither prompt_rule payload schema
+# declares that property, so the turn has nowhere valid to live on these events.
+@test "emit: does not add a turn field the envelope schema forbids" {
   : >"$ONLOOKER_EVENTS_LOG"
-  ONLOOKER_TURN_NUMBER=7 prompt_rules_emit "sess-turn" "prompt_rule.matched" '{}'
+  ONLOOKER_TURN_NUMBER=7 prompt_rules_emit "sess-turn" "prompt_rule.matched" "$MATCHED_PAYLOAD"
 
   local line
   line=$(tail -1 "$ONLOOKER_EVENTS_LOG")
-  [ "$(echo "$line" | jq -r '.turn')" = "7" ]
-  [ "$(echo "$line" | jq -r '.turn | type')" = "number" ]
+  [ "$(echo "$line" | jq -r 'has("turn")')" = "false" ]
+  [ "$(echo "$line" | jq -r '.payload | has("turn_number")')" = "false" ]
 }
 
-@test "emit: omits the turn field when ONLOOKER_TURN_NUMBER is unset" {
+@test "emit: returns 1 and writes nothing when event_type is empty" {
   : >"$ONLOOKER_EVENTS_LOG"
-  # Guard against any ambient value leaking in from the environment.
-  unset ONLOOKER_TURN_NUMBER
-  prompt_rules_emit "sess-noturn" "prompt_rule.matched" '{}'
+  run prompt_rules_emit "sess-empty" ""
+  [ "$status" -eq 1 ]
+  [ ! -s "$ONLOOKER_EVENTS_LOG" ]
+}
 
-  local line
-  line=$(tail -1 "$ONLOOKER_EVENTS_LOG")
-  [ "$(echo "$line" | jq -e 'has("turn")')" = "false" ] || \
-    [ "$(echo "$line" | jq 'has("turn")')" = "false" ]
+# Fail-closed is the whole point of routing through the emitter: an event that
+# cannot be made valid must not reach the bus at all. Before this change the
+# same call wrote a line regardless.
+@test "emit: rejects a matched payload missing the schema's required fields" {
+  : >"$ONLOOKER_EVENTS_LOG"
+  expect_emission_rejected prompt_rules_emit "sess-bad" "prompt_rule.matched" '{"rule_id":"only-id"}'
+  [ "$status" -ne 0 ]
+  [ ! -s "$ONLOOKER_EVENTS_LOG" ]
 }
 
-@test "emit: returns 1 and writes nothing when event_type is empty" {
+@test "emit: rejects an empty payload for an event type that requires fields" {
   : >"$ONLOOKER_EVENTS_LOG"
-  run prompt_rules_emit "sess-empty" ""
-  [ "$status" -eq 1 ]
+  expect_emission_rejected prompt_rules_emit "sess-nopayload" "prompt_rule.matched"
+  [ "$status" -ne 0 ]
+  [ ! -s "$ONLOOKER_EVENTS_LOG" ]
+}
+
+@test "emit: rejects an unknown event type" {
+  : >"$ONLOOKER_EVENTS_LOG"
+  expect_emission_rejected prompt_rules_emit "sess-unknown" "prompt_rule.invented" '{}'
+  [ "$status" -ne 0 ]
   [ ! -s "$ONLOOKER_EVENTS_LOG" ]
 }
+
+@test "emit: accepts prompt_rule.applied with the fields the injector sends" {
+  : >"$ONLOOKER_EVENTS_LOG"
+  run prompt_rules_emit "sess-applied" "prompt_rule.applied" '{"rule_id":"r9","guidance_chars":42}'
+  [ "$status" -eq 0 ]
+
+  local line
+  line=$(tail -1 "$ONLOOKER_EVENTS_LOG")
+  [ "$(echo "$line" | jq -r '.payload.guidance_chars')" = "42" ]
+}

package/test/bus-coverage.json

@@ -55,6 +55,8 @@
     "lineage.query.answered",
     "memory.recalled",
     "onlooker.artifact.ready",
+    "prompt_rule.applied",
+    "prompt_rule.matched",
     "session.compact",
     "session.end",
     "session.prompt",
@@ -113,8 +115,6 @@
     "onlooker.session.summary": "emitted by the agent, not this repo",
     "oracle.calibration.complete": "plugin lives in another repo",
     "oracle.calibration.requested": "plugin lives in another repo",
-    "prompt_rule.applied": "prompt_rules_emit in scripts/lib/prompt-rules.sh writes straight to $ONLOOKER_EVENTS_LOG via jq, bypassing onlooker-event.mjs, so it never reaches the schema-validating emitter this harness observes even though test/bats/prompt-rules.bats exercises it",
-    "prompt_rule.matched": "prompt_rules_emit in scripts/lib/prompt-rules.sh writes straight to $ONLOOKER_EVENTS_LOG via jq, bypassing onlooker-event.mjs, so it never reaches the schema-validating emitter this harness observes even though test/bats/prompt-rules.bats exercises it",
     "relay.handoff.captured": "plugin lives in another repo",
     "relay.handoff.injected": "plugin lives in another repo",
     "scribe.capture.complete": "no scribe_emit_event call for this type exists anywhere in plugins/scribe; only scribe.distill.complete and onlooker.artifact.ready are wired up",