@onlooker-community/ecosystem 0.34.0 → 0.43.0

package/test/bats/config.bats

@@ -27,7 +27,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PreToolUse[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *tool-sequence-tracker.sh ]]
+  [[ "$hook_cmd" == *tool-sequence-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -41,7 +41,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PreToolUse[1].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *agent-spawn-tracker.sh ]]
+  [[ "$hook_cmd" == *agent-spawn-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -55,7 +55,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PreToolUse[2].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *skill-usage-tracker.sh ]]
+  [[ "$hook_cmd" == *skill-usage-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -78,7 +78,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PostToolUse[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *tool-history-tracker.sh ]]
+  [[ "$hook_cmd" == *tool-history-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -103,9 +103,9 @@ setup_file() {
   turn_cmd=$(jq -r '.hooks.UserPromptSubmit[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
   duration_cmd=$(jq -r '.hooks.UserPromptSubmit[0].hooks[1].command' "${REPO_ROOT}/hooks/hooks.json")
   rule_cmd=$(jq -r '.hooks.UserPromptSubmit[0].hooks[2].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$turn_cmd" == *turn-tracker.sh ]]
-  [[ "$duration_cmd" == *session-duration-tracker.sh ]]
-  [[ "$rule_cmd" == *prompt-rule-injector.sh ]]
+  [[ "$turn_cmd" == *turn-tracker.sh ]] || return 1
+  [[ "$duration_cmd" == *session-duration-tracker.sh ]] || return 1
+  [[ "$rule_cmd" == *prompt-rule-injector.sh ]] || return 1
 
   for hook_cmd in "$turn_cmd" "$duration_cmd" "$rule_cmd"; do
     local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
@@ -121,7 +121,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.SessionStart[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *session-start-tracker.sh ]]
+  [[ "$hook_cmd" == *session-start-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -135,7 +135,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PreCompact[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *pre-compact-tracker.sh ]]
+  [[ "$hook_cmd" == *pre-compact-tracker.sh ]] || return 1
 
   run jq -e '.hooks.PreCompact[0].matcher == "manual" and .hooks.PreCompact[1].matcher == "auto"' \
     "${REPO_ROOT}/hooks/hooks.json"
@@ -153,7 +153,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PostCompact[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *context-compact-tracker.sh ]]
+  [[ "$hook_cmd" == *context-compact-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -167,7 +167,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.SessionEnd[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *session-end-tracker.sh ]]
+  [[ "$hook_cmd" == *session-end-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -178,7 +178,7 @@ setup_file() {
 @test "hooks.json TaskCreated references task-tracker" {
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.TaskCreated[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *task-tracker.sh ]]
+  [[ "$hook_cmd" == *task-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -189,7 +189,7 @@ setup_file() {
 @test "hooks.json TaskCompleted references task-tracker" {
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.TaskCompleted[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *task-tracker.sh ]]
+  [[ "$hook_cmd" == *task-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -200,7 +200,7 @@ setup_file() {
 @test "hooks.json WorktreeCreate references worktree-tracker" {
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.WorktreeCreate[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *worktree-tracker.sh ]]
+  [[ "$hook_cmd" == *worktree-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -211,7 +211,7 @@ setup_file() {
 @test "hooks.json WorktreeRemove references worktree-tracker" {
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.WorktreeRemove[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *worktree-tracker.sh ]]
+  [[ "$hook_cmd" == *worktree-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"

package/test/bats/curator-session-start.bats

@@ -35,10 +35,17 @@ setup() {
   # project settings file.
   MEM_DIR="${TEST_HOME}/.claude/projects/test-project/memory"
   mkdir -p "$MEM_DIR" "${PROJECT_REPO}/.claude"
+  # Pin a generous wall-clock budget. The hook checks
+  # cheap_checks.wall_clock_budget_ms before EACH phase and skips the rest
+  # once it trips, so at the shipped default of 500ms a loaded machine can
+  # blow the budget before the later phases run — the orphan check among
+  # them — and those tests fail intermittently while passing in isolation.
+  # These tests assert what the checks detect, not how fast the host is.
   jq -n --arg path "$MEM_DIR" \
     '{
       curator: {
         memory_store_path: $path,
+        cheap_checks: { wall_clock_budget_ms: 600000 },
         date_check: { date_grace_period_days: 7 }
       }
     }' > "${PROJECT_REPO}/.claude/settings.json"
@@ -93,8 +100,8 @@ _write_index() {
   # Surfacer rendered the pointer.
   local ctx
   ctx=$(echo "$output" | jq -r '.hookSpecificOutput.additionalContext')
-  [[ "$ctx" == *"Curator: 1 open finding"* ]]
-  [[ "$ctx" == *"date-decayed"* ]]
+  [[ "$ctx" == *"Curator: 1 open finding"* ]] || return 1
+  [[ "$ctx" == *"date-decayed"* ]] || return 1
   [[ "$ctx" == *"/curator review"* ]]
 }
 
@@ -256,7 +263,7 @@ BODY
   [ "$status" -eq 0 ]
   local ctx
   ctx=$(echo "$output" | jq -r '.hookSpecificOutput.additionalContext')
-  [[ "$ctx" == *"2 date-decayed"* ]]
+  [[ "$ctx" == *"2 date-decayed"* ]] || return 1
   # The buggy output would have looked like "1 date-decayed, 1 date-decayed".
   [[ "$ctx" != *"1 date-decayed, 1 date-decayed"* ]]
 }

package/test/bats/emit-payload-default.bats

@@ -0,0 +1,52 @@
+#!/usr/bin/env bats
+#
+# Guards the payload-default expansion in every emit helper.
+#
+# Two tempting forms are both wrong, and each fails in a way the other does not:
+#
+#   "${3:-{\}}"  keeps the backslash on bash 3.2 (the bash macOS ships, and the
+#                one `#!/usr/bin/env bash` resolves to there), yielding {\} —
+#                invalid JSON, so the emit silently drops the event. Works on
+#                bash 5.x, which is why CI never caught it.
+#   "${3:-{}}"   appends a stray `}` to any payload that IS supplied, on EVERY
+#                bash version, corrupting the far more common path.
+#
+# The brace-free form below is correct on both. This test runs the real
+# expansion under the real interpreter rather than asserting on source text.
+
+setup() {
+	source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+	setup_test_env
+}
+
+_emit_libs() {
+	printf '%s\n' \
+		"scripts/lib/prompt-rules.sh" \
+		"plugins/curator/scripts/lib/curator-emit.sh" \
+		"plugins/historian/scripts/lib/historian-emit.sh" \
+		"plugins/librarian/scripts/lib/librarian-emit.sh" \
+		"plugins/librarian/scripts/lib/librarian-cli.sh" \
+		"plugins/tribunal/scripts/lib/tribunal-gate.sh"
+}
+
+@test "no emit helper inlines braces in a parameter-expansion default" {
+	# Code only — a comment explaining the hazard must not trip its own guard.
+	local hits
+	hits=$(cd "$REPO_ROOT" && grep -rn ':-{' --include="*.sh" scripts/ plugins/ \
+		| grep -vE '^[^:]+:[0-9]+:[[:space:]]*#' || true)
+	[ -z "$hits" ]
+}
+
+@test "the brace-free default yields {} when no payload is passed" {
+	local probe="${BATS_TEST_TMPDIR}/probe.sh"
+	printf '%s\n' 'f() { local p="${3:-}"; [ -z "$p" ] && p='"'"'{}'"'"'; printf "%s" "$p"; }' 'f a b' >"$probe"
+	run bash "$probe"
+	[ "$status" -eq 0 ] && [ "$output" = '{}' ]
+}
+
+@test "the brace-free default passes a supplied payload through unchanged" {
+	local probe="${BATS_TEST_TMPDIR}/probe.sh"
+	printf '%s\n' 'f() { local p="${3:-}"; [ -z "$p" ] && p='"'"'{}'"'"'; printf "%s" "$p"; }' 'f a b '"'"'{"a":{"b":1}}'"'"'' >"$probe"
+	run bash "$probe"
+	[ "$status" -eq 0 ] && [ "$output" = '{"a":{"b":1}}' ]
+}

package/test/bats/governor-ledger.bats

@@ -91,7 +91,7 @@ _make_completion() {
 @test "governor_ledger_path returns a .jsonl path under ONLOOKER_DIR" {
 	local p
 	p=$(governor_ledger_path "test-session")
-	[[ "$p" == *".jsonl" ]]
+	[[ "$p" == *".jsonl" ]] || return 1
 	[[ "$p" == *"test-session"* ]]
 }
 

package/test/bats/historian-prompt-submit.bats

@@ -157,7 +157,7 @@ _index_session() {
 
   local ctx
   ctx=$(echo "$output" | jq -r '.hookSpecificOutput.additionalContext')
-  [[ "$ctx" == *"Historian: a past chunk looks similar"* ]]
+  [[ "$ctx" == *"Historian: a past chunk looks similar"* ]] || return 1
   [[ "$ctx" == *"redash"* ]]
 
   grep '"event_type":"historian.retrieval.surfaced"' "$ONLOOKER_EVENTS_LOG" \

package/test/bats/inspector-post-write-hook.bats

@@ -100,7 +100,7 @@ _run_hook() {
 	echo '{"inspector":{"show_clean_runs":true,"checks":{".ts":[{"name":"clean","kind":"lint","argv":["true"]}]}}}' | _settings
 	run _run_hook "$(_input)"
 	[ "$status" -eq 0 ]
-	[[ "$output" == *"inspector: src/sample.ts"* ]]
+	[[ "$output" == *"inspector: src/sample.ts"* ]] || return 1
 	[[ "$output" == *"✓ clean"* ]]
 }
 
@@ -112,9 +112,9 @@ _run_hook() {
 EOF
 	run _run_hook "$(_input)"
 	[ "$status" -eq 0 ]
-	[[ "$output" == *"inspector: src/sample.ts"* ]]
-	[[ "$output" == *"✗ broken"* ]]
-	[[ "$output" == *"src/sample.ts:1:1 - Bad"* ]]
+	[[ "$output" == *"inspector: src/sample.ts"* ]] || return 1
+	[[ "$output" == *"✗ broken"* ]] || return 1
+	[[ "$output" == *"src/sample.ts:1:1 - Bad"* ]] || return 1
 	[ "$(_event_count inspector.check.failed)" = "1" ]
 	[ "$(jq -r 'select(.event_type=="inspector.check.failed").payload.exit_code' "$ONLOOKER_EVENTS_LOG")" = "2" ]
 }