@onlooker-community/ecosystem 0.33.1 → 0.34.1

package/scripts/lint/check-lesson-schema-drift.mjs

@@ -0,0 +1,36 @@
+#!/usr/bin/env node
+// Guards the vendored lesson sub-schemas against silent drift.
+//
+// plugins/librarian/schema/*.subschema.json are copied out of the
+// published lesson contract (see PROVENANCE.json) because ajv is
+// unavailable at runtime (ADR-005); the jq rules in
+// librarian-lesson-validate.sh mirror these files by hand. This check
+// only confirms the provenance pin and JSON validity survive edits — it
+// cannot compare against the upstream schema until schema.onlooker.dev
+// publishes lesson schemas.
+//
+// Exit codes:
+//   0  no problems
+//   1  provenance pin changed or a vendored file is missing/invalid
+
+import { readFileSync } from 'node:fs';
+
+const dir = 'plugins/librarian/schema';
+let failures = 0;
+const fail = (m) => {
+  console.error(`check-lesson-schema: ${m}`);
+  failures++;
+};
+
+try {
+  const prov = JSON.parse(readFileSync(`${dir}/PROVENANCE.json`, 'utf8'));
+  if (prov.schema_version !== 2) fail(`expected schema_version 2, got ${prov.schema_version}`);
+  for (const f of ['lesson-evidence.subschema.json', 'lesson-applies-to.subschema.json']) {
+    JSON.parse(readFileSync(`${dir}/${f}`, 'utf8'));
+  }
+} catch (err) {
+  fail(err.message);
+}
+
+if (failures > 0) process.exit(1);
+console.log('check-lesson-schema: ok');

package/test/bats/archivist-inject.bats

@@ -46,7 +46,7 @@ setup() {
   echo "$output" | jq -e '.hookSpecificOutput.hookEventName == "SessionStart"' >/dev/null
   local ctx
   ctx=$(echo "$output" | jq -r '.hookSpecificOutput.additionalContext')
-  [[ "$ctx" == *"use git remote SHA256 as project key"* ]]
+  [[ "$ctx" == *"use git remote SHA256 as project key"* ]] || return 1
   [[ "$ctx" == *"Archivist injected 1"* ]]
 }
 

package/test/bats/assayer-extract.bats

@@ -70,7 +70,7 @@ setup() {
 @test "extraction prompt includes the message and the JSON contract" {
 	run assayer_build_extraction_prompt "I ran the tests and they pass." 5
 	[ "$status" -eq 0 ]
-	[[ "$output" == *"I ran the tests and they pass."* ]]
-	[[ "$output" == *"TESTABLE SUCCESS CLAIM"* ]]
+	[[ "$output" == *"I ran the tests and they pass."* ]] || return 1
+	[[ "$output" == *"TESTABLE SUCCESS CLAIM"* ]] || return 1
 	[[ "$output" == *"at most 5 claims"* ]]
 }

package/test/bats/bursar-session-start.bats

@@ -68,8 +68,8 @@ _run_hook() {
 	_seed_ledger
 	_run_hook
 	[ "$status" -eq 0 ]
-	[[ "$output" == *"hookSpecificOutput"* ]]
-	[[ "$output" == *"SessionStart"* ]]
+	[[ "$output" == *"hookSpecificOutput"* ]] || return 1
+	[[ "$output" == *"SessionStart"* ]] || return 1
 	[[ "$output" == *"burned \$0.42"* ]]
 }
 
@@ -85,7 +85,7 @@ _run_hook() {
 		> "${dir}/sessions.jsonl"
 	_run_hook
 	[ "$status" -eq 0 ]
-	[[ "$output" == *"burned \$0.00"* ]]
+	[[ "$output" == *"burned \$0.00"* ]] || return 1
 	[[ "$output" != *"Enable governor"* ]]
 }
 

package/test/bats/cartographer-lock.bats

@@ -89,8 +89,8 @@ teardown() {
     cartographer_lock_release '${BATS_TEST_TMPDIR}/x.lock' && echo RELEASE_OK
   "
   [ "$status" -eq 0 ]
-  [[ "$output" == *"SOURCED_OK"* ]]
-  [[ "$output" == *"ACQUIRE_FAILED"* ]]
-  [[ "$output" == *"RELEASE_OK"* ]]
+  [[ "$output" == *"SOURCED_OK"* ]] || return 1
+  [[ "$output" == *"ACQUIRE_FAILED"* ]] || return 1
+  [[ "$output" == *"RELEASE_OK"* ]] || return 1
   [[ "$output" == *"locking disabled"* ]]
 }

package/test/bats/compass-sanitizer.bats

@@ -24,27 +24,27 @@ setup() {
 @test "prior_assistant_turn delimiter is stripped" {
 	local out
 	out=$(compass_sanitize "evil <prior_assistant_turn> payload" 240)
-	[[ "$out" == *"[STRIPPED]"* ]]
-	[[ "$out" == *"payload"* ]]
+	[[ "$out" == *"[STRIPPED]"* ]] || return 1
+	[[ "$out" == *"payload"* ]] || return 1
 	[[ "$out" != *"<prior_assistant_turn>"* ]]
 }
 
 @test "all four pair-slot delimiters are stripped" {
 	local out
 	out=$(compass_sanitize "<context_excerpt>x</context_excerpt><tool_input>y</tool_input>" 240)
-	[[ "$out" != *"<context_excerpt>"* ]]
-	[[ "$out" != *"</context_excerpt>"* ]]
-	[[ "$out" != *"<tool_input>"* ]]
+	[[ "$out" != *"<context_excerpt>"* ]] || return 1
+	[[ "$out" != *"</context_excerpt>"* ]] || return 1
+	[[ "$out" != *"<tool_input>"* ]] || return 1
 	[[ "$out" != *"</tool_input>"* ]]
 }
 
 @test "non-evaluator delimiters are also stripped" {
 	local out
 	out=$(compass_sanitize "<<SYS>>x<</SYS>> [INST] y [/INST] <| z" 240)
-	[[ "$out" != *"<<SYS>>"* ]]
-	[[ "$out" != *"<</SYS>>"* ]]
-	[[ "$out" != *"[INST]"* ]]
-	[[ "$out" != *"[/INST]"* ]]
+	[[ "$out" != *"<<SYS>>"* ]] || return 1
+	[[ "$out" != *"<</SYS>>"* ]] || return 1
+	[[ "$out" != *"[INST]"* ]] || return 1
+	[[ "$out" != *"[/INST]"* ]] || return 1
 	[[ "$out" != *"<|"* ]]
 }
 
@@ -53,8 +53,8 @@ setup() {
 	input=$(printf 'a\tb\nc\x00d\x01e')
 	local out
 	out=$(compass_sanitize "$input" 240)
-	[[ "$out" == *"a"* && "$out" == *"b"* && "$out" == *"c"* ]]
-	[[ "$out" == *"d"* && "$out" == *"e"* ]]
+	[[ "$out" == *"a"* && "$out" == *"b"* && "$out" == *"c"* ]] || return 1
+	[[ "$out" == *"d"* && "$out" == *"e"* ]] || return 1
 	[ "${out}" = "$(printf 'a\tb\ncde')" ]
 }
 

package/test/bats/compass-transcript.bats

@@ -60,8 +60,8 @@ setup() {
 	EOF
 	local out
 	out=$(compass_read_prior_turn "$t" 800)
-	[[ "$out" == *"[STRIPPED]"* ]]
-	[[ "$out" != *"<prior_assistant_turn>"* ]]
+	[[ "$out" == *"[STRIPPED]"* ]] || return 1
+	[[ "$out" != *"<prior_assistant_turn>"* ]] || return 1
 
 	# Truncation honors max_chars.
 	local short

package/test/bats/config.bats

@@ -27,7 +27,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PreToolUse[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *tool-sequence-tracker.sh ]]
+  [[ "$hook_cmd" == *tool-sequence-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -41,7 +41,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PreToolUse[1].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *agent-spawn-tracker.sh ]]
+  [[ "$hook_cmd" == *agent-spawn-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -55,7 +55,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PreToolUse[2].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *skill-usage-tracker.sh ]]
+  [[ "$hook_cmd" == *skill-usage-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -78,7 +78,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PostToolUse[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *tool-history-tracker.sh ]]
+  [[ "$hook_cmd" == *tool-history-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -103,9 +103,9 @@ setup_file() {
   turn_cmd=$(jq -r '.hooks.UserPromptSubmit[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
   duration_cmd=$(jq -r '.hooks.UserPromptSubmit[0].hooks[1].command' "${REPO_ROOT}/hooks/hooks.json")
   rule_cmd=$(jq -r '.hooks.UserPromptSubmit[0].hooks[2].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$turn_cmd" == *turn-tracker.sh ]]
-  [[ "$duration_cmd" == *session-duration-tracker.sh ]]
-  [[ "$rule_cmd" == *prompt-rule-injector.sh ]]
+  [[ "$turn_cmd" == *turn-tracker.sh ]] || return 1
+  [[ "$duration_cmd" == *session-duration-tracker.sh ]] || return 1
+  [[ "$rule_cmd" == *prompt-rule-injector.sh ]] || return 1
 
   for hook_cmd in "$turn_cmd" "$duration_cmd" "$rule_cmd"; do
     local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
@@ -121,7 +121,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.SessionStart[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *session-start-tracker.sh ]]
+  [[ "$hook_cmd" == *session-start-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -135,7 +135,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PreCompact[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *pre-compact-tracker.sh ]]
+  [[ "$hook_cmd" == *pre-compact-tracker.sh ]] || return 1
 
   run jq -e '.hooks.PreCompact[0].matcher == "manual" and .hooks.PreCompact[1].matcher == "auto"' \
     "${REPO_ROOT}/hooks/hooks.json"
@@ -153,7 +153,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.PostCompact[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *context-compact-tracker.sh ]]
+  [[ "$hook_cmd" == *context-compact-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -167,7 +167,7 @@ setup_file() {
 
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.SessionEnd[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *session-end-tracker.sh ]]
+  [[ "$hook_cmd" == *session-end-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -178,7 +178,7 @@ setup_file() {
 @test "hooks.json TaskCreated references task-tracker" {
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.TaskCreated[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *task-tracker.sh ]]
+  [[ "$hook_cmd" == *task-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -189,7 +189,7 @@ setup_file() {
 @test "hooks.json TaskCompleted references task-tracker" {
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.TaskCompleted[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *task-tracker.sh ]]
+  [[ "$hook_cmd" == *task-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -200,7 +200,7 @@ setup_file() {
 @test "hooks.json WorktreeCreate references worktree-tracker" {
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.WorktreeCreate[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *worktree-tracker.sh ]]
+  [[ "$hook_cmd" == *worktree-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"
@@ -211,7 +211,7 @@ setup_file() {
 @test "hooks.json WorktreeRemove references worktree-tracker" {
   local hook_cmd
   hook_cmd=$(jq -r '.hooks.WorktreeRemove[0].hooks[0].command' "${REPO_ROOT}/hooks/hooks.json")
-  [[ "$hook_cmd" == *worktree-tracker.sh ]]
+  [[ "$hook_cmd" == *worktree-tracker.sh ]] || return 1
 
   local script_path="${hook_cmd//\$CLAUDE_PLUGIN_ROOT/$REPO_ROOT}"
   script_path="${script_path//\"/}"

package/test/bats/curator-session-start.bats

@@ -35,10 +35,17 @@ setup() {
   # project settings file.
   MEM_DIR="${TEST_HOME}/.claude/projects/test-project/memory"
   mkdir -p "$MEM_DIR" "${PROJECT_REPO}/.claude"
+  # Pin a generous wall-clock budget. The hook checks
+  # cheap_checks.wall_clock_budget_ms before EACH phase and skips the rest
+  # once it trips, so at the shipped default of 500ms a loaded machine can
+  # blow the budget before the later phases run — the orphan check among
+  # them — and those tests fail intermittently while passing in isolation.
+  # These tests assert what the checks detect, not how fast the host is.
   jq -n --arg path "$MEM_DIR" \
     '{
       curator: {
         memory_store_path: $path,
+        cheap_checks: { wall_clock_budget_ms: 600000 },
         date_check: { date_grace_period_days: 7 }
       }
     }' > "${PROJECT_REPO}/.claude/settings.json"
@@ -93,8 +100,8 @@ _write_index() {
   # Surfacer rendered the pointer.
   local ctx
   ctx=$(echo "$output" | jq -r '.hookSpecificOutput.additionalContext')
-  [[ "$ctx" == *"Curator: 1 open finding"* ]]
-  [[ "$ctx" == *"date-decayed"* ]]
+  [[ "$ctx" == *"Curator: 1 open finding"* ]] || return 1
+  [[ "$ctx" == *"date-decayed"* ]] || return 1
   [[ "$ctx" == *"/curator review"* ]]
 }
 
@@ -256,7 +263,7 @@ BODY
   [ "$status" -eq 0 ]
   local ctx
   ctx=$(echo "$output" | jq -r '.hookSpecificOutput.additionalContext')
-  [[ "$ctx" == *"2 date-decayed"* ]]
+  [[ "$ctx" == *"2 date-decayed"* ]] || return 1
   # The buggy output would have looked like "1 date-decayed, 1 date-decayed".
   [[ "$ctx" != *"1 date-decayed, 1 date-decayed"* ]]
 }

package/test/bats/emit-payload-default.bats

@@ -0,0 +1,52 @@
+#!/usr/bin/env bats
+#
+# Guards the payload-default expansion in every emit helper.
+#
+# Two tempting forms are both wrong, and each fails in a way the other does not:
+#
+#   "${3:-{\}}"  keeps the backslash on bash 3.2 (the bash macOS ships, and the
+#                one `#!/usr/bin/env bash` resolves to there), yielding {\} —
+#                invalid JSON, so the emit silently drops the event. Works on
+#                bash 5.x, which is why CI never caught it.
+#   "${3:-{}}"   appends a stray `}` to any payload that IS supplied, on EVERY
+#                bash version, corrupting the far more common path.
+#
+# The brace-free form below is correct on both. This test runs the real
+# expansion under the real interpreter rather than asserting on source text.
+
+setup() {
+	source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+	setup_test_env
+}
+
+_emit_libs() {
+	printf '%s\n' \
+		"scripts/lib/prompt-rules.sh" \
+		"plugins/curator/scripts/lib/curator-emit.sh" \
+		"plugins/historian/scripts/lib/historian-emit.sh" \
+		"plugins/librarian/scripts/lib/librarian-emit.sh" \
+		"plugins/librarian/scripts/lib/librarian-cli.sh" \
+		"plugins/tribunal/scripts/lib/tribunal-gate.sh"
+}
+
+@test "no emit helper inlines braces in a parameter-expansion default" {
+	# Code only — a comment explaining the hazard must not trip its own guard.
+	local hits
+	hits=$(cd "$REPO_ROOT" && grep -rn ':-{' --include="*.sh" scripts/ plugins/ \
+		| grep -vE '^[^:]+:[0-9]+:[[:space:]]*#' || true)
+	[ -z "$hits" ]
+}
+
+@test "the brace-free default yields {} when no payload is passed" {
+	local probe="${BATS_TEST_TMPDIR}/probe.sh"
+	printf '%s\n' 'f() { local p="${3:-}"; [ -z "$p" ] && p='"'"'{}'"'"'; printf "%s" "$p"; }' 'f a b' >"$probe"
+	run bash "$probe"
+	[ "$status" -eq 0 ] && [ "$output" = '{}' ]
+}
+
+@test "the brace-free default passes a supplied payload through unchanged" {
+	local probe="${BATS_TEST_TMPDIR}/probe.sh"
+	printf '%s\n' 'f() { local p="${3:-}"; [ -z "$p" ] && p='"'"'{}'"'"'; printf "%s" "$p"; }' 'f a b '"'"'{"a":{"b":1}}'"'"'' >"$probe"
+	run bash "$probe"
+	[ "$status" -eq 0 ] && [ "$output" = '{"a":{"b":1}}' ]
+}

package/test/bats/governor-ledger.bats

@@ -91,7 +91,7 @@ _make_completion() {
 @test "governor_ledger_path returns a .jsonl path under ONLOOKER_DIR" {
 	local p
 	p=$(governor_ledger_path "test-session")
-	[[ "$p" == *".jsonl" ]]
+	[[ "$p" == *".jsonl" ]] || return 1
 	[[ "$p" == *"test-session"* ]]
 }
 

package/test/bats/historian-prompt-submit.bats

@@ -157,7 +157,7 @@ _index_session() {
 
   local ctx
   ctx=$(echo "$output" | jq -r '.hookSpecificOutput.additionalContext')
-  [[ "$ctx" == *"Historian: a past chunk looks similar"* ]]
+  [[ "$ctx" == *"Historian: a past chunk looks similar"* ]] || return 1
   [[ "$ctx" == *"redash"* ]]
 
   grep '"event_type":"historian.retrieval.surfaced"' "$ONLOOKER_EVENTS_LOG" \

package/test/bats/inspector-post-write-hook.bats

@@ -100,7 +100,7 @@ _run_hook() {
 	echo '{"inspector":{"show_clean_runs":true,"checks":{".ts":[{"name":"clean","kind":"lint","argv":["true"]}]}}}' | _settings
 	run _run_hook "$(_input)"
 	[ "$status" -eq 0 ]
-	[[ "$output" == *"inspector: src/sample.ts"* ]]
+	[[ "$output" == *"inspector: src/sample.ts"* ]] || return 1
 	[[ "$output" == *"✓ clean"* ]]
 }
 
@@ -112,9 +112,9 @@ _run_hook() {
 EOF
 	run _run_hook "$(_input)"
 	[ "$status" -eq 0 ]
-	[[ "$output" == *"inspector: src/sample.ts"* ]]
-	[[ "$output" == *"✗ broken"* ]]
-	[[ "$output" == *"src/sample.ts:1:1 - Bad"* ]]
+	[[ "$output" == *"inspector: src/sample.ts"* ]] || return 1
+	[[ "$output" == *"✗ broken"* ]] || return 1
+	[[ "$output" == *"src/sample.ts:1:1 - Bad"* ]] || return 1
 	[ "$(_event_count inspector.check.failed)" = "1" ]
 	[ "$(jq -r 'select(.event_type=="inspector.check.failed").payload.exit_code' "$ONLOOKER_EVENTS_LOG")" = "2" ]
 }

package/test/bats/librarian-cli.bats

@@ -124,13 +124,13 @@ _seed_proposal() {
   run librarian_cli_list "$PROJECT_REPO"
   [ "$status" -eq 0 ]
   # Header counts only pending entries (2 of 3).
-  [[ "$output" == *"2 pending proposal"* ]]
+  [[ "$output" == *"2 pending proposal"* ]] || return 1
   # Both pending titles surface.
-  [[ "$output" == *"Prefer functional patterns"* ]]
-  [[ "$output" == *"Auth rewrite is compliance"* ]]
+  [[ "$output" == *"Prefer functional patterns"* ]] || return 1
+  [[ "$output" == *"Auth rewrite is compliance"* ]] || return 1
   # Pending rows include full IDs that can be used with show/accept/reject/defer.
-  [[ "$output" == *"01LISTPENDINGA000000000000"* ]]
-  [[ "$output" == *"01LISTPENDINGB000000000000"* ]]
+  [[ "$output" == *"01LISTPENDINGA000000000000"* ]] || return 1
+  [[ "$output" == *"01LISTPENDINGB000000000000"* ]] || return 1
   # Accepted entry does NOT appear in the list output.
   [[ "$output" != *"Already accepted"* ]]
 }
@@ -142,10 +142,10 @@ _seed_proposal() {
 
   run librarian_cli_show "01SHOWPROPOSAL0000000000000" "$PROJECT_REPO"
   [ "$status" -eq 0 ]
-  [[ "$output" == *"01SHOWPROPOSAL0000000000000"* ]]
-  [[ "$output" == *"type:                 feedback"* ]]
-  [[ "$output" == *"filename:             feedback_x.md"* ]]
-  [[ "$output" == *"classifier_confidence: 0.82"* ]]
+  [[ "$output" == *"01SHOWPROPOSAL0000000000000"* ]] || return 1
+  [[ "$output" == *"type:                 feedback"* ]] || return 1
+  [[ "$output" == *"filename:             feedback_x.md"* ]] || return 1
+  [[ "$output" == *"classifier_confidence: 0.82"* ]] || return 1
   [[ "$output" == *"Body of the memory."* ]]
 }
 
@@ -165,7 +165,7 @@ _seed_proposal() {
 
   run librarian_cli_accept "01ACCEPTPROPOSAL000000000000" "$PROJECT_REPO"
   [ "$status" -eq 0 ]
-  [[ "$output" == *"Accepted."* ]]
+  [[ "$output" == *"Accepted."* ]] || return 1
 
   local out_file="${MEM_DIR}/feedback_functional.md"
   [ -f "$out_file" ]
@@ -220,7 +220,7 @@ _seed_proposal() {
 
   run librarian_cli_accept "01ACCEPTUNSAFE00000000000000" "$PROJECT_REPO"
   [ "$status" -eq 1 ]
-  [[ "$output" == *"Failed to write memory file."* ]]
+  [[ "$output" == *"Failed to write memory file."* ]] || return 1
 
   # No memory file written anywhere under MEM_DIR or its parent.
   [ ! -f "${MEM_DIR}/../escape.md" ]
@@ -238,8 +238,8 @@ _seed_proposal() {
 
   run librarian_cli_reject "01REJECTPROPOSAL00000000000" "stale guidance" "$PROJECT_REPO"
   [ "$status" -eq 0 ]
-  [[ "$output" == *"Rejected"* ]]
-  [[ "$output" == *"stale guidance"* ]]
+  [[ "$output" == *"Rejected"* ]] || return 1
+  [[ "$output" == *"stale guidance"* ]] || return 1
 
   # Proposal status now rejected with the reason captured.
   local proposal_path="${LIBRARIAN_DIR}/proposals/01REJECTPROPOSAL00000000000.json"
@@ -268,7 +268,7 @@ _seed_proposal() {
 
   run librarian_cli_defer "01DEFERPROPOSAL000000000000" "$PROJECT_REPO"
   [ "$status" -eq 0 ]
-  [[ "$output" == *"Deferred"* ]]
+  [[ "$output" == *"Deferred"* ]] || return 1
 
   local proposal_path="${LIBRARIAN_DIR}/proposals/01DEFERPROPOSAL000000000000.json"
   jq -e '.status == "pending"' "$proposal_path" >/dev/null
@@ -285,8 +285,8 @@ _seed_proposal() {
 
   run librarian_cli_status "$PROJECT_REPO"
   [ "$status" -eq 0 ]
-  [[ "$output" == *"pending: 1"* ]]
-  [[ "$output" == *"accepted: 1"* ]]
+  [[ "$output" == *"pending: 1"* ]] || return 1
+  [[ "$output" == *"accepted: 1"* ]] || return 1
   [[ "$output" == *"rejected: 1"* ]]
 }