@onlooker-community/ecosystem 0.28.0 → 0.29.0

package/test/bats/turn-tracker.bats

@@ -0,0 +1,180 @@
+#!/usr/bin/env bats
+
+setup() {
+  # shellcheck source=../helpers/setup.bash
+  source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+  load_validate_path
+  export CLAUDE_PLUGIN_ROOT="${REPO_ROOT}"
+  # shellcheck source=../../scripts/lib/onlooker-schema.sh
+  source "${REPO_ROOT}/scripts/lib/onlooker-schema.sh"
+  # shellcheck source=../../scripts/lib/tool-history.sh
+  source "${REPO_ROOT}/scripts/lib/tool-history.sh"
+  # shellcheck source=../../scripts/lib/session-tracker.sh
+  source "${REPO_ROOT}/scripts/lib/session-tracker.sh"
+  # shellcheck source=../../scripts/lib/turn-tracker.sh
+  source "${REPO_ROOT}/scripts/lib/turn-tracker.sh"
+}
+
+# ── turn_tracker_summarize_prompt ──────────────────────────────────────────
+
+@test "turn_tracker_summarize_prompt collapses newlines and runs of spaces" {
+  local out
+  out=$(turn_tracker_summarize_prompt $'hello\n\nworld   foo')
+  [ "$out" = "hello world foo" ]
+}
+
+@test "turn_tracker_summarize_prompt trims leading and trailing spaces" {
+  local out
+  out=$(turn_tracker_summarize_prompt "  padded text  ")
+  [ "$out" = "padded text" ]
+}
+
+@test "turn_tracker_summarize_prompt leaves a short prompt unchanged" {
+  local out
+  out=$(turn_tracker_summarize_prompt "fix the bug")
+  [ "$out" = "fix the bug" ]
+}
+
+@test "turn_tracker_summarize_prompt does not truncate input of exactly 200 chars" {
+  local exact
+  exact=$(printf 'b%.0s' {1..200})
+  local out
+  out=$(turn_tracker_summarize_prompt "$exact")
+  [ "${#out}" -eq 200 ]
+  [[ "$out" != *…* ]]
+}
+
+@test "turn_tracker_summarize_prompt truncates to 200 chars plus an ellipsis when over 200" {
+  local long
+  long=$(printf 'a%.0s' {1..300})
+  local out
+  out=$(turn_tracker_summarize_prompt "$long")
+  # 200 retained characters + the single-character ellipsis = length 201.
+  [ "${#out}" -eq 201 ]
+  [[ "$out" == *… ]]
+  [ "${out%…}" = "$(printf 'a%.0s' {1..200})" ]
+}
+
+@test "turn_tracker_summarize_prompt returns empty and succeeds on empty input" {
+  run turn_tracker_summarize_prompt ""
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+# ── turn_tracker_on_user_prompt ────────────────────────────────────────────
+
+@test "turn_tracker_on_user_prompt keeps turn 1 and marks prompts seen on first prompt" {
+  local sid="turn-first-001"
+  turn_tracker_on_user_prompt "$sid"
+
+  local tracker="${ONLOOKER_SESSION_TRACKERS_DIR}/${sid}"
+  [ -f "$tracker" ]
+  jq -e '.turn_number == 1
+    and .user_prompts_seen == true
+    and .turn_tool_seq == 0' "$tracker" >/dev/null
+}
+
+@test "turn_tracker_on_user_prompt advances the turn on the second prompt" {
+  local sid="turn-second-001"
+  turn_tracker_on_user_prompt "$sid"
+  turn_tracker_on_user_prompt "$sid"
+
+  local tracker="${ONLOOKER_SESSION_TRACKERS_DIR}/${sid}"
+  jq -e '.turn_number == 2
+    and .user_prompts_seen == true
+    and .turn_tool_seq == 0' "$tracker" >/dev/null
+}
+
+@test "turn_tracker_on_user_prompt increments once per subsequent prompt" {
+  local sid="turn-many-001"
+  turn_tracker_on_user_prompt "$sid"  # turn 1, marks seen
+  turn_tracker_on_user_prompt "$sid"  # turn 2
+  turn_tracker_on_user_prompt "$sid"  # turn 3
+  turn_tracker_on_user_prompt "$sid"  # turn 4
+
+  local tracker="${ONLOOKER_SESSION_TRACKERS_DIR}/${sid}"
+  jq -e '.turn_number == 4' "$tracker" >/dev/null
+}
+
+@test "turn_tracker_on_user_prompt no-ops on empty session_id" {
+  run turn_tracker_on_user_prompt ""
+  [ "$status" -eq 0 ]
+  # No tracker file should have been created for an empty id.
+  [ ! -f "${ONLOOKER_SESSION_TRACKERS_DIR}/" ]
+  [ -z "$(ls -A "${ONLOOKER_SESSION_TRACKERS_DIR}")" ]
+}
+
+@test "turn_tracker_on_user_prompt no-ops on null session_id" {
+  run turn_tracker_on_user_prompt "null"
+  [ "$status" -eq 0 ]
+  [ ! -f "${ONLOOKER_SESSION_TRACKERS_DIR}/null" ]
+}
+
+# ── turn_tracker_build_prompt_payload ──────────────────────────────────────
+
+@test "turn_tracker_build_prompt_payload reads turn_number from the tracker and includes input_summary" {
+  local sid="payload-001"
+  turn_state_ensure_session "$sid"
+  local tracker="${ONLOOKER_SESSION_TRACKERS_DIR}/${sid}"
+  jq '.turn_number = 5' "$tracker" >"${tracker}.tmp"
+  mv "${tracker}.tmp" "$tracker"
+
+  local payload
+  payload=$(turn_tracker_build_prompt_payload "$sid" $'review   the\n\ndiff')
+  echo "$payload" | jq -e '.turn_number == 5
+    and .input_summary == "review the diff"' >/dev/null
+}
+
+@test "turn_tracker_build_prompt_payload defaults turn_number to 1 when tracker is missing" {
+  local sid="payload-missing"
+  rm -f "${ONLOOKER_SESSION_TRACKERS_DIR}/${sid}"
+
+  local payload
+  payload=$(turn_tracker_build_prompt_payload "$sid" "hello")
+  echo "$payload" | jq -e '.turn_number == 1 and .input_summary == "hello"' >/dev/null
+}
+
+@test "turn_tracker_build_prompt_payload omits input_summary for an empty prompt" {
+  local sid="payload-empty"
+  turn_state_ensure_session "$sid"
+
+  local payload
+  payload=$(turn_tracker_build_prompt_payload "$sid" "")
+  echo "$payload" | jq -e '.turn_number == 1 and (has("input_summary") | not)' >/dev/null
+}
+
+@test "turn_tracker_build_prompt_payload truncates a long prompt in input_summary" {
+  local sid="payload-long"
+  turn_state_ensure_session "$sid"
+  local long
+  long=$(printf 'x%.0s' {1..300})
+
+  local payload summary
+  payload=$(turn_tracker_build_prompt_payload "$sid" "$long")
+  summary=$(echo "$payload" | jq -r '.input_summary')
+  [ "${#summary}" -eq 201 ]
+  [[ "$summary" == *… ]]
+}
+
+@test "turn_tracker_build_prompt_payload returns 1 for null session_id" {
+  run turn_tracker_build_prompt_payload "null" "hi"
+  [ "$status" -eq 1 ]
+}
+
+@test "turn_tracker_build_prompt_payload returns 1 for empty session_id" {
+  run turn_tracker_build_prompt_payload "" "hi"
+  [ "$status" -eq 1 ]
+}
+
+# ── integration: orchestrator + payload reflect the same turn ──────────────
+
+@test "turn_tracker payload reflects turn advanced by turn_tracker_on_user_prompt" {
+  local sid="turn-integration-001"
+  # Two prompts -> turn 2; payload built afterward should report turn 2.
+  turn_tracker_on_user_prompt "$sid"
+  turn_tracker_on_user_prompt "$sid"
+
+  local payload
+  payload=$(turn_tracker_build_prompt_payload "$sid" "second prompt")
+  echo "$payload" | jq -e '.turn_number == 2 and .input_summary == "second prompt"' >/dev/null
+}

package/test/bats/validate-path.bats

@@ -107,3 +107,128 @@ setup() {
      and .schema_version == "1.0"' \
     >/dev/null
 }
+
+# ----------------------------------------------------------------------------
+# Hook health instrumentation: hook_register / hook_success / hook_failure
+# ----------------------------------------------------------------------------
+
+@test "hook_register seeds hook name and start time" {
+  hook_register "my-hook" "My Hook" "A description"
+  trap - EXIT  # disarm the trap hook_register installed so it can't fire later
+  [ "${_HOOK_NAME}" = "my-hook" ]
+  [ -n "${_HOOK_START_TIME}" ]
+}
+
+@test "hook_success writes a success record to the hook-health log" {
+  export _HOOK_SESSION_ID="health-success-session"
+  hook_register "success-hook"
+  hook_success
+  [ -f "$ONLOOKER_HOOK_HEALTH_LOG" ]
+  tail -n 1 "$ONLOOKER_HOOK_HEALTH_LOG" | jq -e \
+    '.hook == "success-hook"
+     and .status == "success"
+     and .error == null
+     and .session_id == "health-success-session"' \
+    >/dev/null
+}
+
+@test "hook_failure writes a failure record with the error message" {
+  hook_register "failure-hook"
+  hook_failure "boom: it broke"
+  [ -f "$ONLOOKER_HOOK_HEALTH_LOG" ]
+  tail -n 1 "$ONLOOKER_HOOK_HEALTH_LOG" | jq -e \
+    '.hook == "failure-hook"
+     and .status == "failure"
+     and .error == "boom: it broke"' \
+    >/dev/null
+}
+
+@test "hook_health_summary reflects seeded success and failure records" {
+  # Two records for the same hook: one success, one failure.
+  hook_register "summary-hook"
+  hook_success
+  hook_register "summary-hook"
+  hook_failure "an error"
+
+  local summary
+  summary=$(hook_health_summary 24)
+  echo "$summary" | jq -e \
+    'map(select(.hook == "summary-hook"))
+     | .[0]
+     | .total == 2
+     and .success == 1
+     and .failure == 1
+     and .last_error == "an error"' \
+    >/dev/null
+}
+
+# ----------------------------------------------------------------------------
+# Hook composition bus: hook_bus_list / hook_bus_cleanup
+# ----------------------------------------------------------------------------
+
+@test "hook_bus_list lists put findings without the .json extension" {
+  export _HOOK_SESSION_ID="bus-list-session"
+  export _HOOK_TOOL_NAME="Agent"
+  hook_bus_init '{"tool_input":{"agent_id":"list"}}'
+  hook_bus_put "alpha" '{"a":1}'
+  hook_bus_put "beta" '{"b":2}'
+  local listing
+  listing=$(hook_bus_list | sort | tr '\n' ' ')
+  [ "$listing" = "alpha beta " ]
+}
+
+@test "hook_bus_cleanup removes aged bus dirs but keeps fresh ones" {
+  local tmp_dir
+  tmp_dir="$(cd /tmp && pwd -P)"
+  local fresh="${tmp_dir}/.onlooker-hook-bus-cleanup-fresh-$$"
+  local aged="${tmp_dir}/.onlooker-hook-bus-cleanup-aged-$$"
+  mkdir -p "$fresh" "$aged"
+  # Backdate the aged dir well past the 5-minute (-mmin +5) cutoff.
+  touch -t "$(date -v-10M +%Y%m%d%H%M.%S 2>/dev/null || date -d '10 minutes ago' +%Y%m%d%H%M.%S)" "$aged"
+
+  hook_bus_cleanup
+
+  [ ! -d "$aged" ]
+  [ -d "$fresh" ]
+  rm -rf "$fresh"
+}
+
+# ----------------------------------------------------------------------------
+# Readability / writability validators
+# ----------------------------------------------------------------------------
+
+@test "validate_file_readable succeeds for existing readable file" {
+  local f="${BATS_TEST_TMPDIR}/readable.txt"
+  touch "$f"
+  validate_file_readable "$f"
+  [ "$?" -eq 0 ]
+}
+
+@test "validate_file_readable fails for missing file" {
+  ! validate_file_readable "${BATS_TEST_TMPDIR}/no-such-file.txt"
+}
+
+@test "validate_file_writable succeeds when parent directory is writable" {
+  validate_file_writable "${BATS_TEST_TMPDIR}/new-file.txt"
+  [ "$?" -eq 0 ]
+}
+
+@test "validate_file_writable fails when parent directory does not exist" {
+  ! validate_file_writable "${BATS_TEST_TMPDIR}/missing-dir/new-file.txt"
+}
+
+# ----------------------------------------------------------------------------
+# Turn state tracking: turn_state_next_turn
+# ----------------------------------------------------------------------------
+
+@test "turn_state_next_turn increments turn_number from 1 to 2" {
+  local session_id="next-turn-session"
+  local tracker="${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+  turn_state_ensure_session "$session_id"
+  [ -f "$tracker" ]
+  # Fresh session starts at turn_number 1.
+  jq -e '.turn_number == 1' "$tracker" >/dev/null
+
+  turn_state_next_turn "$session_id"
+  jq -e '.turn_number == 2 and .turn_tool_seq == 0' "$tracker" >/dev/null
+}

package/test/bats/worktree-tracker.bats

@@ -127,3 +127,170 @@ setup() {
      and (.payload.command | test("worktree:create"))' \
     >/dev/null
 }
+
+@test "worktree_tracker_repo_root prints the git toplevel for a cwd inside the repo" {
+  local expected
+  expected=$(git -C "$GIT_REPO" rev-parse --show-toplevel)
+
+  run worktree_tracker_repo_root "$GIT_REPO"
+  [ "$status" -eq 0 ]
+  [ "$output" = "$expected" ]
+}
+
+@test "worktree_tracker_repo_root returns empty for a non-repo directory" {
+  local non_repo="${BATS_TEST_TMPDIR}/not-a-repo"
+  mkdir -p "$non_repo"
+
+  run worktree_tracker_repo_root "$non_repo"
+  [ "$status" -ne 0 ]
+  [ -z "$output" ]
+}
+
+@test "worktree_tracker_repo_root returns non-zero for empty cwd" {
+  run worktree_tracker_repo_root ""
+  [ "$status" -ne 0 ]
+  [ -z "$output" ]
+}
+
+@test "worktree_tracker_git_create creates a worktree at the expected path" {
+  local name="feature-create"
+  local expected="${GIT_REPO}/.claude/worktrees/${name}"
+
+  local worktree_path
+  worktree_path=$(worktree_tracker_git_create "$GIT_REPO" "$name" 2>/dev/null)
+
+  [ "$worktree_path" = "$(cd "$expected" && pwd -P)" ]
+  [ -d "$worktree_path" ]
+  git -C "$GIT_REPO" worktree list --porcelain | grep -Fq "worktree $(cd "$expected" && pwd -P)"
+  git -C "$GIT_REPO" show-ref --verify --quiet "refs/heads/worktree-${name}"
+
+  worktree_tracker_git_remove "$GIT_REPO" "$worktree_path" 2>/dev/null
+}
+
+@test "worktree_tracker_git_create is idempotent for an existing worktree dir" {
+  local name="feature-idempotent"
+
+  local first second
+  first=$(worktree_tracker_git_create "$GIT_REPO" "$name" 2>/dev/null)
+  second=$(worktree_tracker_git_create "$GIT_REPO" "$name" 2>/dev/null)
+
+  [ "$first" = "$second" ]
+  [ -d "$second" ]
+
+  worktree_tracker_git_remove "$GIT_REPO" "$first" 2>/dev/null
+}
+
+@test "worktree_tracker_git_create returns non-zero with missing args" {
+  run worktree_tracker_git_create "$GIT_REPO" ""
+  [ "$status" -ne 0 ]
+}
+
+@test "worktree_tracker_git_remove removes a registered worktree" {
+  local name="feature-remove"
+  local worktree_path
+  worktree_path=$(worktree_tracker_git_create "$GIT_REPO" "$name" 2>/dev/null)
+  [ -d "$worktree_path" ]
+
+  worktree_tracker_git_remove "$GIT_REPO" "$worktree_path" 2>/dev/null
+
+  [ ! -d "$worktree_path" ]
+  ! git -C "$GIT_REPO" worktree list --porcelain | grep -Fq "worktree ${worktree_path}"
+}
+
+@test "worktree_tracker_record_created writes timing into the session tracker" {
+  local session_id="worktree-record-001"
+  local name="feature-record"
+  local worktree_path="${GIT_REPO}/.claude/worktrees/${name}"
+  local branch="worktree-${name}"
+  rm -f "${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+
+  worktree_tracker_record_created "$session_id" "$name" "$worktree_path" "$branch"
+
+  local tracker_file="${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+  [ -f "$tracker_file" ]
+  jq -e \
+    --arg name "$name" \
+    --arg path "$worktree_path" \
+    --arg branch "$branch" \
+    '.worktrees[$name].path == $path
+     and .worktrees[$name].branch == $branch
+     and (.worktrees[$name].start_time_ms | type == "number")' \
+    "$tracker_file" >/dev/null
+}
+
+@test "worktree_tracker_record_created is a no-op with missing args" {
+  local session_id="worktree-record-noop"
+  rm -f "${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+
+  run worktree_tracker_record_created "$session_id" "" "/some/path" "branch"
+  [ "$status" -eq 0 ]
+  [ ! -f "${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}" ]
+}
+
+@test "worktree_tracker_duration_ms returns elapsed ms from a seeded start" {
+  local session_id="worktree-duration-001"
+  local name="feature-duration"
+  local worktree_path="${GIT_REPO}/.claude/worktrees/${name}"
+  rm -f "${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+
+  worktree_tracker_record_created "$session_id" "$name" "$worktree_path" "worktree-${name}"
+
+  # Rewind the recorded start_time_ms by ~2s so elapsed is a stable positive value.
+  local tracker_file="${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+  local now_ms past temp
+  now_ms=$(session_tracker_now_ms)
+  past=$(( now_ms - 2000 ))
+  temp=$(mktemp)
+  jq --arg name "$name" --argjson ms "$past" \
+    '.worktrees[$name].start_time_ms = $ms' "$tracker_file" >"$temp"
+  mv "$temp" "$tracker_file"
+
+  local duration
+  duration=$(worktree_tracker_duration_ms "$session_id" "$worktree_path")
+  [[ "$duration" =~ ^[0-9]+$ ]]
+  [ "$duration" -ge 1900 ]
+}
+
+@test "worktree_tracker_duration_ms returns empty for an unknown worktree path" {
+  local session_id="worktree-duration-unknown"
+  rm -f "${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+  turn_state_ensure_session "$session_id"
+
+  run worktree_tracker_duration_ms "$session_id" "/never/recorded"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "worktree_tracker_clear_by_path removes the recorded entry" {
+  local session_id="worktree-clear-001"
+  local name="feature-clear"
+  local worktree_path="${GIT_REPO}/.claude/worktrees/${name}"
+  rm -f "${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+
+  worktree_tracker_record_created "$session_id" "$name" "$worktree_path" "worktree-${name}"
+  local tracker_file="${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+  jq -e --arg name "$name" '.worktrees | has($name)' "$tracker_file" >/dev/null
+
+  worktree_tracker_clear_by_path "$session_id" "$worktree_path"
+
+  jq -e --arg name "$name" '(.worktrees | has($name)) | not' "$tracker_file" >/dev/null
+  run worktree_tracker_duration_ms "$session_id" "$worktree_path"
+  [ -z "$output" ]
+}
+
+@test "worktree_tracker_append lands a JSON line in the session history" {
+  local session_id="worktree-append-001"
+  local history_file="${ONLOOKER_SESSION_HISTORY_DIR}/${session_id}.jsonl"
+  rm -f "$history_file" "${history_file}.lock"
+
+  local event
+  event=$(jq -c -n '{event_type: "tool.shell.exec", payload: {command: "git worktree:create"}}')
+
+  worktree_tracker_append "$session_id" "$event"
+
+  [ -f "$history_file" ]
+  tail -n 1 "$history_file" | jq -e \
+    '.event_type == "tool.shell.exec"
+     and (.payload.command | test("worktree:create"))' \
+    >/dev/null
+}