@onlooker-community/ecosystem 0.14.0 → 0.15.1

package/test/bats/cartographer-config.bats

@@ -0,0 +1,107 @@
+#!/usr/bin/env bats
+
+setup() {
+  source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+  setup_test_env
+
+  PLUGIN_ROOT="${REPO_ROOT}/plugins/cartographer"
+  export CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT"
+  # shellcheck disable=SC1091
+  source "${PLUGIN_ROOT}/scripts/lib/cartographer-config.sh"
+}
+
+@test "config defaults: disabled by default" {
+  cartographer_config_load ""
+  run cartographer_config_enabled
+  [ "$status" -ne 0 ]
+}
+
+@test "user-level settings.json can enable cartographer" {
+  mkdir -p "${HOME}/.claude"
+  printf '%s\n' '{"cartographer":{"enabled":true}}' > "${HOME}/.claude/settings.json"
+  cartographer_config_load ""
+  run cartographer_config_enabled
+  [ "$status" -eq 0 ]
+}
+
+@test "repo-level settings.json overrides user-level enabled" {
+  mkdir -p "${HOME}/.claude"
+  printf '%s\n' '{"cartographer":{"enabled":true}}' > "${HOME}/.claude/settings.json"
+  local repo="${BATS_TEST_TMPDIR}/repo"
+  mkdir -p "${repo}/.claude"
+  printf '%s\n' '{"cartographer":{"enabled":false}}' > "${repo}/.claude/settings.json"
+  cartographer_config_load "$repo"
+  run cartographer_config_enabled
+  [ "$status" -ne 0 ]
+}
+
+@test "deep merge: user-level partial override preserves plugin defaults" {
+  mkdir -p "${HOME}/.claude"
+  printf '%s\n' '{"cartographer":{"audit_interval_hours":12}}' > "${HOME}/.claude/settings.json"
+  cartographer_config_load ""
+  local interval model
+  interval=$(cartographer_config_audit_interval_hours)
+  model=$(cartographer_config_model_extraction)
+  [ "$interval" = "12" ]
+  [ "$model" = "claude-haiku-4-5-20251001" ]
+}
+
+@test "deep merge: repo overrides user but preserves user keys not in repo" {
+  mkdir -p "${HOME}/.claude"
+  printf '%s\n' '{"cartographer":{"audit_interval_hours":6,"phase_timeout_seconds":30}}' > "${HOME}/.claude/settings.json"
+  local repo="${BATS_TEST_TMPDIR}/repo2"
+  mkdir -p "${repo}/.claude"
+  printf '%s\n' '{"cartographer":{"audit_interval_hours":48}}' > "${repo}/.claude/settings.json"
+  cartographer_config_load "$repo"
+  local interval timeout_s
+  interval=$(cartographer_config_audit_interval_hours)
+  timeout_s=$(cartographer_config_phase_timeout)
+  [ "$interval" = "48" ]
+  [ "$timeout_s" = "30" ]
+}
+
+@test "model_extraction falls back to default when not configured" {
+  cartographer_config_load ""
+  local v
+  v=$(cartographer_config_model_extraction)
+  [ "$v" = "claude-haiku-4-5-20251001" ]
+}
+
+@test "model_synthesis falls back to default when not configured" {
+  cartographer_config_load ""
+  local v
+  v=$(cartographer_config_model_synthesis)
+  [ "$v" = "claude-haiku-4-5-20251001" ]
+}
+
+@test "model_extraction respects user-level override" {
+  mkdir -p "${HOME}/.claude"
+  printf '%s\n' '{"cartographer":{"extraction":{"model":"claude-sonnet-4-6"}}}' > "${HOME}/.claude/settings.json"
+  cartographer_config_load ""
+  local v
+  v=$(cartographer_config_model_extraction)
+  [ "$v" = "claude-sonnet-4-6" ]
+}
+
+@test "phase_timeout_seconds defaults to 60" {
+  cartographer_config_load ""
+  local v
+  v=$(cartographer_config_phase_timeout)
+  [ "$v" = "60" ]
+}
+
+@test "audit_interval_hours defaults to 24" {
+  cartographer_config_load ""
+  local v
+  v=$(cartographer_config_audit_interval_hours)
+  [ "$v" = "24" ]
+}
+
+@test "exclude_paths defaults are non-empty JSON array" {
+  cartographer_config_load ""
+  local v
+  v=$(cartographer_config_exclude_paths)
+  # Must be a non-empty JSON array containing node_modules
+  echo "$v" | jq -e 'type == "array" and length > 0' >/dev/null
+  echo "$v" | jq -e 'any(. == "node_modules")' >/dev/null
+}

package/test/bats/cartographer-lock.bats

@@ -0,0 +1,77 @@
+#!/usr/bin/env bats
+
+setup() {
+  source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+  setup_test_env
+  # shellcheck disable=SC1091
+  source "${REPO_ROOT}/plugins/cartographer/scripts/lib/cartographer-lock.sh"
+
+  LOCK_FILE="${BATS_TEST_TMPDIR}/test.lock"
+}
+
+teardown() {
+  cartographer_lock_release "$LOCK_FILE" 2>/dev/null || true
+}
+
+@test "acquire succeeds when lock is free" {
+  run cartographer_lock_acquire "$LOCK_FILE"
+  [ "$status" -eq 0 ]
+}
+
+@test "acquire fails immediately when lock is already held" {
+  cartographer_lock_acquire "$LOCK_FILE"
+  run cartographer_lock_acquire "$LOCK_FILE"
+  [ "$status" -ne 0 ]
+}
+
+@test "release allows re-acquire" {
+  cartographer_lock_acquire "$LOCK_FILE"
+  cartographer_lock_release "$LOCK_FILE"
+  run cartographer_lock_acquire "$LOCK_FILE"
+  [ "$status" -eq 0 ]
+}
+
+@test "is_held returns true while lock is held" {
+  cartographer_lock_acquire "$LOCK_FILE"
+  run cartographer_lock_is_held "$LOCK_FILE"
+  [ "$status" -eq 0 ]
+}
+
+@test "is_held returns false after release" {
+  cartographer_lock_acquire "$LOCK_FILE"
+  cartographer_lock_release "$LOCK_FILE"
+  run cartographer_lock_is_held "$LOCK_FILE"
+  [ "$status" -ne 0 ]
+}
+
+@test "release is idempotent (safe to call when not held)" {
+  run cartographer_lock_release "$LOCK_FILE"
+  [ "$status" -eq 0 ]
+}
+
+@test "two independent lock paths do not interfere" {
+  local lock_a="${BATS_TEST_TMPDIR}/a.lock"
+  local lock_b="${BATS_TEST_TMPDIR}/b.lock"
+  cartographer_lock_acquire "$lock_a"
+  run cartographer_lock_acquire "$lock_b"
+  [ "$status" -eq 0 ]
+  cartographer_lock_release "$lock_a"
+  cartographer_lock_release "$lock_b"
+}
+
+@test "background child holds lock after parent releases its reference" {
+  # Acquire in a background subprocess, then verify is_held from this process.
+  bash -c "
+    source '${REPO_ROOT}/plugins/cartographer/scripts/lib/cartographer-lock.sh'
+    cartographer_lock_acquire '${LOCK_FILE}'
+    sleep 2
+    cartographer_lock_release '${LOCK_FILE}'
+  " &
+  sleep 0.1
+  run cartographer_lock_is_held "$LOCK_FILE"
+  [ "$status" -eq 0 ]
+  # Second acquire from this process must fail while child holds it
+  run cartographer_lock_acquire "$LOCK_FILE"
+  [ "$status" -ne 0 ]
+  wait
+}

package/test/bats/cartographer-ulid.bats

@@ -0,0 +1,56 @@
+#!/usr/bin/env bats
+
+setup() {
+  source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+  setup_test_env
+  # shellcheck disable=SC1091
+  source "${REPO_ROOT}/plugins/cartographer/scripts/lib/cartographer-ulid.sh"
+}
+
+@test "cartographer_ulid returns a 26-char Crockford Base32 string" {
+  local id
+  id=$(cartographer_ulid)
+  [ "${#id}" -eq 26 ]
+  [[ "$id" =~ ^[0123456789ABCDEFGHJKMNPQRSTVWXYZ]{26}$ ]]
+}
+
+@test "two ULIDs minted apart are lexicographically ordered" {
+  local a b
+  a=$(cartographer_ulid)
+  sleep 0.01
+  b=$(cartographer_ulid)
+  [[ "$a" < "$b" ]] || [ "$a" = "$b" ]
+}
+
+@test "many ULIDs are unique" {
+  local seen="${BATS_TEST_TMPDIR}/ulids.txt"
+  : > "$seen"
+  local i
+  for ((i = 0; i < 50; i++)); do
+    printf '%s\n' "$(cartographer_ulid)" >> "$seen"
+  done
+  local total unique
+  total=$(wc -l < "$seen" | tr -d ' ')
+  unique=$(sort -u "$seen" | wc -l | tr -d ' ')
+  [ "$total" = "$unique" ]
+}
+
+@test "random component is 16 chars (full 80-bit coverage)" {
+  local id
+  id=$(cartographer_ulid)
+  # Characters 10-25 (0-indexed) are the random component
+  local rand_part="${id:10:16}"
+  [ "${#rand_part}" -eq 16 ]
+}
+
+@test "timestamp component sorts ULIDs correctly across 10+ calls" {
+  local prev=""
+  local id
+  for _ in 1 2 3 4 5 6 7 8 9 10; do
+    id=$(cartographer_ulid)
+    if [[ -n "$prev" ]]; then
+      [[ "$prev" < "$id" ]] || [ "$prev" = "$id" ]
+    fi
+    prev="$id"
+  done
+}