@onlooker-community/ecosystem 0.10.0 → 0.15.0

package/test/bats/echo-config.bats

@@ -0,0 +1,90 @@
+#!/usr/bin/env bats
+
+setup() {
+	source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+	setup_test_env
+
+	PLUGIN_ROOT="${REPO_ROOT}/plugins/echo"
+	export CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT"
+	# shellcheck disable=SC1091
+	source "${PLUGIN_ROOT}/scripts/lib/echo-config.sh"
+}
+
+@test "echo is disabled by default" {
+	CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_load ""
+	run echo_config_enabled
+	[ "$status" -ne 0 ]
+}
+
+@test "settings.json echo.enabled=true enables echo" {
+	local repo="${BATS_TEST_TMPDIR}/repo"
+	mkdir -p "${repo}/.claude"
+	printf '%s\n' '{"echo":{"enabled":true}}' > "${repo}/.claude/settings.json"
+	CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_load "$repo"
+	run echo_config_enabled
+	[ "$status" -eq 0 ]
+}
+
+@test "settings.json echo.enabled=false overrides plugin default" {
+	local repo="${BATS_TEST_TMPDIR}/repo"
+	mkdir -p "${repo}/.claude"
+	printf '%s\n' '{"echo":{"enabled":false}}' > "${repo}/.claude/settings.json"
+	CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_load "$repo"
+	run echo_config_enabled
+	[ "$status" -ne 0 ]
+}
+
+@test "default model is claude-haiku-4-5-20251001" {
+	CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_load ""
+	local m
+	m=$(CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_model)
+	[ "$m" = "claude-haiku-4-5-20251001" ]
+}
+
+@test "default timeout is 60" {
+	CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_load ""
+	local t
+	t=$(CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_timeout)
+	[ "$t" = "60" ]
+}
+
+@test "default drift_threshold is 0.05" {
+	CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_load ""
+	local d
+	d=$(CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_drift_threshold)
+	[ "$d" = "0.05" ]
+}
+
+@test "default watch_paths includes plugins/*/agents/*.md" {
+	CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_load ""
+	local paths
+	paths=$(CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_watch_paths)
+	printf '%s\n' "$paths" | grep -q 'plugins/\*/agents/\*.md'
+}
+
+@test "exclude_paths always includes plugins/echo/** regardless of config" {
+	CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_load ""
+	local excl
+	excl=$(CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_exclude_paths)
+	printf '%s\n' "$excl" | grep -q 'plugins/echo/\*\*'
+}
+
+@test "settings.json model override wins over plugin default" {
+	local repo="${BATS_TEST_TMPDIR}/repo"
+	mkdir -p "${repo}/.claude"
+	printf '%s\n' '{"echo":{"evaluation":{"model":"claude-opus-4-7"}}}' > "${repo}/.claude/settings.json"
+	CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_load "$repo"
+	local m
+	m=$(CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_model)
+	[ "$m" = "claude-opus-4-7" ]
+}
+
+@test "settings.json drift_threshold override wins" {
+	local repo="${BATS_TEST_TMPDIR}/repo"
+	mkdir -p "${repo}/.claude"
+	printf '%s\n' '{"echo":{"drift_threshold":0.1}}' > "${repo}/.claude/settings.json"
+	CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_load "$repo"
+	local d
+	d=$(CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" echo_config_drift_threshold)
+	[ "$d" = "0.1" ]
+}

package/test/bats/echo-events.bats

@@ -0,0 +1,121 @@
+#!/usr/bin/env bats
+
+# Validates every emitted echo.* event against @onlooker-community/schema.
+
+setup() {
+	source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+	setup_test_env
+
+	PLUGIN_ROOT="${REPO_ROOT}/plugins/echo"
+	export CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT"
+	export ONLOOKER_EVENTS_LOG="${ONLOOKER_DIR}/logs/onlooker-events.jsonl"
+	mkdir -p "$(dirname "$ONLOOKER_EVENTS_LOG")"
+
+	export _ONLOOKER_EVENT_JS="${REPO_ROOT}/scripts/lib/onlooker-event.mjs"
+	export CLAUDE_SESSION_ID="bats-session-$$"
+
+	# shellcheck disable=SC1091
+	source "${PLUGIN_ROOT}/scripts/lib/echo-events.sh"
+}
+
+_validate_latest_event() {
+	local last
+	last=$(tail -n 1 "$ONLOOKER_EVENTS_LOG")
+	[ -n "$last" ] || return 1
+	printf '%s' "$last" | ONLOOKER_DIR="$ONLOOKER_DIR" \
+		node "${REPO_ROOT}/scripts/lib/onlooker-event.mjs" validate >/dev/null
+}
+
+SUITE_ID="01J000000000000000000000SS"
+TEST_ID="01J000000000000000000000TT"
+
+@test "echo.suite.started validates" {
+	local p
+	p=$(jq -n --arg s "$SUITE_ID" '{
+		suite_id: $s,
+		test_count: 2,
+		trigger: "file_change",
+		changed_file: "plugins/tribunal/agents/tribunal-judge-standard.md"
+	}')
+	echo_emit_event "echo.suite.started" "$p"
+	run _validate_latest_event
+	[ "$status" -eq 0 ]
+}
+
+@test "echo.suite.complete validates without drift fields" {
+	local p
+	p=$(jq -n --arg s "$SUITE_ID" '{
+		suite_id: $s,
+		test_count: 1,
+		improved: 0,
+		degraded: 0,
+		neutral: 1,
+		merge_recommended: true,
+		duration_ms: 3200
+	}')
+	echo_emit_event "echo.suite.complete" "$p"
+	run _validate_latest_event
+	[ "$status" -eq 0 ]
+}
+
+@test "echo.suite.complete validates with drift fields" {
+	local p
+	p=$(jq -n --arg s "$SUITE_ID" '{
+		suite_id: $s,
+		test_count: 1,
+		improved: 1,
+		degraded: 0,
+		neutral: 0,
+		merge_recommended: true,
+		duration_ms: 3200,
+		baseline_score: 0.72,
+		score_after: 0.85,
+		drift: 0.13,
+		drift_threshold: 0.05
+	}')
+	echo_emit_event "echo.suite.complete" "$p"
+	run _validate_latest_event
+	[ "$status" -eq 0 ]
+}
+
+@test "echo.improvement.detected validates" {
+	local p
+	p=$(jq -n --arg s "$SUITE_ID" --arg t "$TEST_ID" '{
+		suite_id: $s,
+		test_id: $t,
+		test_name: "tribunal-judge-standard.md",
+		score_before: 0.70,
+		score_after: 0.85,
+		delta: 0.15,
+		confidence: 0.9
+	}')
+	echo_emit_event "echo.improvement.detected" "$p"
+	run _validate_latest_event
+	[ "$status" -eq 0 ]
+}
+
+@test "echo.regression.detected validates" {
+	local p
+	p=$(jq -n --arg s "$SUITE_ID" --arg t "$TEST_ID" '{
+		suite_id: $s,
+		test_id: $t,
+		test_name: "tribunal-judge-standard.md",
+		score_before: 0.85,
+		score_after: 0.62,
+		delta: -0.23,
+		confidence: 0.88
+	}')
+	echo_emit_event "echo.regression.detected" "$p"
+	run _validate_latest_event
+	[ "$status" -eq 0 ]
+}
+
+@test "emission fails on unknown event type" {
+	run echo_emit_event "echo.no.such.event" '{"suite_id":"x"}'
+	[ "$status" -ne 0 ]
+}
+
+@test "echo_emit_event returns 1 when payload is empty" {
+	run echo_emit_event "echo.suite.started" ""
+	[ "$status" -ne 0 ]
+}

package/test/bats/echo-project-key.bats

@@ -0,0 +1,115 @@
+#!/usr/bin/env bats
+
+setup() {
+	source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+	setup_test_env
+
+	PLUGIN_ROOT="${REPO_ROOT}/plugins/echo"
+	# shellcheck disable=SC1091
+	source "${PLUGIN_ROOT}/scripts/lib/echo-project-key.sh"
+}
+
+@test "non-git directory returns empty key" {
+	local d="${BATS_TEST_TMPDIR}/non-git"
+	mkdir -p "$d"
+	run echo_project_key "$d"
+	[ "$status" -eq 0 ]
+	[ -z "$output" ]
+}
+
+@test "git repo without remote falls back to repo-root hash" {
+	local d="${BATS_TEST_TMPDIR}/local-only-repo"
+	mkdir -p "$d"
+	git -C "$d" init -q
+	git -C "$d" config user.email t@example.com
+	git -C "$d" config user.name "Test"
+
+	local k1 k2
+	k1=$(echo_project_key "$d")
+	k2=$(echo_project_key "$d")
+	[ -n "$k1" ]
+	[ "${#k1}" -eq 12 ]
+	[ "$k1" = "$k2" ]
+}
+
+@test "git repo with remote uses remote hash" {
+	local a="${BATS_TEST_TMPDIR}/clone-a"
+	local b="${BATS_TEST_TMPDIR}/clone-b"
+	mkdir -p "$a" "$b"
+	for d in "$a" "$b"; do
+		git -C "$d" init -q
+		git -C "$d" config user.email t@example.com
+		git -C "$d" config user.name "Test"
+		git -C "$d" remote add origin git@github.com:org/proj.git
+	done
+
+	local ka kb
+	ka=$(echo_project_key "$a")
+	kb=$(echo_project_key "$b")
+	[ -n "$ka" ]
+	[ "$ka" = "$kb" ]
+}
+
+@test "different remotes yield different keys" {
+	local a="${BATS_TEST_TMPDIR}/proj-a"
+	local b="${BATS_TEST_TMPDIR}/proj-b"
+	mkdir -p "$a" "$b"
+	for d in "$a" "$b"; do
+		git -C "$d" init -q
+		git -C "$d" config user.email t@example.com
+		git -C "$d" config user.name "Test"
+	done
+	git -C "$a" remote add origin git@github.com:org/proj-a.git
+	git -C "$b" remote add origin git@github.com:org/proj-b.git
+
+	local ka kb
+	ka=$(echo_project_key "$a")
+	kb=$(echo_project_key "$b")
+	[ -n "$ka" ]
+	[ -n "$kb" ]
+	[ "$ka" != "$kb" ]
+}
+
+@test "echo_test_id_for_path returns 16 hex chars" {
+	local tid
+	tid=$(echo_test_id_for_path "plugins/tribunal/agents/tribunal-judge-standard.md")
+	[ -n "$tid" ]
+	[ "${#tid}" -eq 16 ]
+	[[ "$tid" =~ ^[0-9a-f]{16}$ ]]
+}
+
+@test "echo_test_id_for_path is stable across calls" {
+	local a b
+	a=$(echo_test_id_for_path "plugins/tribunal/agents/tribunal-judge-standard.md")
+	b=$(echo_test_id_for_path "plugins/tribunal/agents/tribunal-judge-standard.md")
+	[ "$a" = "$b" ]
+}
+
+@test "echo_test_id_for_path differs for different paths" {
+	local a b
+	a=$(echo_test_id_for_path "plugins/tribunal/agents/tribunal-judge-standard.md")
+	b=$(echo_test_id_for_path "plugins/tribunal/agents/tribunal-judge-adversarial.md")
+	[ "$a" != "$b" ]
+}
+
+@test "echo_project_repo_root returns empty for non-git dir" {
+	local d="${BATS_TEST_TMPDIR}/not-a-repo"
+	mkdir -p "$d"
+	local r
+	r=$(echo_project_repo_root "$d")
+	[ -z "$r" ]
+}
+
+@test "echo_project_repo_root returns repo root for subdir" {
+	local d="${BATS_TEST_TMPDIR}/myrepo"
+	mkdir -p "${d}/sub/dir"
+	git -C "$d" init -q
+	git -C "$d" config user.email t@example.com
+	git -C "$d" config user.name "Test"
+
+	local r expected
+	r=$(echo_project_repo_root "${d}/sub/dir")
+	# Resolve symlinks — on macOS BATS_TEST_TMPDIR may differ from git's toplevel.
+	expected=$(cd "$d" && pwd -P)
+	[ "$r" = "$expected" ]
+}

package/test/bats/echo-stop-hook.bats

@@ -0,0 +1,101 @@
+#!/usr/bin/env bats
+
+# Exercises the Echo Stop hook's gating behavior. Does not invoke claude -p
+# (the hook bails before reaching the eval loop when preconditions fail).
+# Tests verify: disabled-by-default, no-git, no-watched-changes, recursion
+# guard, untracked file detection, and stdout silence.
+
+setup() {
+	source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+	setup_test_env
+
+	PLUGIN_ROOT="${REPO_ROOT}/plugins/echo"
+	export CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT"
+	HOOK="${PLUGIN_ROOT}/scripts/hooks/echo-stop-gate.sh"
+
+	REPO="${BATS_TEST_TMPDIR}/repo"
+	mkdir -p "$REPO"
+	git -C "$REPO" init -q
+	git -C "$REPO" config user.email test@example.com
+	git -C "$REPO" config user.name test
+	(cd "$REPO" && printf 'initial\n' > README.md && git add README.md && git commit -q -m init)
+}
+
+_make_input() {
+	local cwd="${1:-$REPO}" sid="${2:-test-session}"
+	jq -n --arg cwd "$cwd" --arg sid "$sid" '{cwd: $cwd, session_id: $sid}'
+}
+
+@test "hook exits 0 silently when echo.enabled is false (default)" {
+	local input
+	input=$(_make_input)
+	run bash -c "printf '%s' '$input' | ONLOOKER_DIR='$ONLOOKER_DIR' '$HOOK'"
+	[ "$status" -eq 0 ]
+	[ -z "$output" ]
+}
+
+@test "hook exits 0 when cwd is not a git repo" {
+	local non_repo="${BATS_TEST_TMPDIR}/not-a-repo"
+	mkdir -p "$non_repo"
+	local input
+	input=$(_make_input "$non_repo")
+	run bash -c "printf '%s' '$input' | ONLOOKER_DIR='$ONLOOKER_DIR' '$HOOK'"
+	[ "$status" -eq 0 ]
+}
+
+@test "hook exits 0 when enabled but no watched files changed" {
+	mkdir -p "${REPO}/.claude"
+	printf '%s\n' '{"echo":{"enabled":true}}' > "${REPO}/.claude/settings.json"
+	local input
+	input=$(_make_input)
+	run bash -c "printf '%s' '$input' | ONLOOKER_DIR='$ONLOOKER_DIR' '$HOOK'"
+	[ "$status" -eq 0 ]
+	[ -z "$output" ]
+}
+
+@test "recursion guard: ECHO_NESTED=1 causes immediate exit 0" {
+	mkdir -p "${REPO}/.claude"
+	printf '%s\n' '{"echo":{"enabled":true}}' > "${REPO}/.claude/settings.json"
+	local input
+	input=$(_make_input)
+	# Export ECHO_NESTED into the subshell that runs the hook.
+	run bash -c "printf '%s' '$input' | ECHO_NESTED=1 ONLOOKER_DIR='$ONLOOKER_DIR' '$HOOK'"
+	[ "$status" -eq 0 ]
+	[ -z "$output" ]
+}
+
+@test "hook never prints to stdout (Stop contract)" {
+	local input
+	input=$(_make_input)
+	run bash -c "printf '%s' '$input' | ONLOOKER_DIR='$ONLOOKER_DIR' '$HOOK'"
+	[ "$status" -eq 0 ]
+	[ -z "$output" ]
+}
+
+@test "untracked watched file is detected when enabled and claude missing" {
+	mkdir -p "${REPO}/.claude" "${REPO}/plugins/myplugin/agents"
+	printf '%s\n' '{"echo":{"enabled":true,"watch_paths":["plugins/*/agents/*.md"]}}' \
+		> "${REPO}/.claude/settings.json"
+	printf '%s\n' '# New agent' > "${REPO}/plugins/myplugin/agents/new-agent.md"
+	local input
+	input=$(_make_input)
+	# claude is not present in the test env PATH → hook reaches _done after the
+	# `command -v claude` guard. Exit 0 with no output confirms the file was
+	# at least detected (it passed the _done guards before the claude check).
+	run bash -c "PATH=/usr/bin:/bin printf '%s' '$input' | ONLOOKER_DIR='$ONLOOKER_DIR' '$HOOK'"
+	[ "$status" -eq 0 ]
+}
+
+@test "files under plugins/echo are excluded even if they match watch_paths" {
+	mkdir -p "${REPO}/.claude" "${REPO}/plugins/echo/agents"
+	printf '%s\n' '{"echo":{"enabled":true,"watch_paths":["plugins/*/agents/*.md"]}}' \
+		> "${REPO}/.claude/settings.json"
+	printf '%s\n' '# Echo self' > "${REPO}/plugins/echo/agents/self.md"
+	local input
+	input=$(_make_input)
+	# With echo's own file as the only change, no watched files remain after
+	# exclude filtering — hook exits before the claude guard (no output).
+	run bash -c "PATH=/usr/bin:/bin printf '%s' '$input' | ONLOOKER_DIR='$ONLOOKER_DIR' '$HOOK'"
+	[ "$status" -eq 0 ]
+	[ -z "$output" ]
+}

package/test/bats/echo-ulid.bats

@@ -0,0 +1,38 @@
+#!/usr/bin/env bats
+
+setup() {
+	source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+	setup_test_env
+
+	PLUGIN_ROOT="${REPO_ROOT}/plugins/echo"
+	# shellcheck disable=SC1091
+	source "${PLUGIN_ROOT}/scripts/lib/echo-ulid.sh"
+}
+
+@test "echo_ulid returns a 26-char crockford base32 string" {
+	local id
+	id=$(echo_ulid)
+	[ "${#id}" -eq 26 ]
+	[[ "$id" =~ ^[0123456789ABCDEFGHJKMNPQRSTVWXYZ]{26}$ ]]
+}
+
+@test "two ULIDs minted apart are lexicographically ordered or equal" {
+	local a b
+	a=$(echo_ulid)
+	sleep 0.01
+	b=$(echo_ulid)
+	[[ "$a" < "$b" ]] || [ "$a" = "$b" ]
+}
+
+@test "many ULIDs are unique" {
+	local seen="${BATS_TEST_TMPDIR}/ulids.txt"
+	: > "$seen"
+	local i
+	for ((i = 0; i < 50; i++)); do
+		printf '%s\n' "$(echo_ulid)" >> "$seen"
+	done
+	local total unique
+	total=$(wc -l < "$seen" | tr -d ' ')
+	unique=$(sort -u "$seen" | wc -l | tr -d ' ')
+	[ "$total" = "$unique" ]
+}

package/test/bats/portable-lock.bats

@@ -0,0 +1,62 @@
+#!/usr/bin/env bats
+
+setup() {
+  # shellcheck source=../helpers/setup.bash
+  source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+  setup_test_env
+  # shellcheck disable=SC1091
+  source "${REPO_ROOT}/scripts/lib/portable-lock.sh"
+  LOCK="${BATS_TEST_TMPDIR}/test.lock"
+}
+
+@test "lock_acquire succeeds on an unlocked path" {
+  run lock_acquire "$LOCK" 1
+  [ "$status" -eq 0 ]
+  [ -d "${LOCK}.d" ]
+  lock_release "$LOCK"
+}
+
+@test "lock_acquire on a held lock blocks until released" {
+  lock_acquire "$LOCK" 1
+  # Start a background releaser after 200ms.
+  ( sleep 0.2; lock_release "$LOCK" ) &
+  local releaser=$!
+  # Second acquire should succeed once the releaser fires.
+  run lock_acquire "$LOCK" 2
+  wait $releaser
+  [ "$status" -eq 0 ]
+  lock_release "$LOCK"
+}
+
+@test "lock_acquire returns 1 when timeout elapses with the lock still held" {
+  mkdir "${LOCK}.d"
+  run lock_acquire "$LOCK" 1
+  [ "$status" -eq 1 ]
+  rmdir "${LOCK}.d"
+}
+
+@test "lock_release is a no-op when the lock is not held" {
+  run lock_release "$LOCK"
+  [ "$status" -eq 0 ]
+}
+
+@test "concurrent appenders do not interleave writes" {
+  local out="${BATS_TEST_TMPDIR}/concurrent.txt"
+  : >"$out"
+  local n=20
+  local i
+  for ((i = 0; i < n; i++)); do
+    (
+      lock_acquire "$LOCK" 5 || exit 1
+      # Write a 100-char marker so any byte-level interleave is obvious.
+      printf '%s\n' "$(printf 'x%.0s' {1..100})" >>"$out"
+      lock_release "$LOCK"
+    ) &
+  done
+  wait
+  # All lines should be exactly 100 bytes followed by newline.
+  local lines
+  lines=$(wc -l <"$out" | tr -d ' ')
+  [ "$lines" = "$n" ]
+  awk 'length($0) != 100 { bad++ } END { exit (bad > 0) }' "$out"
+}