@onlooker-community/ecosystem 0.0.2 → 0.2.1

package/test/bats/onlooker-emit.bats

@@ -0,0 +1,26 @@
+#!/usr/bin/env bats
+
+setup() {
+  # shellcheck source=../helpers/setup.bash
+  source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+  load_validate_path
+  # shellcheck source=../../scripts/lib/onlooker-schema.sh
+  source "${REPO_ROOT}/scripts/lib/onlooker-schema.sh"
+  export _HOOK_SESSION_ID="emit-direct-session"
+  export ONLOOKER_PLUGIN_NAME="onlooker"
+  : >"$ONLOOKER_EVENTS_LOG"
+}
+
+@test "onlooker-emit writes canonical tool.agent.spawn to events log" {
+  local payload='{"subagent_id":"agent-99","agent_name":"explore","task_summary":"search"}'
+  "${REPO_ROOT}/scripts/lib/onlooker-emit.sh" "tool.agent.spawn" "$payload"
+  [ "$?" -eq 0 ]
+  tail -n 1 "$ONLOOKER_EVENTS_LOG" | jq -e \
+    '.schema_version == "1.0"
+     and .event_type == "tool.agent.spawn"
+     and .session_id == "emit-direct-session"
+     and .plugin == "onlooker"
+     and .payload.subagent_id == "agent-99"' \
+    >/dev/null
+  tail -n 1 "$ONLOOKER_EVENTS_LOG" | onlooker_validate_event
+}

package/test/bats/tool-history-tracker.bats

@@ -0,0 +1,72 @@
+#!/usr/bin/env bats
+
+setup() {
+  # shellcheck source=../helpers/setup.bash
+  source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+  load_validate_path
+  # shellcheck source=../../scripts/lib/onlooker-schema.sh
+  source "${REPO_ROOT}/scripts/lib/onlooker-schema.sh"
+  # shellcheck source=../../scripts/lib/tool-history.sh
+  source "${REPO_ROOT}/scripts/lib/tool-history.sh"
+  export CLAUDE_PLUGIN_ROOT="${REPO_ROOT}"
+}
+
+@test "tool_history_build_record returns canonical tool.file.read event" {
+  local fixture="${REPO_ROOT}/test/fixtures/hook-inputs/post-tool-use-read.json"
+  local record
+  record=$(tool_history_build_record "$(cat "$fixture")")
+  echo "$record" | jq -e \
+    '.schema_version == "1.0"
+     and .event_type == "tool.file.read"
+     and .payload.path == "/project/src/main.ts"
+     and .session_id == "history-session-001"' \
+    >/dev/null
+  echo "$record" | onlooker_validate_event
+}
+
+@test "tool_history_build_record returns canonical tool.shell.exec on failure" {
+  local fixture="${REPO_ROOT}/test/fixtures/hook-inputs/post-tool-use-failure-bash.json"
+  local record
+  record=$(tool_history_build_record "$(cat "$fixture")")
+  echo "$record" | jq -e \
+    '.event_type == "tool.shell.exec"
+     and .payload.command == "npm test"
+     and .payload.blocked == true' \
+    >/dev/null
+  echo "$record" | onlooker_validate_event
+}
+
+@test "tool-history-tracker appends canonical PostToolUse event to session JSONL" {
+  local fixture="${REPO_ROOT}/test/fixtures/hook-inputs/post-tool-use-read.json"
+  local history_file="${ONLOOKER_SESSION_HISTORY_DIR}/history-session-001.jsonl"
+  rm -f "$history_file" "${history_file}.lock"
+
+  run bash -c "cat '${fixture}' | '${REPO_ROOT}/scripts/hooks/tool-history-tracker.sh' 2>/dev/null"
+  [ "$status" -eq 0 ]
+  [ -f "$history_file" ]
+  tail -n 1 "$history_file" | jq -e '.event_type == "tool.file.read"' >/dev/null
+  tail -n 1 "$history_file" | onlooker_validate_event
+}
+
+@test "tool-history-tracker mirrors event to global onlooker-events log" {
+  local fixture="${REPO_ROOT}/test/fixtures/hook-inputs/post-tool-use-read.json"
+  : >"$ONLOOKER_EVENTS_LOG"
+
+  cat "$fixture" | "${REPO_ROOT}/scripts/hooks/tool-history-tracker.sh" >/dev/null 2>&1
+
+  tail -n 1 "$ONLOOKER_EVENTS_LOG" | jq -e '.event_type == "tool.file.read"' >/dev/null
+  tail -n 1 "$ONLOOKER_EVENTS_LOG" | onlooker_validate_event
+}
+
+@test "tool-history-tracker appends multiple canonical records for same session" {
+  local read_fixture="${REPO_ROOT}/test/fixtures/hook-inputs/post-tool-use-read.json"
+  local fail_fixture="${REPO_ROOT}/test/fixtures/hook-inputs/post-tool-use-failure-bash.json"
+  local history_file="${ONLOOKER_SESSION_HISTORY_DIR}/history-session-001.jsonl"
+  rm -f "$history_file" "${history_file}.lock"
+
+  cat "$read_fixture" | "${REPO_ROOT}/scripts/hooks/tool-history-tracker.sh" >/dev/null 2>&1
+  cat "$fail_fixture" | "${REPO_ROOT}/scripts/hooks/tool-history-tracker.sh" >/dev/null 2>&1
+
+  run wc -l <"$history_file"
+  [ "$output" -eq 2 ]
+}

package/test/bats/tool-sequence-tracker.bats

@@ -0,0 +1,53 @@
+#!/usr/bin/env bats
+
+setup() {
+  # shellcheck source=../helpers/setup.bash
+  source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+  load_validate_path
+  export CLAUDE_PLUGIN_ROOT="${REPO_ROOT}"
+}
+
+@test "tool-sequence-tracker approves and increments turn_tool_seq" {
+  local fixture="${REPO_ROOT}/test/fixtures/hook-inputs/non-agent-tool.json"
+  local tracker="${ONLOOKER_SESSION_TRACKERS_DIR}/test-session-001"
+  rm -f "$tracker"
+
+  run bash -c "cat '${fixture}' | '${REPO_ROOT}/scripts/hooks/tool-sequence-tracker.sh' 2>/dev/null"
+  [ "$status" -eq 0 ]
+  echo "$output" | jq -e '.decision == "approve"' >/dev/null
+
+  jq -e '.turn_number == 1 and .turn_tool_seq == 1' "$tracker" >/dev/null
+}
+
+@test "tool-sequence-tracker increments on successive tool calls" {
+  local fixture="${REPO_ROOT}/test/fixtures/hook-inputs/non-agent-tool.json"
+  local tracker="${ONLOOKER_SESSION_TRACKERS_DIR}/test-session-001"
+  rm -f "$tracker"
+
+  cat "$fixture" | "${REPO_ROOT}/scripts/hooks/tool-sequence-tracker.sh" >/dev/null 2>&1
+  cat "$fixture" | "${REPO_ROOT}/scripts/hooks/tool-sequence-tracker.sh" >/dev/null 2>&1
+
+  jq -e '.turn_tool_seq == 2' "$tracker" >/dev/null
+}
+
+@test "turn_state_ensure_session creates tracker with defaults" {
+  local session_id="ensure-session"
+  local tracker="${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+  rm -f "$tracker"
+
+  turn_state_ensure_session "$session_id"
+  [ "$?" -eq 0 ]
+  jq -e '.turn_number == 1 and .turn_tool_seq == 0' "$tracker" >/dev/null
+}
+
+@test "turn_state_next_tool increments existing tracker" {
+  local session_id="next-tool-session"
+  local tracker="${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+  rm -f "$tracker"
+
+  turn_state_ensure_session "$session_id"
+  turn_state_next_tool "$session_id"
+  turn_state_next_tool "$session_id"
+
+  jq -e '.turn_tool_seq == 2' "$tracker" >/dev/null
+}

package/test/bats/validate-path.bats

@@ -0,0 +1,109 @@
+#!/usr/bin/env bats
+
+setup() {
+  # shellcheck source=../helpers/setup.bash
+  source "${BATS_TEST_DIRNAME}/../helpers/setup.bash"
+  load_validate_path
+  # shellcheck source=../../scripts/lib/onlooker-schema.sh
+  source "${REPO_ROOT}/scripts/lib/onlooker-schema.sh"
+}
+
+@test "validate_file_exists succeeds for existing file" {
+  local f="${BATS_TEST_TMPDIR}/exists.txt"
+  touch "$f"
+  validate_file_exists "$f"
+  [ "$?" -eq 0 ]
+}
+
+@test "validate_file_exists fails for missing file" {
+  ! validate_file_exists "${BATS_TEST_TMPDIR}/missing.txt"
+}
+
+@test "validate_dir_exists succeeds for existing directory" {
+  validate_dir_exists "${BATS_TEST_TMPDIR}"
+  [ "$?" -eq 0 ]
+}
+
+@test "ensure_dir_exists creates missing directory" {
+  local dir="${BATS_TEST_TMPDIR}/nested/new-dir"
+  ensure_dir_exists "$dir"
+  [ "$?" -eq 0 ]
+  [ -d "$dir" ]
+}
+
+@test "ensure_file_exists creates file and parent directories" {
+  local f="${BATS_TEST_TMPDIR}/deep/path/file.txt"
+  ensure_file_exists "$f"
+  [ "$?" -eq 0 ]
+  [ -f "$f" ]
+}
+
+@test "safe_append writes content to file" {
+  local f="${BATS_TEST_TMPDIR}/append.txt"
+  safe_append "$f" "line-one"
+  safe_append "$f" "line-two"
+  grep -q "line-one" "$f"
+  grep -q "line-two" "$f"
+}
+
+@test "safe_tail returns last N lines" {
+  local f="${BATS_TEST_TMPDIR}/tail.txt"
+  printf '%s\n' one two three four >"$f"
+  local result
+  result=$(safe_tail "$f" 2)
+  [ "$result" = $'three\nfour' ]
+}
+
+@test "hook_set_context exports session and tool from JSON" {
+  local input='{"session_id":"sess-42","tool_name":"Agent"}'
+  hook_set_context "$input" "PreToolUse"
+  [ "${ONLOOKER_HOOK_TYPE}" = "PreToolUse" ]
+  [ "${ONLOOKER_TOOL_NAME}" = "Agent" ]
+  [ "${_HOOK_SESSION_ID}" = "sess-42" ]
+}
+
+@test "hook_bus put/get round-trip" {
+  export _HOOK_SESSION_ID="bus-session"
+  export _HOOK_TOOL_NAME="Agent"
+  hook_bus_init '{"tool_input":{"agent_id":"1"}}'
+  hook_bus_put "scanner" '{"found":true}'
+  local result
+  result=$(hook_bus_get "scanner")
+  echo "$result" | jq -e '.found == true' >/dev/null
+}
+
+@test "hook_bus_has detects existing finding" {
+  export _HOOK_SESSION_ID="bus-session-2"
+  export _HOOK_TOOL_NAME="Agent"
+  hook_bus_init '{"tool_input":{"agent_id":"2"}}'
+  hook_bus_put "flag" '{"ok":true}'
+  hook_bus_has "flag"
+  [ "$?" -eq 0 ]
+  ! hook_bus_has "missing"
+}
+
+@test "turn_state_export reads turn numbers from tracker file" {
+  local session_id="turn-test-session"
+  local tracker="${ONLOOKER_SESSION_TRACKERS_DIR}/${session_id}"
+  mkdir -p "$(dirname "$tracker")"
+  echo '{"turn_number":3,"turn_tool_seq":2}' >"$tracker"
+  turn_state_export "$session_id"
+  [ "${ONLOOKER_TURN_NUMBER}" = "3" ]
+  [ "${ONLOOKER_TURN_TOOL_SEQ}" = "2" ]
+}
+
+@test "safe_emit appends canonical event to onlooker events log" {
+  export _HOOK_SESSION_ID="emit-session"
+  export ONLOOKER_HOOK_TYPE="PreToolUse"
+  export ONLOOKER_TOOL_NAME="Read"
+  local payload='{"path":"/tmp/example.txt"}'
+  safe_emit "tool.file.read" "$payload"
+  [ "$?" -eq 0 ]
+  [ -f "$ONLOOKER_EVENTS_LOG" ]
+  tail -n 1 "$ONLOOKER_EVENTS_LOG" | jq -e \
+    '.event_type == "tool.file.read"
+     and .session_id == "emit-session"
+     and .payload.path == "/tmp/example.txt"
+     and .schema_version == "1.0"' \
+    >/dev/null
+}

package/test/fixtures/hook-inputs/agent-tool.json

@@ -0,0 +1,11 @@
+{
+  "session_id": "test-session-001",
+  "tool_name": "Agent",
+  "tool_input": {
+    "subagent_type": "explore",
+    "description": "Search the codebase",
+    "run_in_background": false,
+    "isolation": "worktree",
+    "model": "sonnet"
+  }
+}

package/test/fixtures/hook-inputs/non-agent-tool.json

@@ -0,0 +1,7 @@
+{
+  "session_id": "test-session-001",
+  "tool_name": "Read",
+  "tool_input": {
+    "file_path": "/tmp/example.txt"
+  }
+}

package/test/fixtures/hook-inputs/post-tool-use-failure-bash.json

@@ -0,0 +1,12 @@
+{
+  "session_id": "history-session-001",
+  "hook_event_name": "PostToolUseFailure",
+  "tool_name": "Bash",
+  "tool_use_id": "toolu_bash_001",
+  "duration_ms": 4187,
+  "tool_input": {
+    "command": "npm test",
+    "description": "Run test suite"
+  },
+  "error": "Command exited with non-zero status code 1"
+}

package/test/fixtures/hook-inputs/post-tool-use-read.json

@@ -0,0 +1,13 @@
+{
+  "session_id": "history-session-001",
+  "hook_event_name": "PostToolUse",
+  "tool_name": "Read",
+  "tool_use_id": "toolu_read_001",
+  "duration_ms": 42,
+  "tool_input": {
+    "file_path": "/project/src/main.ts"
+  },
+  "tool_response": {
+    "content": "export function main() {\n  return 1;\n}\n"
+  }
+}

package/test/helpers/setup.bash

@@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+# Shared setup for Onlooker ecosystem bats tests.
+
+# Repo root: test/helpers -> test -> repo
+REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+export REPO_ROOT
+
+# BATS_TEST_TMPDIR may be unset during setup_file on some runners; ensure a temp base.
+if [[ -z "${BATS_TEST_TMPDIR:-}" ]]; then
+  export BATS_TEST_TMPDIR="${TMPDIR:-/tmp}/onlooker-bats-${BATS_SUITE_TEST_NUMBER:-$$}"
+  mkdir -p "$BATS_TEST_TMPDIR"
+fi
+
+# Isolate all filesystem side effects under BATS_TEST_TMPDIR.
+setup_test_env() {
+  export TEST_HOME="${BATS_TEST_TMPDIR}/home"
+  mkdir -p "$TEST_HOME"
+
+  export HOME="$TEST_HOME"
+  export ONLOOKER_DIR="${TEST_HOME}/.onlooker"
+  export CLAUDE_HOME="${TEST_HOME}/.claude"
+  export CLAUDE_PLUGIN_ROOT="${REPO_ROOT}"
+}
+
+# Source validate-path.sh with test env vars already set.
+load_validate_path() {
+  setup_test_env
+  # shellcheck disable=SC1091
+  source "${REPO_ROOT}/scripts/lib/validate-path.sh"
+
+  mkdir -p \
+    "$(dirname "$ONLOOKER_EVENTS_LOG")" \
+    "$ONLOOKER_SESSION_TRACKERS_DIR" \
+    "$ONLOOKER_SESSION_HISTORY_DIR" \
+    "$ONLOOKER_SESSION_SUMMARIES_DIR" \
+    "$ONLOOKER_COMPACT_TRACKERS_DIR" \
+    "$ONLOOKER_METRICS_DIR"
+}

package/test/node/schema-events.test.mjs

@@ -0,0 +1,67 @@
+import assert from 'node:assert/strict';
+import { mkdtempSync, readFileSync, rmSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { test } from 'node:test';
+import { fileURLToPath } from 'node:url';
+import { validate } from '@onlooker-community/schema';
+import { buildCanonicalEvent, mapHookInputToCanonical } from '../../scripts/lib/onlooker-event.mjs';
+
+const REPO_ROOT = join(fileURLToPath(new URL('../..', import.meta.url)));
+const FIXTURES = join(REPO_ROOT, 'test/fixtures/hook-inputs');
+
+function loadFixture(name) {
+  return JSON.parse(readFileSync(join(FIXTURES, name), 'utf8'));
+}
+
+test('mapHookInputToCanonical maps PostToolUse Read to tool.file.read', () => {
+  const hookInput = loadFixture('post-tool-use-read.json');
+  const tmpDir = join(REPO_ROOT, 'test/tmp-schema-events');
+  const mapped = mapHookInputToCanonical(hookInput, {
+    onlookerDir: tmpDir,
+    plugin: 'onlooker',
+  });
+
+  assert.equal(mapped.valid, true);
+  assert.equal(mapped.event.event_type, 'tool.file.read');
+  assert.equal(mapped.event.schema_version, '1.0');
+  assert.equal(mapped.event.payload.path, '/project/src/main.ts');
+  assert.equal(validate(mapped.event).valid, true);
+});
+
+test('mapHookInputToCanonical maps PostToolUseFailure Bash to tool.shell.exec', () => {
+  const hookInput = loadFixture('post-tool-use-failure-bash.json');
+  const tmpDir = join(REPO_ROOT, 'test/tmp-schema-events');
+  const mapped = mapHookInputToCanonical(hookInput, {
+    onlookerDir: tmpDir,
+    plugin: 'onlooker',
+  });
+
+  assert.equal(mapped.valid, true);
+  assert.equal(mapped.event.event_type, 'tool.shell.exec');
+  assert.equal(mapped.event.payload.command, 'npm test');
+  assert.equal(mapped.event.payload.blocked, true);
+  assert.equal(validate(mapped.event).valid, true);
+});
+
+test('buildCanonicalEvent assigns monotonic file-backed sequence', () => {
+  const tmpDir = mkdtempSync(join(tmpdir(), 'onlooker-seq-'));
+  const a = buildCanonicalEvent({
+    onlookerDir: tmpDir,
+    plugin: 'onlooker',
+    session_id: 'seq-test',
+    event_type: 'tool.file.read',
+    payload: { path: '/a' },
+  });
+  const b = buildCanonicalEvent({
+    onlookerDir: tmpDir,
+    plugin: 'onlooker',
+    session_id: 'seq-test',
+    event_type: 'tool.file.read',
+    payload: { path: '/b' },
+  });
+
+  assert.equal(a.sequence, 0);
+  assert.equal(b.sequence, 1);
+  rmSync(tmpDir, { recursive: true, force: true });
+});