@onlineapps/service-wrapper 3.4.0 → 3.4.2

package/CHANGELOG.md

@@ -2,6 +2,32 @@
 
 All notable changes to this package. Follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) format and semantic versioning within the internal-monorepo convention (all biz-service consumers ship matching changes in the same session).
 
+## [3.4.2] — 2026-08-17
+
+**Hot-fix: dangling `serviceUrl` reference at line 2649** left by 3.4.1's guard-removal pass. `_ensureValidationProof` still passed `serviceUrl` to `ValidationOrchestrator` after the `const serviceUrl = ...` declaration was deleted. Result: every biz that force-recreated to 3.4.1 hit `Phase 0.2 Tier 1 Validation - FAILED: serviceUrl is not defined` and stalled.
+
+Fix: reintroduce `const serviceUrl = this.config.service?.url || ''` — kept as local so downstream still gets the value (empty string when config omits URL; used only for telemetry/log annotation by ValidationOrchestrator).
+
+Verified: property/meta/converter recreated post-3.4.2 pass Phase 0.2.
+
+## [3.4.1] — 2026-08-17
+
+**Patch: drop stale port/url/specificationEndpoint guards left over from A2.2.**
+
+Under 3.4.0 the wrapper still refused to start when `config.service.port`, `config.service.url`, or `config.service.specificationEndpoint` were absent — legacy checks from `_ensureValidationProof` and `_initializeRegistry` that predated ADR 0005 and were not removed together with the Express init in A2.2. Live rollout hit the failure on first biz restart (biz-property Phase 0.2: "Service port is required for validation").
+
+Removed:
+- Port + URL guard in `_ensureValidationProof` (before Tier-1 validation runs).
+- Port + URL guard in `_initializeRegistry` (before Registry registration).
+- specificationEndpoint guard in `_initializeRegistry`.
+
+Behaviour changes:
+- `serviceInfo.url` sent to Registry is now the empty string (was: required non-empty).
+- `specificationEndpoint` sent to RegistryClient is `''` when absent (was: throw).
+- Consumers: none — Registry stores the ops spec directly from the register payload; the URL and endpoint fields have had no live reader since 3.4.0 A2.
+
+Fully compatible with 3.4.0 tests (98/98 GREEN) and with 3.4.0 biz configs that still declare `port`/`url`/`specificationEndpoint` in `config/service/config.json` — they're just no longer required.
+
 ## [3.4.0] — 2026-08-17
 
 **Zero-HTTP shape for biz services** (ADR 0005 landed). See `api/docs/biz/80-decisions/0005-no-http-in-biz-containers.md`.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/service-wrapper",
-  "version": "3.4.0",
+  "version": "3.4.2",
   "description": "Thin orchestration layer for microservices - delegates all infrastructure concerns to specialized connectors",
   "main": "src/index.js",
   "scripts": {

package/src/ServiceWrapper.js

@@ -1234,15 +1234,11 @@ class ServiceWrapper {
       throw new Error('[ServiceWrapper] Missing configuration - service.name is required');
     }
 
-    const servicePort = this.config.service?.port;
-    if (!servicePort) {
-      throw new Error('[ServiceWrapper] Missing configuration - service.port is required');
-    }
-
-    const serviceUrl = this.config.service?.url;
-    if (!serviceUrl) {
-      throw new Error('[ServiceWrapper] Missing configuration - service.url is required');
-    }
+    // ADR 0005: biz has no HTTP — no port, no URL. Kept in serviceInfo
+    // payload as empty string for Registry-side backward compat with
+    // pre-3.4.1 consumers that may still expect the field.
+    const servicePort = null;
+    const serviceUrl = '';
 
     const mqUrl = this.config.wrapper?.mq?.url;
     if (!mqUrl) {
@@ -1253,14 +1249,11 @@ class ServiceWrapper {
     // FÁZE 0.5 a 0.6: Vytvoření front a spuštění konzumerů se provádí v registryClient.init()
     // FÁZE 0.7: Registrace u Registry
 
-    // FAIL-FAST: specificationEndpoint MUST be in config, no fallbacks
-    const specificationEndpoint = this.config.service?.specificationEndpoint;
-    if (!specificationEndpoint) {
-      throw new Error(
-        `[ServiceWrapper] Missing required configuration - service.specificationEndpoint is required. ` +
-        `Fix: Add "specificationEndpoint": "/api/v1/specification" to conn-config/config.json under "service" section.`
-      );
-    }
+    // ADR 0005: no HTTP surface → specificationEndpoint has no consumer.
+    // Registry receives full operations spec in the register payload
+    // itself. Field kept optional for pre-3.4.1 config files that may
+    // still declare it; ignored if absent.
+    const specificationEndpoint = this.config.service?.specificationEndpoint || '';
 
     // Logger may not be initialized yet at this point - RegistryClient handles null gracefully
     this.registryClient = new RegistryConnector.ServiceRegistryClient({
@@ -2621,16 +2614,14 @@ class ServiceWrapper {
       throw new Error('Service version is required for validation');
     }
 
-    const { name: serviceName, version: serviceVersion, port: servicePort } = this.config.service;
-
-    if (!servicePort) {
-      throw new Error('Service port is required for validation (config.service.port)');
-    }
+    const { name: serviceName, version: serviceVersion } = this.config.service;
 
-    const serviceUrl = this.config.service?.url;
-    if (!serviceUrl) {
-      throw new Error('[ServiceWrapper] Missing configuration - config.service.url is required for validation (set SERVICE_URL in conn-config/config.json placeholder)');
-    }
+    // ADR 0005: biz services have no HTTP surface — no port to bind, no
+    // URL to advertise. Prior versions of this method required both;
+    // dropped in 3.4.1 because they had no consumer post-A2. Kept as a
+    // local var so downstream ValidationOrchestrator can still receive it
+    // (accepts empty string; only used for telemetry / log annotation).
+    const serviceUrl = this.config.service?.url || '';
 
     // Phase 5: Check restart-aware failure tracking
     const failureData = this._readValidationFailureFile();