@onlineapps/service-wrapper 2.1.89 → 2.1.90

package/config/runtime-defaults.json

@@ -19,11 +19,6 @@
         "enabled": true,
         "metrics": ["requests", "errors", "duration"]
       },
-      "startupAlerts": {
-        "enabled": true,
-        "cooldownMs": 600000,
-        "stateFile": "/tmp/oa_startup_failure_state.json"
-      },
       "logging": {
         "enabled": true,
         "level": "info",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/service-wrapper",
-  "version": "2.1.89",
+  "version": "2.1.90",
   "description": "Thin orchestration layer for microservices - delegates all infrastructure concerns to specialized connectors",
   "main": "src/index.js",
   "scripts": {
@@ -29,9 +29,9 @@
     "@onlineapps/conn-infra-error-handler": "1.0.8",
     "@onlineapps/conn-infra-mq": "1.1.66",
     "@onlineapps/conn-orch-api-mapper": "1.0.26",
-    "@onlineapps/conn-orch-cookbook": "2.0.27",
-    "@onlineapps/conn-orch-orchestrator": "1.0.91",
-    "@onlineapps/conn-orch-registry": "1.1.43",
+    "@onlineapps/conn-orch-cookbook": "2.0.28",
+    "@onlineapps/conn-orch-orchestrator": "1.0.92",
+    "@onlineapps/conn-orch-registry": "1.1.44",
     "@onlineapps/conn-orch-validator": "2.0.25",
     "@onlineapps/monitoring-core": "1.0.20",
     "@onlineapps/service-common": "1.0.15",

package/src/ServiceWrapper.js

@@ -417,20 +417,16 @@ class ServiceWrapper {
   /**
    * Handle initialization error with restart strategy
    * @private
+   * 
+   * NOTE: Alerting is NOT done here. Before registration, service is in "dev care" phase.
+   * After registration, Registry monitors heartbeats and triggers alerts via Monitoring.
+   * This keeps alerting responsibility centralized in Monitoring (Separation of Concerns).
    */
   async _handleInitializationError(phase, phaseName, error, isTransient = false) {
     this._logPhase(phase, phaseName, 'FAILED', error);
     
     // Cleanup before restart
     await this._cleanupBeforeRestart();
-
-    // Startup failure alert (works without MQ/monitoring)
-    try {
-      await this._maybeSendStartupFailureAlert({ phase, phaseName, error, isTransient });
-    } catch (alertErr) {
-      // Alerts must never block restart; log and continue.
-      console.warn('[StartupAlerts] Failed to send startup failure alert:', alertErr.message);
-    }
     
     if (isTransient) {
       // Přechodná chyba → restart může pomoci
@@ -443,81 +439,6 @@ class ServiceWrapper {
     }
   }
 
-  /**
-   * Send startup-failure alert via SMTP (independent of MQ).
-   * Uses service-common sendMonitoringFailFallbackEmail (SMTP config via INFRA_REPORT_* env).
-   * Throttled by a persistent state file (survives container restarts).
-   *
-   * @private
-   */
-  async _maybeSendStartupFailureAlert({ phase, phaseName, error, isTransient }) {
-    const cfg = this.config.wrapper?.startupAlerts;
-    if (!cfg || cfg.enabled !== true) {
-      return;
-    }
-
-    const cooldownMs = cfg.cooldownMs;
-    const stateFile = cfg.stateFile;
-    if (typeof cooldownMs !== 'number' || Number.isNaN(cooldownMs) || cooldownMs <= 0) {
-      throw new Error(`[StartupAlerts] Invalid configuration - wrapper.startupAlerts.cooldownMs must be a positive number, got: ${cooldownMs}`);
-    }
-    if (typeof stateFile !== 'string' || stateFile.trim() === '') {
-      throw new Error(`[StartupAlerts] Invalid configuration - wrapper.startupAlerts.stateFile must be a non-empty string, got: ${stateFile}`);
-    }
-
-    const fs = require('fs');
-    const path = require('path');
-    const serviceName = this.config.service?.name || 'unnamed-service';
-    const now = Date.now();
-
-    let state = { lastAlertAt: 0, failureCount: 0, lastFailureAt: 0 };
-    try {
-      if (fs.existsSync(stateFile)) {
-        const raw = fs.readFileSync(stateFile, 'utf8');
-        state = { ...state, ...(JSON.parse(raw) || {}) };
-      } else {
-        // Ensure parent dir exists (best-effort)
-        const dir = path.dirname(stateFile);
-        try { fs.mkdirSync(dir, { recursive: true }); } catch (_) { /* ignore */ }
-      }
-    } catch (e) {
-      // If state cannot be read, continue with defaults (alerting must not crash init)
-    }
-
-    state.failureCount = (state.failureCount || 0) + 1;
-    state.lastFailureAt = now;
-
-    const shouldSend = !state.lastAlertAt || (now - state.lastAlertAt) >= cooldownMs;
-    if (!shouldSend) {
-      // Persist updated counters anyway
-      try { fs.writeFileSync(stateFile, JSON.stringify(state), 'utf8'); } catch (_) { /* ignore */ }
-      return;
-    }
-
-    const { sendMonitoringFailFallbackEmail } = require('@onlineapps/service-common');
-    const transientLabel = isTransient ? 'TRANSIENT' : 'PERMANENT';
-    const subject = `[StartupFailure] ${serviceName} phase ${phase} (${transientLabel})`;
-    const text = [
-      `Service: ${serviceName}`,
-      `Phase: ${phase} (${phaseName})`,
-      `Type: ${transientLabel}`,
-      `Failure count (container): ${state.failureCount}`,
-      `Timestamp: ${new Date(now).toISOString()}`,
-      `Error: ${error?.message || 'unknown error'}`
-    ].join('\n');
-    const html = `<pre>${text}</pre>`;
-
-    const sent = await sendMonitoringFailFallbackEmail(subject, text, html);
-    state.lastAlertAt = now;
-    try { fs.writeFileSync(stateFile, JSON.stringify(state), 'utf8'); } catch (_) { /* ignore */ }
-
-    if (sent) {
-      this.logger?.info('[StartupAlerts] ✓ Startup failure alert sent', { service: serviceName, phase, transient: isTransient });
-    } else {
-      this.logger?.warn('[StartupAlerts] Startup failure alert not sent (SMTP config missing or send failed)', { service: serviceName, phase });
-    }
-  }
-
   async initialize() {
       if (this.isInitialized) {
       // Logger might not be initialized yet, use console as fallback
@@ -911,6 +832,7 @@ class ServiceWrapper {
       amqpUrl: mqUrl,
       serviceName: serviceName,
       version: this.config.service?.version,
+      specificationEndpoint: this.config.service?.specificationEndpoint || '/api/v1/specification',
       registryQueue: 'registry.register', // Use correct queue name
       registryUrl: registryUrl,
       logger: this.logger || console,