@onlineapps/service-wrapper 2.0.49 → 2.0.51

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/service-wrapper",
-  "version": "2.0.49",
+  "version": "2.0.51",
   "description": "Thin orchestration layer for microservices - delegates all infrastructure concerns to specialized connectors",
   "main": "src/index.js",
   "scripts": {

package/src/ServiceWrapper.js

@@ -485,6 +485,11 @@ class ServiceWrapper {
           console.warn('Monitoring initialization failed (non-critical):', error.message);
         }
       }
+      
+      // Register MQ channel close hooks and health monitoring AFTER monitoring is initialized
+      if (this.mqClient) {
+        await this._registerMQHooks();
+      }
 
       // Initialize cache if configured
       if (this.config.wrapper?.cache?.enabled === true) {
@@ -557,6 +562,119 @@ class ServiceWrapper {
     }
   }
 
+  /**
+   * Run health check before workflow step (debug mode only)
+   * @private
+   * @param {Object} message - Workflow message
+   */
+  async _runHealthCheckBeforeWorkflowStep(message) {
+    if (!this.mqClient || !this.mqClient._transport) {
+      return;
+    }
+    
+    const transport = this.mqClient._transport;
+    
+    // Check if transport has performHealthCheck method (public API)
+    if (typeof transport.performHealthCheck === 'function') {
+      try {
+        const health = await transport.performHealthCheck();
+        
+        this.logger?.debug('[ServiceWrapper] [DEBUG] Health check before workflow step', {
+          workflow_id: message.workflow_id || message.workflowId,
+          current_step: message.current_step,
+          health: {
+            healthy: health.healthy,
+            issues: health.issues,
+            consumers: {
+              active: health.consumers.active,
+              tracked: health.consumers.tracked
+            },
+            queues: {
+              checked: health.queues.checked,
+              missing: health.queues.missing,
+              noConsumer: health.queues.noConsumer
+            },
+            channels: health.channels
+          }
+        });
+        
+        if (!health.healthy) {
+          this.logger?.warn('[ServiceWrapper] [DEBUG] Health check FAILED before workflow step', {
+            workflow_id: message.workflow_id || message.workflowId,
+            issues: health.issues
+          });
+        }
+      } catch (err) {
+        this.logger?.warn('[ServiceWrapper] [DEBUG] Health check error before workflow step', {
+          error: err.message,
+          workflow_id: message.workflow_id || message.workflowId
+        });
+      }
+    }
+  }
+
+  /**
+   * Register MQ channel close hooks and health monitoring
+   * Must be called AFTER monitoring is initialized
+   * @private
+   */
+  async _registerMQHooks() {
+    if (!this.mqClient || !this.mqClient._transport) {
+      return;
+    }
+    
+    // Access the underlying transport (RabbitMQClient) to register hooks
+    const transport = this.mqClient._transport;
+    
+    if (typeof transport.onChannelClose === 'function') {
+      // Register hook for all channel types
+      transport.onChannelClose('all', (details) => {
+        const logData = {
+          type: details.type,
+          reason: details.reason,
+          error: details.error ? {
+            message: details.error.message,
+            code: details.error.code,
+            stack: details.error.stack
+          } : null,
+          timestamp: details.timestamp,
+          connectionState: details.connectionState,
+          channelCreatedAt: details.channelCreatedAt,
+          lastOperation: details.lastOperation
+        };
+        
+        if (this.monitoring && this.monitoring.error) {
+          this.monitoring.error(`MQ Channel Closed: ${details.type}`, logData);
+        }
+        console.error(`[ServiceWrapper] [MQ] Channel closed: ${details.type} - ${details.reason}`);
+      });
+      
+      this.logger?.info('MQ channel close hooks registered');
+    }
+    
+    // Register health shutdown handler
+    if (typeof transport.on === 'function') {
+      transport.on('health:shutdown', (health) => {
+        console.error('[ServiceWrapper] [MQ] Health shutdown triggered - shutting down service');
+        if (this.monitoring && this.monitoring.error) {
+          this.monitoring.error('MQ Health Shutdown', {
+            issues: health.issues,
+            timestamp: health.timestamp
+          });
+        }
+        // Graceful shutdown
+        this.shutdown().then(() => {
+          process.exit(1);
+        }).catch((err) => {
+          console.error('[ServiceWrapper] Shutdown error:', err);
+          process.exit(1);
+        });
+      });
+      
+      this.logger?.info('MQ health shutdown handler registered');
+    }
+  }
+
   /**
    * Initialize MQ connection
    * @private
@@ -570,9 +688,10 @@ class ServiceWrapper {
     const serviceName = this.config.service?.name || 'unnamed-service';
 
     // Health monitoring and channel close hooks configuration
+    // NOTE: Health monitoring is NOT run periodically - it's triggered manually before workflow steps in debug mode
     const healthCheckConfig = {
-      healthCheckInterval: this.config.wrapper?.mq?.healthCheckInterval || 30000, // 30s
-      healthCheckEnabled: this.config.wrapper?.mq?.healthCheckEnabled !== false, // Default: true
+      healthCheckInterval: this.config.wrapper?.mq?.healthCheckInterval || 30000, // Not used when healthCheckEnabled=false
+      healthCheckEnabled: false, // Disable periodic checks - we'll run manually before workflow steps
       criticalHealthShutdown: this.config.wrapper?.mq?.criticalHealthShutdown !== false, // Default: true
       criticalHealthShutdownDelay: this.config.wrapper?.mq?.criticalHealthShutdownDelay || 60000, // 60s
       // Health reporting callbacks
@@ -624,51 +743,6 @@ class ServiceWrapper {
       await this.mqClient.connect();
       this.logger?.info('MQ connector initialized');
       
-      // Register channel close hooks after connection is established
-      // Access the underlying transport (RabbitMQClient) via _transport
-      if (this.mqClient._transport && typeof this.mqClient._transport.onChannelClose === 'function') {
-        // Register hook for all channel types
-        this.mqClient._transport.onChannelClose('all', (details) => {
-          const logData = {
-            type: details.type,
-            reason: details.reason,
-            error: details.error ? {
-              message: details.error.message,
-              code: details.error.code,
-              stack: details.error.stack
-            } : null,
-            timestamp: details.timestamp,
-            connectionState: details.connectionState,
-            channelCreatedAt: details.channelCreatedAt,
-            lastOperation: details.lastOperation
-          };
-          
-          if (this.monitoring && this.monitoring.error) {
-            this.monitoring.error(`MQ Channel Closed: ${details.type}`, logData);
-          }
-          console.error(`[ServiceWrapper] [MQ] Channel closed: ${details.type} - ${details.reason}`);
-        });
-        
-        // Register health shutdown handler
-        this.mqClient._transport.on('health:shutdown', (health) => {
-          console.error('[ServiceWrapper] [MQ] Health shutdown triggered - shutting down service');
-          if (this.monitoring && this.monitoring.error) {
-            this.monitoring.error('MQ Health Shutdown', {
-              issues: health.issues,
-              timestamp: health.timestamp
-            });
-          }
-          // Graceful shutdown
-          this.shutdown().then(() => {
-            process.exit(1);
-          }).catch((err) => {
-            console.error('[ServiceWrapper] Shutdown error:', err);
-            process.exit(1);
-          });
-        });
-        
-        this.logger?.info('MQ channel close hooks and health monitoring registered');
-      }
     } catch (error) {
       const message = `[MQConnector] Unable to connect to RabbitMQ at ${mqUrl}. ` +
         'Verify that api_services_queuer is running and accessible. ' +
@@ -1175,6 +1249,11 @@ class ServiceWrapper {
           throw new Error('Workflow message must have current_step field or cookbook with at least one step');
         }
         
+        // DEBUG MODE: Run health check before workflow step
+        if (process.env.DEBUG === 'true' || process.env.NODE_ENV === 'development') {
+          await this._runHealthCheckBeforeWorkflowStep(message);
+        }
+        
         // Normalize message format: Gateway sends workflowId, orchestrator expects workflow_id
         const normalizedMessage = {
           ...message,