@onlineapps/service-wrapper 2.0.46 → 2.0.48

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/service-wrapper",
-  "version": "2.0.46",
+  "version": "2.0.48",
   "description": "Thin orchestration layer for microservices - delegates all infrastructure concerns to specialized connectors",
   "main": "src/index.js",
   "scripts": {

package/src/ServiceWrapper.js

@@ -1116,84 +1116,9 @@ class ServiceWrapper {
         throw new Error(`Unknown message format or operation: ${JSON.stringify(message)}`);
       }
 
-      // Send response to workflow.completed if workflow_id is present
-      if (message.workflow_id && this.mqClient) {
-        // Extract delivery configuration from context (passed from Gateway)
-        // Delivery can specify how to deliver the result (webhook, email, etc.)
-        const delivery = message.context?.delivery || null;
-        
-        const workflowResponse = {
-          workflow_id: message.workflow_id,
-          service: serviceName,
-          operation: message.step?.operation || message.operation,
-          status: 'completed',
-          output: result,
-          delivery: delivery, // Delivery configuration from Gateway context
-          flags,
-          timestamp: new Date().toISOString()
-        };
-
-        try {
-          // Detailed logging before publish
-          const channelState = {
-            mqClientConnected: this.mqClient?._connected,
-            hasTransport: !!this.mqClient?._transport,
-            hasChannel: !!(this.mqClient?._transport?._channel),
-            channelClosed: this.mqClient?._transport?._channel?.closed,
-            hasConnection: !!(this.mqClient?._transport?._connection && !this.mqClient._transport._connection.closed)
-          };
-          
-          this.logger?.info(`[ServiceWrapper] [PUBLISH] Preparing to publish workflow.completed`, {
-            workflowId: message.workflow_id,
-            service: serviceName,
-            operation: workflowResponse.operation,
-            queue: 'workflow.completed',
-            ...channelState
-          });
-          
-          console.log(`[ServiceWrapper] [PUBLISH] Publishing workflow.completed for workflow ${message.workflow_id}`, channelState);
-
-          await this.mqClient.publish('workflow.completed', workflowResponse);
-          
-          // Log success with details
-          this.logger?.info(`[ServiceWrapper] [PUBLISH] ✓ Workflow response sent to workflow.completed: ${message.workflow_id}`, {
-            workflowId: message.workflow_id,
-            queue: 'workflow.completed',
-            responseSize: JSON.stringify(workflowResponse).length
-          });
-          console.log(`[ServiceWrapper] [PUBLISH] ✓ Successfully published workflow.completed for ${message.workflow_id}`);
-        } catch (error) {
-          // Use error handler to log and handle the error
-          const errorContext = {
-            workflowId: message.workflow_id,
-            queue: 'workflow.completed',
-            error: error.message,
-            errorStack: error.stack,
-            mqClientConnected: this.mqClient?._connected,
-            hasTransport: !!this.mqClient?._transport,
-            hasChannel: !!(this.mqClient?._transport?._channel),
-            channelClosed: this.mqClient?._transport?._channel?.closed,
-            hasConnection: !!(this.mqClient?._transport?._connection && !this.mqClient._transport._connection.closed)
-          };
-          
-          this.logger?.error(`[ServiceWrapper] [PUBLISH] ✗ Failed to publish workflow.completed`, errorContext);
-          console.error(`[ServiceWrapper] [PUBLISH] ✗ Failed to publish workflow.completed for ${message.workflow_id}:`, error.message);
-          console.error(`[ServiceWrapper] [PUBLISH] Channel state:`, {
-            hasChannel: errorContext.hasChannel,
-            channelClosed: errorContext.channelClosed,
-            hasConnection: errorContext.hasConnection
-          });
-          
-          if (this.errorHandler) {
-            await this.errorHandler.logError({
-              moduleName: 'ServiceWrapper',
-              operation: 'sendWorkflowResponse',
-              error: error,
-              context: { workflowId: message.workflow_id, queue: 'workflow.completed' }
-            });
-          }
-        }
-      }
+      // NOTE: workflow.completed is published by WorkflowOrchestrator._completeWorkflow()
+      // ServiceWrapper should NOT publish here to avoid duplicate messages
+      // If orchestrator is not used, ServiceWrapper would publish, but that's legacy path
 
       return result;