@onlineapps/mq-client-core 3.2.0 → 4.0.1

package/src/workers/RecoveryWorker.js

@@ -27,13 +27,16 @@ const { assertLogger } = require('@onlineapps/logger-contract');
  * Čtyři otázky (`change-discipline.md` § Removing something removes its
  * declaration) jsou zodpovězené v CHANGELOGu dávky.
  *
- * `scope` tedy už o zakládání front nerozhoduje; říká jen, čí ten klient je.
+ * `scope` tedy už o zakládání front nerozhodoval; od d.419 neříkal nic a od d.514
+ * tu není. Co rozhoduje o tvaru hlášení, je třída vlastnictví, kterou odpověděla
+ * CENTRÁLNÍ deklarace — `error.kind` z `QueueNotFoundError` — takže dva klienti
+ * namířené na tutéž frontu nemohou dostat různou odpověď podle toho, kdo je
+ * postavil. Čtyři otázky k odstranění jsou zodpovězené v CHANGELOGu dávky.
  */
 class RecoveryWorker {
   /**
    * @param {Object} options
    * @param {Object} options.client - RabbitMQClient instance
-   * @param {string} [options.scope='infrastructure'] - 'infrastructure' nebo 'business'
    * @param {Object} options.logger - Logger s info/warn/error/debug (povinny)
    */
   constructor(options = {}) {
@@ -45,7 +48,6 @@ class RecoveryWorker {
     }
 
     this._client = options.client;
-    this._scope = options.scope || 'infrastructure';
     this._logger = assertLogger(
       'RecoveryWorker',
       options.logger,
@@ -98,9 +100,11 @@ class RecoveryWorker {
     // with default arguments and no TTL. Refusing at one door while opening the
     // other is not a guard.
     //
-    // `_scope: 'business'` says the CLIENT belongs to a business service. It has
-    // never meant "may create business queues", and ConnectorMQClient.js:74 sets
-    // it for every biz service, so that reading made the rule vacuous.
+    // `recoveryScope: 'business'` said the CLIENT belongs to a business service.
+    // It never meant "may create business queues", and `ConnectorMQClient` set it
+    // for every biz service, so that reading made the rule vacuous. The key is
+    // gone with the door it guarded (d.514); what decides here is `error.kind`,
+    // which the central declaration answers.
     if (error.kind === 'business') {
       this._logger.error(`[RecoveryWorker] Cannot create business queue '${error.queueName}' - it is created by its owning service via setupServiceQueues() after registration`);
       throw error;