@onlineapps/mq-client-core 2.0.0 → 2.0.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/mq-client-core",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "Core MQ client library for RabbitMQ - shared by infrastructure services and connectors",
   "main": "src/index.js",
   "scripts": {
@@ -18,10 +18,11 @@
   "author": "OnlineApps",
   "license": "MIT",
   "dependencies": {
-    "amqplib": "^0.10.3",
+    "@onlineapps/infra-logger": "2.0.0",
+    "@onlineapps/runtime-config": "1.0.3",
     "ajv": "^8.12.0",
-    "lodash.merge": "^4.6.2",
-    "@onlineapps/runtime-config": "1.0.3"
+    "amqplib": "^0.10.3",
+    "lodash.merge": "^4.6.2"
   },
   "devDependencies": {
     "jest": "^29.7.0"

package/src/transports/rabbitmqClient.js

@@ -13,7 +13,9 @@ const {
   PermanentPublishError,
   QueueNotFoundError,
   classifyPublishError,
+  missingInfrastructureQueueMessage,
 } = require('../utils/publishErrors');
+const { createLogger } = require('@onlineapps/infra-logger');
 const PublishLayer = require('../layers/PublishLayer');
 const RecoveryWorker = require('../workers/RecoveryWorker');
 const PublishMonitor = require('../monitoring/PublishMonitor');
@@ -54,33 +56,6 @@ function buildAmqpMessageProperties(options, persistent, headers) {
   return props;
 }
 
-/**
- * Local structured logger (module-owned) to avoid dependency cycles.
- *
- * IMPORTANT:
- * - mq-client-core is a low-level library used by infrastructure-tools.
- * - Therefore mq-client-core MUST NOT depend on infrastructure-tools.
- */
-function createInfraLogger(service, layer) {
-  const prefix = (contextId, action) => `[${contextId}:${service}:${layer}:${action}]`;
-
-  const toJson = (data) => {
-    try {
-      return JSON.stringify(data);
-    } catch (e) {
-      return JSON.stringify({ error: 'failed_to_serialize', message: e.message });
-    }
-  };
-
-  return {
-    input: (contextId, action, data) => console.log(prefix(contextId, action), toJson(data)),
-    output: (contextId, action, data) => console.log(prefix(contextId, action), toJson(data)),
-    process: (contextId, action, data) => console.log(prefix(contextId, action), toJson(data)),
-    lifecycle: (contextId, action, data) => console.log(prefix(contextId, action), toJson(data)),
-    fail: (contextId, action, data) => console.error(prefix(contextId, action), toJson(data)),
-  };
-}
-
 class RabbitMQClient extends EventEmitter {
   /**
    * @param {Object} config
@@ -167,7 +142,14 @@ class RabbitMQClient extends EventEmitter {
     this._criticalHealthStartTime = null; // Track when critical health started
 
     // Create structured logger for infrastructure logging (module-owned)
-    this._log = createInfraLogger('mq-client-core', 'transport');
+    // ONE implementation of the infrastructure logger, in
+    // @onlineapps/infra-logger. A private copy lived here until 2026-08-29,
+    // justified as avoiding a dependency cycle — a cycle that is not there:
+    // the comment named infrastructure-tools, but the logger is infra-logger,
+    // which declares no @onlineapps dependency at all. The copy meanwhile
+    // missed the identity fail-fast that 2.0.0 added (change-discipline.md:
+    // one fact, one owner).
+    this._log = createLogger('mq-client-core', 'transport');
     
     // Publish layer (retry + buffer)
     this._publishLayer = new PublishLayer({
@@ -1685,10 +1667,7 @@ class RabbitMQClient extends EventEmitter {
           console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] ✓ Infrastructure queue ${queue} exists (consumer will proceed)`);
         } catch (checkErr) {
           if (checkErr.code === 404) {
-            throw new Error(
-              `Infrastructure queue ${queue} is missing. ` +
-              'Ownership rule: infrastructure queues must be created by their owning infrastructure service via initInfrastructureQueues().'
-            );
+            throw new Error(missingInfrastructureQueueMessage(queue));
           }
           throw checkErr;
         }

package/src/utils/publishErrors.js

@@ -67,6 +67,32 @@ class QueueNotFoundError extends PermanentPublishError {
   }
 }
 
+/**
+ * The message a CONSUMER gets when an infrastructure queue it must attach to
+ * does not exist (TODO §22).
+ *
+ * It used to state the rule and leave the reader stuck: it named
+ * `initInfrastructureQueues()`, a function this package does not export and
+ * never has. `mq-client-core` sits deliberately BELOW `infrastructure-tools`
+ * and must not depend on it, so naming the owning package is the only thing
+ * that can bridge the two — and without it the fix is unfindable.
+ *
+ * @param {string} queueName
+ * @returns {string}
+ */
+function missingInfrastructureQueueMessage(queueName) {
+  if (!queueName) {
+    throw new Error('[publishErrors] queueName is required - Expected the name of the missing infrastructure queue');
+  }
+
+  return `[RabbitMQClient] Infrastructure queue ${queueName} is missing - `
+    + 'Expected: it to be created by the infrastructure service that owns it, before any consumer starts. '
+    + 'Consumers never create infrastructure queues: sendToQueue() and consume() would declare them with '
+    + 'default arguments (no TTL, no max-length) and every later declaration would fail with 406. '
+    + 'Fix: start the owning infrastructure service, which calls initInfrastructureQueues() from '
+    + '@onlineapps/infrastructure-tools.';
+}
+
 /**
  * Best-effort klasifikace chyb z publishu do specializovaných typů.
  * Vrací původní chybu, pokud neodpovídá žádnému známému patternu.
@@ -116,6 +142,7 @@ function classifyPublishError(err) {
 }
 
 module.exports = {
+  missingInfrastructureQueueMessage,
   TransientPublishError,
   PermanentPublishError,
   QueueNotFoundError,