@onlineapps/mq-client-core 1.0.81 → 1.0.82

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/mq-client-core",
-  "version": "1.0.81",
+  "version": "1.0.82",
   "description": "Core MQ client library for RabbitMQ - shared by infrastructure services and connectors",
   "main": "src/index.js",
   "scripts": {

package/src/transports/rabbitmqClient.js

@@ -1716,25 +1716,23 @@ class RabbitMQClient extends EventEmitter {
         try {
           await onMessage(msg);
           // Acknowledge message after successful processing
-          if (!noAck) {
-            // Only ack on the original channel instance; if it's gone/closed, do not attempt ack.
+          if (!noAck && !msg._mqProcessed) {
             if (!channelForMsg || channelForMsg.closed) {
               console.warn('[RabbitMQClient] [mq-client-core] [CONSUMER] Cannot ack - consumer channel is closed/recreated (message will be requeued by broker)');
               return;
             }
             try {
               channelForMsg.ack(msg);
+              msg._mqProcessed = true;
             } catch (ackErr) {
-              // If the channel was closed/recreated during processing, delivery tag becomes invalid.
-              // Do NOT send further acks that would close the channel with 406.
               const m = ackErr && ackErr.message ? ackErr.message : '';
               if (m.includes('unknown delivery tag') || m.includes('PRECONDITION_FAILED') || m.includes('Channel closed')) {
+                msg._mqProcessed = true;
                 console.warn('[RabbitMQClient] [mq-client-core] [CONSUMER] Ack failed due to invalid delivery tag / closed channel (message delivery will be handled by broker)', { error: m });
                 return;
               }
               throw ackErr;
             }
-            // Structured log: message acknowledged
             this._log.output(wfId, 'MSG_ACKED', {
               handler: 'consume',
               function: 'RabbitMQClient.consume',
@@ -1742,7 +1740,6 @@ class RabbitMQClient extends EventEmitter {
               output: { status: 'acknowledged', queue }
             });
 
-            // Track ack (decrement in-flight)
             if (tracking) {
               tracking.inFlight = Math.max(0, tracking.inFlight - 1);
               tracking.lastCheck = Date.now();
@@ -1750,16 +1747,16 @@ class RabbitMQClient extends EventEmitter {
           }
         } catch (handlerErr) {
           // Negative acknowledge and requeue by default
-          // Check if channel is still valid before nacking
-          if (channelForMsg && !channelForMsg.closed) {
+          // Skip if already acked/nacked by the handler (prevents double ack → 406)
+          if (!msg._mqProcessed && channelForMsg && !channelForMsg.closed) {
             try {
               channelForMsg.nack(msg, false, true);
+              msg._mqProcessed = true;
             } catch (nackErr) {
-              // Channel may have closed during nack - ignore
+              msg._mqProcessed = true;
               console.warn(`[RabbitMQClient] [mq-client-core] Failed to nack message (channel may be closed): ${nackErr.message}`);
             }
           }
-          // Track nack (decrement in-flight)
           if (tracking) {
             tracking.inFlight = Math.max(0, tracking.inFlight - 1);
             tracking.lastCheck = Date.now();
@@ -2219,14 +2216,19 @@ class RabbitMQClient extends EventEmitter {
    * @param {Object} msg - RabbitMQ message object.
    */
   async ack(msg) {
+    if (msg._mqProcessed) {
+      return; // Already acked/nacked — idempotent
+    }
     if (!this._consumerChannel) {
       throw new Error('Cannot ack: consumer channel is not initialized');
     }
     try {
       this._consumerChannel.ack(msg);
+      msg._mqProcessed = true;
     } catch (err) {
       const m = err && err.message ? err.message : '';
       if (m.includes('unknown delivery tag') || m.includes('PRECONDITION_FAILED') || m.includes('Channel closed')) {
+        msg._mqProcessed = true;
         console.warn('[RabbitMQClient] [mq-client-core] Cannot ack - consumer channel is closed/recreated (delivery tag invalid)', { error: m });
         return;
       }
@@ -2241,15 +2243,20 @@ class RabbitMQClient extends EventEmitter {
    * @param {Object} [options] - { requeue: boolean }.
    */
   async nack(msg, options = {}) {
+    if (msg._mqProcessed) {
+      return; // Already acked/nacked — idempotent
+    }
     if (!this._consumerChannel) {
       throw new Error('Cannot nack: consumer channel is not initialized');
     }
     const requeue = options.requeue !== undefined ? options.requeue : true;
     try {
       this._consumerChannel.nack(msg, false, requeue);
+      msg._mqProcessed = true;
     } catch (err) {
       const m = err && err.message ? err.message : '';
       if (m.includes('unknown delivery tag') || m.includes('PRECONDITION_FAILED') || m.includes('Channel closed')) {
+        msg._mqProcessed = true;
         console.warn('[RabbitMQClient] [mq-client-core] Cannot nack - consumer channel is closed/recreated (delivery tag invalid)', { error: m });
         return;
       }