@onlineapps/mq-client-core 1.0.79 → 1.0.80

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/mq-client-core",
-  "version": "1.0.79",
+  "version": "1.0.80",
   "description": "Core MQ client library for RabbitMQ - shared by infrastructure services and connectors",
   "main": "src/index.js",
   "scripts": {

package/src/config.js

@@ -27,3 +27,6 @@ const runtimeCfg = createRuntimeConfig({
 module.exports = runtimeCfg;
 
 
+
+
+

package/src/defaults.js

@@ -15,3 +15,6 @@ module.exports = {
 };
 
 
+
+
+

package/src/transports/rabbitmqClient.js

@@ -1552,16 +1552,17 @@ class RabbitMQClient extends EventEmitter {
       
       if (queueConfig) {
         if (isInfraQueue) {
-          // Infrastructure queue - use central config
+          // Infrastructure queue - use central config for expected arguments,
+          // but DO NOT create it here. Ownership rule: infra queues are created by their owning infra service.
           try {
             const infraConfig = queueConfig.getInfrastructureQueueConfig(queue);
             queueOptions = {
               durable: infraConfig.durable !== false,
               arguments: { ...infraConfig.arguments }
             };
-            console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] Asserting infrastructure queue ${queue} with config from queueConfig`);
+            console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] Checking infrastructure queue ${queue} exists (no auto-create)`);
           } catch (configErr) {
-            console.warn(`[RabbitMQClient] [mq-client-core] [CONSUMER] Infrastructure queue config not found for ${queue}, using default:`, configErr.message);
+            console.warn(`[RabbitMQClient] [mq-client-core] [CONSUMER] Infrastructure queue config not found for ${queue}, will still require it to exist:`, configErr.message);
           }
         } else if (isBusinessQueue) {
           // Business queue - use central config
@@ -1600,28 +1601,45 @@ class RabbitMQClient extends EventEmitter {
         }
       }
       
-      try {
-        console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] About to call assertQueue(${queue}, ${JSON.stringify(queueOptions)})`);
-        
-        // Ensure queue channel is available
-        await this._ensureQueueChannel();
-        if (!this._queueChannel) {
-          throw new Error('Queue channel is not available (connection may be closed)');
+      // Ensure queue channel is available
+      await this._ensureQueueChannel();
+      if (!this._queueChannel) {
+        throw new Error('Queue channel is not available (connection may be closed)');
+      }
+
+      if (isInfraQueue) {
+        // IMPORTANT: Do NOT auto-create infrastructure queues in consumers.
+        // If missing, fail-fast. The owning infra service must recreate on startup.
+        try {
+          this._trackChannelOperation(this._queueChannel, `checkQueue ${queue}`);
+          await this._queueChannel.checkQueue(queue);
+          console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] ✓ Infrastructure queue ${queue} exists (consumer will proceed)`);
+        } catch (checkErr) {
+          if (checkErr.code === 404) {
+            throw new Error(
+              `Infrastructure queue ${queue} is missing. ` +
+              'Ownership rule: infrastructure queues must be created by their owning infrastructure service via initInfrastructureQueues().'
+            );
+          }
+          throw checkErr;
         }
-        
-        this._trackChannelOperation(this._queueChannel, `assertQueue ${queue}`);
-        await this._queueChannel.assertQueue(queue, queueOptions);
-        console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] ✓ Queue ${queue} asserted successfully`);
-      } catch (assertErr) {
-        // If queue exists with different arguments (406), this is a CRITICAL ERROR
-        // We should NOT proceed - the root cause must be fixed
-        if (assertErr.code === 406) {
-          console.error(`[RabbitMQClient] [mq-client-core] [CONSUMER] ✗ CRITICAL: Queue ${queue} exists with different arguments!`);
-          console.error(`[RabbitMQClient] [mq-client-core] [CONSUMER] Error:`, assertErr.message);
-          console.error(`[RabbitMQClient] [mq-client-core] [CONSUMER] Expected options:`, JSON.stringify(queueOptions, null, 2));
-          console.error(`[RabbitMQClient] [mq-client-core] [CONSUMER] This means assertQueue() was called without parameters somewhere else. Root cause must be fixed!`);
-          throw new Error(`Cannot assertQueue ${queue}: queue exists with different arguments. Root cause: assertQueue() was called without parameters. Fix the root cause instead of proceeding.`);
-        } else {
+      } else {
+        // Business queue (or unknown) - assert with canonical parameters to prevent 406 drift.
+        try {
+          console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] About to call assertQueue(${queue}, ${JSON.stringify(queueOptions)})`);
+          this._trackChannelOperation(this._queueChannel, `assertQueue ${queue}`);
+          await this._queueChannel.assertQueue(queue, queueOptions);
+          console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] ✓ Queue ${queue} asserted successfully`);
+        } catch (assertErr) {
+          // If queue exists with different arguments (406), this is a CRITICAL ERROR
+          // We should NOT proceed - the root cause must be fixed
+          if (assertErr.code === 406) {
+            console.error(`[RabbitMQClient] [mq-client-core] [CONSUMER] ✗ CRITICAL: Queue ${queue} exists with different arguments!`);
+            console.error(`[RabbitMQClient] [mq-client-core] [CONSUMER] Error:`, assertErr.message);
+            console.error(`[RabbitMQClient] [mq-client-core] [CONSUMER] Expected options:`, JSON.stringify(queueOptions, null, 2));
+            console.error(`[RabbitMQClient] [mq-client-core] [CONSUMER] This means assertQueue() was called without parameters somewhere else. Root cause must be fixed!`);
+            throw new Error(`Cannot assertQueue ${queue}: queue exists with different arguments. Root cause: assertQueue() was called without parameters. Fix the root cause instead of proceeding.`);
+          }
           // Other error - rethrow
           throw assertErr;
         }
@@ -1663,6 +1681,14 @@ class RabbitMQClient extends EventEmitter {
         if (msg === null) {
           return; // Consumer cancellation
         }
+
+        // IMPORTANT:
+        // `msg` MUST be acked/nacked on the SAME channel instance that delivered it.
+        // During reconnects, `this._consumerChannel` may be replaced while a handler is running.
+        // If we ack/nack a message using a different (new) channel, RabbitMQ will close the channel with:
+        //   406 (PRECONDITION-FAILED) unknown delivery tag
+        // which cascades into "Channel closed" errors across the service.
+        const channelForMsg = this._consumerChannel;
         
         // Structured log: message received
         const msgHeaders = msg.properties?.headers || {};
@@ -1690,7 +1716,23 @@ class RabbitMQClient extends EventEmitter {
           await onMessage(msg);
           // Acknowledge message after successful processing
           if (!noAck) {
-            this._consumerChannel.ack(msg);
+            // Only ack on the original channel instance; if it's gone/closed, do not attempt ack.
+            if (!channelForMsg || channelForMsg.closed) {
+              console.warn('[RabbitMQClient] [mq-client-core] [CONSUMER] Cannot ack - consumer channel is closed/recreated (message will be requeued by broker)');
+              return;
+            }
+            try {
+              channelForMsg.ack(msg);
+            } catch (ackErr) {
+              // If the channel was closed/recreated during processing, delivery tag becomes invalid.
+              // Do NOT send further acks that would close the channel with 406.
+              const m = ackErr && ackErr.message ? ackErr.message : '';
+              if (m.includes('unknown delivery tag') || m.includes('PRECONDITION_FAILED') || m.includes('Channel closed')) {
+                console.warn('[RabbitMQClient] [mq-client-core] [CONSUMER] Ack failed due to invalid delivery tag / closed channel (message delivery will be handled by broker)', { error: m });
+                return;
+              }
+              throw ackErr;
+            }
             // Structured log: message acknowledged
             this._log.output(wfId, 'MSG_ACKED', {
               handler: 'consume',
@@ -1708,9 +1750,9 @@ class RabbitMQClient extends EventEmitter {
         } catch (handlerErr) {
           // Negative acknowledge and requeue by default
           // Check if channel is still valid before nacking
-          if (this._consumerChannel && !this._consumerChannel.closed) {
+          if (channelForMsg && !channelForMsg.closed) {
             try {
-              this._consumerChannel.nack(msg, false, true);
+              channelForMsg.nack(msg, false, true);
             } catch (nackErr) {
               // Channel may have closed during nack - ignore
               console.warn(`[RabbitMQClient] [mq-client-core] Failed to nack message (channel may be closed): ${nackErr.message}`);
@@ -2182,6 +2224,11 @@ class RabbitMQClient extends EventEmitter {
     try {
       this._consumerChannel.ack(msg);
     } catch (err) {
+      const m = err && err.message ? err.message : '';
+      if (m.includes('unknown delivery tag') || m.includes('PRECONDITION_FAILED') || m.includes('Channel closed')) {
+        console.warn('[RabbitMQClient] [mq-client-core] Cannot ack - consumer channel is closed/recreated (delivery tag invalid)', { error: m });
+        return;
+      }
       this.emit('error', err);
       throw err;
     }
@@ -2200,6 +2247,11 @@ class RabbitMQClient extends EventEmitter {
     try {
       this._consumerChannel.nack(msg, false, requeue);
     } catch (err) {
+      const m = err && err.message ? err.message : '';
+      if (m.includes('unknown delivery tag') || m.includes('PRECONDITION_FAILED') || m.includes('Channel closed')) {
+        console.warn('[RabbitMQClient] [mq-client-core] Cannot nack - consumer channel is closed/recreated (delivery tag invalid)', { error: m });
+        return;
+      }
       this.emit('error', err);
       throw err;
     }