@onlineapps/mq-client-core 1.0.7 → 1.0.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/mq-client-core",
-  "version": "1.0.7",
+  "version": "1.0.10",
   "description": "Core MQ client library for RabbitMQ - shared by infrastructure services and connectors",
   "main": "src/index.js",
   "scripts": {

package/src/transports/rabbitmqClient.js

@@ -151,16 +151,26 @@ class RabbitMQClient extends EventEmitter {
     try {
       // Ensure queue exists if publishing directly to queue and using default exchange
       if (!exchange) {
-        // For infrastructure queues, they should already exist with specific arguments
+        // CRITICAL: For infrastructure queues, they should already exist with specific arguments from queueConfig
         // Use queueChannel (regular channel) for checkQueue/assertQueue to avoid RPC reply queue issues
-        // If queue doesn't exist (404), try to create it with default options
+        // If queue doesn't exist (404), we should NOT auto-create it - infrastructure queues must be created explicitly
+        // This prevents creating queues with wrong arguments (no TTL) which causes 406 errors later
         try {
           await this._queueChannel.checkQueue(queue);
           // Queue exists - proceed to publish
         } catch (checkErr) {
-          // If queue doesn't exist (404), create it with default options
+          // If queue doesn't exist (404), this is an ERROR for infrastructure queues
+          // Infrastructure queues (workflow.*, registry.*) must be created explicitly with correct arguments
+          // We should NOT auto-create them here, as we don't have access to queueConfig in mq-client-core
           if (checkErr.code === 404) {
+            // Check if this is an infrastructure queue
+            const isInfraQueue = queue.startsWith('workflow.') || queue.startsWith('registry.');
+            if (isInfraQueue) {
+              throw new Error(`Cannot publish to infrastructure queue ${queue}: queue does not exist. Infrastructure queues must be created explicitly with correct arguments (TTL, max-length, etc.) before publishing.`);
+            }
+            // For non-infrastructure queues, allow auto-creation with default options
             const queueOptions = options.queueOptions || { durable: this._config.durable };
+            console.warn(`[RabbitMQClient] [mq-client-core] [PUBLISH] Auto-creating non-infrastructure queue ${queue} with default options (no TTL). This should be avoided for production.`);
             await this._queueChannel.assertQueue(queue, queueOptions);
           } else {
             // Other error - rethrow
@@ -252,8 +262,25 @@ class RabbitMQClient extends EventEmitter {
       
       console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] Asserting queue ${queue} before consume() at ${new Date().toISOString()}`);
       console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] Queue options:`, JSON.stringify(queueOptions, null, 2));
+      console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] _queueChannel state: exists=${!!this._queueChannel}, closed=${this._queueChannel ? this._queueChannel.closed : 'N/A'}`);
       
+      // CRITICAL: Check if queue already exists with different arguments
+      // This can happen if sendToQueue() or amqplib's consume() auto-created it without TTL
       try {
+        const queueInfo = await this._queueChannel.checkQueue(queue);
+        console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] Queue ${queue} already exists with arguments:`, JSON.stringify(queueInfo.messageCount !== undefined ? { messageCount: queueInfo.messageCount, consumerCount: queueInfo.consumerCount } : queueInfo));
+        // If queue exists, we need to check if arguments match
+        // Note: checkQueue() doesn't return arguments, so we'll try assertQueue() and catch 406
+      } catch (checkErr) {
+        if (checkErr.code === 404) {
+          console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] Queue ${queue} does not exist (404), will be created with options`);
+        } else {
+          console.warn(`[RabbitMQClient] [mq-client-core] [CONSUMER] checkQueue() failed for ${queue}:`, checkErr.message);
+        }
+      }
+      
+      try {
+        console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] About to call assertQueue(${queue}, ${JSON.stringify(queueOptions)})`);
         await this._queueChannel.assertQueue(queue, queueOptions);
         console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] ✓ Queue ${queue} asserted successfully`);
       } catch (assertErr) {
@@ -276,6 +303,26 @@ class RabbitMQClient extends EventEmitter {
         this._channel.prefetch(prefetch);
       }
 
+      // CRITICAL: Log before calling amqplib's consume()
+      // amqplib's consume() may internally call assertQueue() without parameters if queue doesn't exist
+      // This would create queue with default arguments (no TTL), causing 406 errors later
+      console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] About to call amqplib's channel.consume(${queue})`);
+      console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] ⚠ WARNING: amqplib's consume() may internally call assertQueue() WITHOUT parameters if queue doesn't exist`);
+      console.log(`[RabbitMQClient] [mq-client-core] [CONSUMER] ⚠ WARNING: We already asserted queue with correct parameters above - this should prevent auto-creation`);
+      
+      // CRITICAL: Wrap amqplib's channel.consume() to intercept any internal assertQueue() calls
+      // This will help us identify if amqplib is creating the queue without TTL
+      const originalConsume = this._channel.consume.bind(this._channel);
+      const originalAssertQueue = this._channel.assertQueue.bind(this._channel);
+      
+      // Intercept assertQueue() calls to log them
+      this._channel.assertQueue = async function(queueName, options) {
+        console.log(`[RabbitMQClient] [mq-client-core] [INTERCEPT] assertQueue() called for: ${queueName}`);
+        console.log(`[RabbitMQClient] [mq-client-core] [INTERCEPT] Options:`, JSON.stringify(options || {}, null, 2));
+        console.log(`[RabbitMQClient] [mq-client-core] [INTERCEPT] Stack trace:`, new Error().stack.split('\n').slice(1, 10).join('\n'));
+        return originalAssertQueue.call(this, queueName, options);
+      };
+      
       await this._channel.consume(
         queue,
         async (msg) => {