@onlineapps/mq-client-core 1.0.68 → 1.0.70

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/mq-client-core",
-  "version": "1.0.68",
+  "version": "1.0.70",
   "description": "Core MQ client library for RabbitMQ - shared by infrastructure services and connectors",
   "main": "src/index.js",
   "scripts": {

package/src/BaseClient.js

@@ -188,21 +188,9 @@ class BaseClient {
 
     try {
       const consumeStartTime = Date.now();
-      await this._transport.consume(
-        queue,
-        async (msg) => {
-          try {
-            await messageHandler(msg);
-            if (consumeOptions.noAck === false) {
-              await this.ack(msg);
-            }
-          } catch (handlerErr) {
-            // On handler error, nack with requeue: true
-            await this.nack(msg, { requeue: true });
-          }
-        },
-        consumeOptions
-      );
+      // Delegate message lifecycle (ack/nack/requeue) to the transport layer.
+      // BaseClient only provides a broker-agnostic surface; transport decides how to handle handler errors.
+      await this._transport.consume(queue, async (msg) => messageHandler(msg), consumeOptions);
       const consumeEndTime = Date.now();
       console.log(`[BaseClient] [CONSUMER] ✓ consume() completed for queue: ${queue} (took ${consumeEndTime - consumeStartTime}ms)`);
     } catch (err) {

package/src/transports/rabbitmqClient.js

@@ -419,6 +419,7 @@ class RabbitMQClient extends EventEmitter {
    * @throws {Error} If connection or channel creation fails.
    */
   async connect() {
+    let connectTimeoutTimer = null;
     try {
       const rawTarget = this._config.host || this._config.url;
       const heartbeat = this._config.heartbeat ?? 30;
@@ -433,9 +434,11 @@ class RabbitMQClient extends EventEmitter {
         : [{ ...rawTarget, heartbeat, clientProperties: { connection_name: connectionName } }];
 
       const connectPromise = amqp.connect(...connectArgs);
-      let connectTimeoutTimer = null;
       const timeoutPromise = new Promise((_, reject) => {
         connectTimeoutTimer = setTimeout(() => reject(new Error('Connection timeout after 10 seconds')), 10000);
+        if (connectTimeoutTimer && typeof connectTimeoutTimer.unref === 'function') {
+          connectTimeoutTimer.unref();
+        }
       });
       console.log('[RabbitMQClient] Starting connection race...');
       this._connection = await Promise.race([connectPromise, timeoutPromise]);
@@ -537,6 +540,11 @@ class RabbitMQClient extends EventEmitter {
         this._connection = null;
       }
       throw err;
+    } finally {
+      if (connectTimeoutTimer) {
+        clearTimeout(connectTimeoutTimer);
+        connectTimeoutTimer = null;
+      }
     }
   }