@onlineapps/mq-client-core 1.0.4 → 1.0.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/mq-client-core",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "description": "Core MQ client library for RabbitMQ - shared by infrastructure services and connectors",
   "main": "src/index.js",
   "scripts": {

package/src/transports/rabbitmqClient.js

@@ -33,14 +33,24 @@ class RabbitMQClient extends EventEmitter {
 
     this._connection = null;
     this._channel = null;
+    this._queueChannel = null;
   }
 
   /**
    * Getter for channel - provides compatibility with QueueManager
+   * Returns ConfirmChannel for publish operations
    */
   get channel() {
     return this._channel;
   }
+  
+  /**
+   * Getter for queue channel - regular channel for queue operations
+   * Use this for assertQueue, checkQueue to avoid RPC reply queue issues
+   */
+  get queueChannel() {
+    return this._queueChannel || this._channel; // Fallback to main channel if queueChannel not available
+  }
 
   /**
    * Connects to RabbitMQ server and creates a confirm channel.
@@ -56,13 +66,24 @@ class RabbitMQClient extends EventEmitter {
         this.emit('error', new Error('RabbitMQ connection closed unexpectedly'));
       });
 
-      // Use ConfirmChannel to enable publisher confirms
+      // Use ConfirmChannel to enable publisher confirms for publish operations
       this._channel = await this._connection.createConfirmChannel();
       this._channel.on('error', (err) => this.emit('error', err));
       this._channel.on('close', () => {
         // Emit a channel close error
         this.emit('error', new Error('RabbitMQ channel closed unexpectedly'));
       });
+      
+      // Create a separate regular channel for queue operations (assertQueue, checkQueue)
+      // This avoids RPC reply queue issues with ConfirmChannel.assertQueue()
+      this._queueChannel = await this._connection.createChannel();
+      this._queueChannel.on('error', (err) => {
+        // Log but don't emit - queue channel errors are less critical
+        console.warn('[RabbitMQClient] Queue channel error:', err.message);
+      });
+      this._queueChannel.on('close', () => {
+        console.warn('[RabbitMQClient] Queue channel closed');
+      });
     } catch (err) {
       // Cleanup partially created resources
       if (this._connection) {
@@ -82,6 +103,15 @@ class RabbitMQClient extends EventEmitter {
    * @returns {Promise<void>}
    */
   async disconnect() {
+    try {
+      if (this._queueChannel) {
+        await this._queueChannel.close();
+        this._queueChannel = null;
+      }
+    } catch (err) {
+      // Log but don't emit - queue channel errors are less critical
+      console.warn('[RabbitMQClient] Error closing queue channel:', err.message);
+    }
     try {
       if (this._channel) {
         await this._channel.close();
@@ -122,22 +152,23 @@ class RabbitMQClient extends EventEmitter {
       // Ensure queue exists if publishing directly to queue and using default exchange
       if (!exchange) {
         // For infrastructure queues, they should already exist with specific arguments
-        // Try to check if queue exists first, if not, create with default options
-        // If it exists with different args (406), use it as-is
-        const queueOptions = options.queueOptions || { durable: this._config.durable };
+        // Use queueChannel (regular channel) for checkQueue/assertQueue to avoid RPC reply queue issues
+        // If queue doesn't exist (404), try to create it with default options
         try {
-          await this._channel.assertQueue(queue, queueOptions);
-        } catch (assertErr) {
-          // If queue exists with different arguments (406), use it as-is
-          if (assertErr.code === 406) {
-            console.warn(`[RabbitMQClient] Queue ${queue} exists with different arguments, using as-is:`, assertErr.message);
-            // Don't try to re-assert - just proceed to publish
+          await this._queueChannel.checkQueue(queue);
+          // Queue exists - proceed to publish
+        } catch (checkErr) {
+          // If queue doesn't exist (404), create it with default options
+          if (checkErr.code === 404) {
+            const queueOptions = options.queueOptions || { durable: this._config.durable };
+            await this._queueChannel.assertQueue(queue, queueOptions);
           } else {
             // Other error - rethrow
-            throw assertErr;
+            throw checkErr;
           }
         }
-        this._channel.sendToQueue(queue, buffer, { persistent, headers, routingKey });
+        // Publish to queue using ConfirmChannel (for publisher confirms)
+        this._channel.sendToQueue(queue, buffer, { persistent, headers });
       } else {
         // If exchange is specified, assert exchange and publish to it
         await this._channel.assertExchange(exchange, 'direct', { durable: this._config.durable });
@@ -172,12 +203,13 @@ class RabbitMQClient extends EventEmitter {
       // Skip assertQueue for reply queues (they're already created with specific settings)
       // Reply queues start with 'rpc.reply.' and are created as non-durable
       if (!queue.startsWith('rpc.reply.')) {
+        // Use queueChannel (regular channel) for queue operations to avoid RPC reply queue issues
         // Simple queue assertion - infrastructure services should ensure queues exist
         // If queue doesn't exist, assertQueue will create it with default options
         // If it exists with different args (406), log warning and proceed
         const queueOptions = options.queueOptions || { durable };
         try {
-          await this._channel.assertQueue(queue, queueOptions);
+          await this._queueChannel.assertQueue(queue, queueOptions);
         } catch (assertErr) {
           // If queue exists with different arguments (406), use it as-is
           if (assertErr.code === 406) {