@onlineapps/infrastructure-tools 1.0.53 → 1.0.55

package/README.md

@@ -99,10 +99,10 @@ await storage.putObject('workflow', 'path/to/file', buffer);
 Waits for all infrastructure services to be reported as healthy by Registry.
 
 **Options:**
-- `redisUrl` (string): Redis URL (default: from ENV or `redis://api_node_cache:6379`)
+- `redisUrl` (string): Redis URL
 - `maxWait` (number): Maximum wait time in ms (default: 300000 = 5 minutes)
 - `checkInterval` (number): Check interval in ms (default: 5000 = 5 seconds)
-- `logger` (Object): Logger instance (default: console)
+- `logger` (Object|Function): **Required** logger instance (or function). No implicit console fallback.
 
 **Returns:** `Promise<boolean>`
 
@@ -113,7 +113,7 @@ Initializes infrastructure queues with correct parameters from `queueConfig`.
 **Options:**
 - `queues` (Array<string>): Specific queues to create (default: all infrastructure queues)
 - `connection` (Object): RabbitMQ connection (for channel recreation)
-- `logger` (Object): Logger instance (default: console)
+- `logger` (Object): Logger instance (required)
 - `queueConfig` (Object): Queue config instance (default: from mq-client-core)
 - `serviceName` (string): Used in queue mismatch alerts (default: `unknown-service`)
 - `alertOnMismatch` (boolean): Disable automatic 406 alerts (default: `true`)
@@ -130,7 +130,7 @@ Creates a health publisher instance with custom publish function.
 - `publishFunction` (Function): Function to publish message (required)
 - `getHealthData` (Function): Function to get health data (required)
 - `config` (Object): Configuration with `infrastructureHealth` settings
-- `logger` (Object): Logger instance (default: console)
+- `logger` (Object): **Required** logger instance (no implicit console fallback)
 
 **Returns:** Health publisher instance with `start()`, `stop()`, `publishNow()` methods
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/infrastructure-tools",
-  "version": "1.0.53",
+  "version": "1.0.55",
   "description": "Infrastructure orchestration utilities for OA Drive infrastructure services (health tracking, queue initialization, service discovery)",
   "main": "src/index.js",
   "scripts": {
@@ -18,8 +18,8 @@
   "author": "OnlineApps",
   "license": "MIT",
   "dependencies": {
-    "@onlineapps/mq-client-core": "1.0.67",
-    "@onlineapps/service-common": "1.0.12",
+    "@onlineapps/mq-client-core": "1.0.68",
+    "@onlineapps/service-common": "1.0.13",
     "@onlineapps/storage-core": "1.0.12",
     "uuid": "^9.0.1",
     "@onlineapps/infra-logger": "^1.0.0"

package/src/health/healthPublisher.js

@@ -39,9 +39,6 @@ function createHealthPublisher(options) {
     logger: customLogger
   } = options;
 
-  // Use shared logger utility for consistent logging
-  const logger = createLogger(customLogger);
-
   if (!serviceName) {
     throw new Error('serviceName is required');
   }
@@ -52,6 +49,9 @@ function createHealthPublisher(options) {
     throw new Error('getHealthData must be a function');
   }
 
+  // Use shared logger utility for consistent logging (strict - no fallbacks).
+  const logger = createLogger(customLogger);
+
   let healthCheckInterval = null;
   let isPublishing = false;
 

package/src/index.js

@@ -50,13 +50,11 @@ const {
   createBaseClientAdapter,
   createAmqplibAdapter
 } = require('./health/healthPublisher');
-const { createLogger } = require('./utils/logger');
 const { sendQueueMismatchAlert } = require('./monitoring/queueMismatchReporter');
 
 module.exports = {
   // MQ Client Core (re-exported for convenience)
   BaseClient,
-  MQClient: BaseClient, // Alias for compatibility
   queueConfig,
   
   // Service Common utilities (re-exported - infrastructure services should use infrastructure-tools, not service-common directly)
@@ -90,8 +88,6 @@ module.exports = {
   createAmqplibAdapter,
   
   // Logger utilities
-  // createLogger - legacy logger wrapper (for backward compatibility)
-  createLogger,
   // createInfraLogger - structured logging from @onlineapps/infra-logger (preferred)
   createInfraLogger,
   

package/src/utils/logger.js

@@ -3,21 +3,27 @@
 /**
  * logger.js
  *
- * Provides a simple abstraction over console or a custom logger.
- * If the user passes a custom logger object with methods { info, warn, error, debug },
- * these are used; otherwise console.* is used as fallback.
- * 
- * Similar to conn-infra-mq logger utility for consistency across infrastructure libraries.
+ * Provides a strict logger normalization helper.
+ *
+ * NO FALLBACKS: callers must pass a logger explicitly. No implicit console fallback.
  */
 
 function createLogger(customLogger) {
   const methods = ['info', 'warn', 'error', 'debug'];
+
+  if (!customLogger) {
+    throw new Error('[infrastructure-tools][logger] Missing dependency - logger is required (no console fallback).');
+  }
+
+  // Allow passing console directly
+  if (customLogger === console) {
+    return console;
+  }
+
   if (
-    customLogger &&
     typeof customLogger === 'object' &&
     methods.every((fn) => typeof customLogger[fn] === 'function')
   ) {
-    // Wrap custom logger to ensure consistent signature
     return {
       info: (...args) => customLogger.info(...args),
       warn: (...args) => customLogger.warn(...args),
@@ -26,13 +32,9 @@ function createLogger(customLogger) {
     };
   }
 
-  // Fallback to console
-  return {
-    info: (...args) => console.log('[INFO]', ...args),
-    warn: (...args) => console.warn('[WARN]', ...args),
-    error: (...args) => console.error('[ERROR]', ...args),
-    debug: (...args) => console.debug('[DEBUG]', ...args),
-  };
+  throw new Error(
+    '[infrastructure-tools][logger] Invalid logger - Expected {info,warn,error,debug} functions (or console).'
+  );
 }
 
 module.exports = {