@onlineapps/cookbook-router 1.0.34 → 1.0.36

package/README.md

@@ -207,7 +207,7 @@ The router distinguishes between retryable and non-retryable errors:
 
 - `@onlineapps/cookbook-core` - Core parsing and validation
 - `@onlineapps/cookbook-executor` - Workflow execution engine
-<!-- cookbook-transformer removed in operations.json-first migration; see /api/docs/standards/operations-registry-contract.md -->
+<!-- cookbook-transformer removed in operations.json-first migration; see /api/docs/biz/30-operations/registration-wire.md -->
 - `@onlineapps/connector-cookbook` - Full-featured wrapper
 
 ## License

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/cookbook-router",
-  "version": "1.0.34",
+  "version": "1.0.36",
   "description": "Message routing for cookbook workflows - handles service discovery and queue routing",
   "main": "src/index.js",
   "scripts": {
@@ -18,11 +18,7 @@
   ],
   "author": "OnlineApps",
   "license": "PROPRIETARY",
-  "dependencies": {
-    "@onlineapps/conn-infra-mq": "1.1.70",
-    "@onlineapps/conn-orch-registry": "1.2.1",
-    "@onlineapps/cookbook-core": "2.1.16"
-  },
+  "dependencies": {},
   "devDependencies": {
     "jest": "^29.7.0"
   },

package/src/queueManager.js

@@ -129,8 +129,19 @@ class QueueManager {
         this.mqClient.ack(message);
       } catch (error) {
         logger.error(`Error processing message from ${queueName}:`, error);
-        // Reject message without requeue
-        this.mqClient.nack(message, false, false);
+        // Reject message without requeue.
+        //
+        // The signature is `nack(msg, options)`, NOT amqplib's raw
+        // `nack(msg, allUpTo, requeue)`. This call read
+        // `nack(message, false, false)` until 2026-08-28: `false` arrived as
+        // `options`, `false.requeue` is `undefined`, and the client defaults an
+        // undefined `requeue` to TRUE
+        // (`@onlineapps/mq-client-core/src/transports/rabbitmqClient.js:2252`).
+        // Every message whose handler threw was therefore requeued forever
+        // instead of being discarded — the exact opposite of what the line above
+        // it claimed. Measured against the live broker: one publish produced 5
+        // deliveries in 1.2 s and kept going.
+        this.mqClient.nack(message, { requeue: false });
       }
     };