@onlineapps/content-resolver 2.0.0 → 3.0.0-rc.1

package/README.md

@@ -32,7 +32,7 @@ const resolver = new ContentResolver({
     accessKey: 'minioadmin',
     secretKey: 'minioadmin'
   },
-  logger  // required - the constructor throws without a logger exposing warn()
+  logger  // required - the constructor throws unless it exposes info/warn/error/debug
 });
 
 // Resolve reference to content
@@ -81,7 +81,7 @@ exports.processDocument = async (input, context = {}) => {
 |--------|------|---------|-------------|
 | `threshold` | number | 16384 | Size threshold in bytes |
 | `storage` | Object | env-based | Storage connector config |
-| `logger` | Object | **required** | Logger instance — must expose `warn()`. The constructor throws without it (`src/index.js`); there is no `console` default. |
+| `logger` | Object | **required** | Logger instance — must expose `info()`, `warn()`, `error()` and `debug()`, all four as functions. The constructor throws without it, and names the missing method (`src/index.js`); there is no `console` default. The four are what `@onlineapps/conn-base-storage` demands of the connector this class builds, so validating fewer here only moved the failure later (owner confirmation `connector-logger-contract` 001). |
 
 ### Input contract
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/content-resolver",
-  "version": "2.0.0",
+  "version": "3.0.0-rc.1",
   "description": "Automatic conversion between text content and storage references with Content Descriptor pattern",
   "main": "src/index.js",
   "scripts": {
@@ -18,7 +18,7 @@
   "author": "OnlineApps",
   "license": "ISC",
   "dependencies": {
-    "@onlineapps/conn-base-storage": "2.0.0",
+    "@onlineapps/conn-base-storage": "3.0.0",
     "@onlineapps/runtime-config": "1.0.3"
   },
   "devDependencies": {

package/src/index.js

@@ -17,6 +17,10 @@ const runtimeCfg = require('./config');
 // Backward-compatible constant export (module-owned default, not ENV override)
 const DEFAULT_THRESHOLD = DEFAULTS.thresholdBytes;
 
+// The logger methods this module and the storage connector it builds both
+// require — the order is the order the error message lists them in.
+const LOGGER_METHODS = ['info', 'warn', 'error', 'debug'];
+
 // Reference patterns
 const MINIO_REF_PATTERN = /^minio:\/\/([^/]+)\/(.+)$/;
 const INTERNAL_REF_PATTERN = /^internal:\/\/storage\/(.+)$/;
@@ -178,14 +182,35 @@ class ContentResolver {
    * @param {Object} options - Configuration options
    * @param {number} [options.threshold=16384] - Size threshold in bytes (default 16KB)
    * @param {Object} [options.storage] - Storage connector config or instance
-   * @param {Object} [options.logger] - Logger instance
+   * @param {Object} options.logger - REQUIRED. Logger with info/warn/error/debug.
    */
   constructor(options = {}) {
     const resolved = runtimeCfg.resolve(options);
     this.threshold = resolved.threshold;
-    if (!options.logger || typeof options.logger.warn !== 'function') {
-      throw new Error('[ContentResolver] Logger is required — Expected object with warn() method');
+    // The logger is INJECTED and validated in full, HERE. Until 2026-09-03 only
+    // `warn()` was checked, while the same object was handed to
+    // `StorageConnector`, which demands all four (conn-base-storage 3.0.0
+    // src/index.js:89-95). A three-method logger therefore constructed fine and
+    // failed later, on the first storage access — delayed validation, which
+    // architecture-principles.md §4 forbids. Owner confirmation:
+    // docs/governance/confirmations/connector-logger-contract.md 001.
+    if (!options.logger) {
+      throw new Error(
+        '[ContentResolver] logger is required - Expected: a logger with info/warn/error/debug, '
+        + 'so the resolver and the connector it builds write where the service writes. '
+        + 'Fix: pass options.logger (e.g. the logger your service already built).'
+      );
+    }
+
+    const missing = LOGGER_METHODS.filter((method) => typeof options.logger[method] !== 'function');
+    if (missing.length > 0) {
+      throw new Error(
+        '[ContentResolver] logger is incomplete - Expected: info, warn, error, debug as functions; '
+        + `missing: ${missing.join(', ')}. `
+        + 'Fix: pass a logger implementing all four.'
+      );
     }
+
     this.logger = options.logger;
     
     // Storage can be passed as instance or config (no fallbacks - fail-fast)
@@ -220,7 +245,10 @@ class ContentResolver {
       if (config.endPoint) {
         config.endPoint = config.endPoint.replace(/^https?:\/\//, '');
       }
-      this.storage = new StorageConnector(config);
+      // The connector requires an injected logger (conn-base-storage 3.0.0,
+      // architecture-principles.md §1). ContentResolver already fail-fasts on
+      // its own logger, so it has one to give.
+      this.storage = new StorageConnector({ ...config, logger: this.logger });
       await this.storage.initialize();
     }
     return this.storage;