@onlineapps/content-resolver 1.1.6 → 1.1.10

package/package.json

@@ -1,10 +1,10 @@
 {
   "name": "@onlineapps/content-resolver",
-  "version": "1.1.6",
+  "version": "1.1.10",
   "description": "Automatic conversion between text content and storage references with Content Descriptor pattern",
   "main": "src/index.js",
   "scripts": {
-    "test": "jest"
+    "test": "jest --passWithNoTests"
   },
   "keywords": [
     "content",
@@ -16,9 +16,11 @@
   "author": "OnlineApps",
   "license": "ISC",
   "dependencies": {
-    "@onlineapps/conn-base-storage": "^1.0.0"
+    "@onlineapps/conn-base-storage": "1.0.4",
+    "@onlineapps/runtime-config": "1.0.2"
   },
   "peerDependencies": {
     "@onlineapps/conn-base-storage": "^1.0.0"
-  }
+  },
+  "devDependencies": {}
 }

package/src/config.js

@@ -0,0 +1,35 @@
+'use strict';
+
+/**
+ * Runtime configuration schema for @onlineapps/content-resolver.
+ *
+ * Uses @onlineapps/runtime-config for unified priority:
+ * 1. Explicit config (passed to constructor)
+ * 2. Environment variable
+ * 3. Module-owned defaults (from ./defaults.js)
+ *
+ * IMPORTANT: MinIO topology is FAIL-FAST (no defaults).
+ */
+
+const { createRuntimeConfig } = require('@onlineapps/runtime-config');
+const DEFAULTS = require('./defaults');
+
+const runtimeCfg = createRuntimeConfig({
+  defaults: DEFAULTS,
+  schema: {
+    threshold: { env: 'CONTENT_RESOLVER_THRESHOLD', defaultKey: 'thresholdBytes', type: 'number' },
+
+    // MinIO topology (FAIL-FAST)
+    endPoint: { env: 'MINIO_ENDPOINT', required: true },
+    port: { env: 'MINIO_PORT', required: true, type: 'number' },
+    accessKey: { env: 'MINIO_ACCESS_KEY', required: true },
+    secretKey: { env: 'MINIO_SECRET_KEY', required: true },
+    useSSL: { env: 'MINIO_USE_SSL', defaultKey: 'useSSL', type: 'boolean' },
+
+    defaultBucket: { env: 'MINIO_DEFAULT_BUCKET', defaultKey: 'defaultBucket' },
+  }
+});
+
+module.exports = runtimeCfg;
+
+

package/src/defaults.js

@@ -0,0 +1,15 @@
+'use strict';
+
+/**
+ * Module-owned defaults for @onlineapps/content-resolver.
+ *
+ * NOTE: Infrastructure topology (MinIO endpoint/credentials) has NO defaults.
+ */
+
+module.exports = {
+  thresholdBytes: 16 * 1024,
+  defaultBucket: 'workflow',
+  useSSL: false,
+};
+
+

package/src/index.js

@@ -11,9 +11,11 @@
 
 const StorageConnector = require('@onlineapps/conn-base-storage');
 const crypto = require('crypto');
+const DEFAULTS = require('./defaults');
+const runtimeCfg = require('./config');
 
-// Default threshold: 16KB (16384 bytes)
-const DEFAULT_THRESHOLD = 16 * 1024;
+// Backward-compatible constant export (module-owned default, not ENV override)
+const DEFAULT_THRESHOLD = DEFAULTS.threshold;
 
 // Reference patterns
 const MINIO_REF_PATTERN = /^minio:\/\/([^/]+)\/(.+)$/;
@@ -88,7 +90,7 @@ function parseReference(ref) {
   const internalMatch = ref.match(INTERNAL_REF_PATTERN);
   if (internalMatch) {
     // Internal references use default bucket
-    return { bucket: 'workflow', path: internalMatch[1] };
+    return { bucket: runtimeCfg.get('defaultBucket'), path: internalMatch[1] };
   }
   
   return null;
@@ -106,7 +108,8 @@ class ContentResolver {
    * @param {Object} [options.logger] - Logger instance
    */
   constructor(options = {}) {
-    this.threshold = options.threshold || DEFAULT_THRESHOLD;
+    const resolved = runtimeCfg.resolve(options);
+    this.threshold = resolved.threshold;
     this.logger = options.logger || console;
     
     // Storage can be passed as instance or config (no fallbacks - fail-fast)
@@ -117,26 +120,14 @@ class ContentResolver {
       this.storageConfig = options.storage;
       this.storage = null;
     } else {
-      // Must have env variables if no config passed
-      if (!process.env.MINIO_HOST) {
-        throw new Error('[ContentResolver] Missing required: MINIO_HOST env or options.storage');
-      }
-      if (!process.env.MINIO_PORT) {
-        throw new Error('[ContentResolver] Missing required: MINIO_PORT env or options.storage');
-      }
-      if (!process.env.MINIO_ACCESS_KEY) {
-        throw new Error('[ContentResolver] Missing required: MINIO_ACCESS_KEY env or options.storage');
-      }
-      if (!process.env.MINIO_SECRET_KEY) {
-        throw new Error('[ContentResolver] Missing required: MINIO_SECRET_KEY env or options.storage');
-      }
+      // Must have runtime config (resolved from env) if no explicit storage config passed
       this.storageConfig = {
-        endPoint: process.env.MINIO_HOST,
-        port: parseInt(process.env.MINIO_PORT),
-        useSSL: false,
-        accessKey: process.env.MINIO_ACCESS_KEY,
-        secretKey: process.env.MINIO_SECRET_KEY,
-        defaultBucket: 'workflow'
+        endPoint: resolved.endPoint,
+        port: resolved.port,
+        useSSL: resolved.useSSL,
+        accessKey: resolved.accessKey,
+        secretKey: resolved.secretKey,
+        defaultBucket: resolved.defaultBucket
       };
       this.storage = null;
     }