npm - @onlineapps/conn-orch-validator - Versions diffs - 2.0.32 → 2.0.33 - Mend

@onlineapps/conn-orch-validator 2.0.32 → 2.0.33

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (6) hide show

package/package.json +1 -1
package/src/CookbookTestRunner.js +16 -4
package/src/ServiceReadinessValidator.js +32 -49
package/src/TestOrchestrator.js +9 -3
package/src/ValidationOrchestrator.js +9 -5
package/src/helpers/createServiceReadinessTests.js +1 -1

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/conn-orch-validator",
-  "version": "2.0.32",
+  "version": "2.0.33",
   "description": "Validation orchestrator for OA Drive microservices - coordinates validation across all layers (base, infra, orch, business)",
   "main": "src/index.js",
   "scripts": {

package/src/CookbookTestRunner.js CHANGED Viewed

@@ -14,12 +14,24 @@ const { resolveHeaders } = require('./utils/resolveHeaders');
  */
 class CookbookTestRunner {
   constructor(options = {}) {
+    if (!options.serviceName) {
+      throw new Error('[CookbookTestRunner] serviceName is required');
+    }
+    if (!options.serviceUrl) {
+      throw new Error('[CookbookTestRunner] serviceUrl is required');
+    }
+    if (!options.logger || typeof options.logger.warn !== 'function') {
+      throw new Error('[CookbookTestRunner] Logger is required — Expected object with warn() method');
+    }
     this.serviceName = options.serviceName;
-    this.serviceUrl = options.serviceUrl || 'http://127.0.0.1:3000';
+    this.serviceUrl = options.serviceUrl;
     this.servicePath = options.servicePath;
-    this.mockInfrastructure = options.mockInfrastructure !== false; // default true
-    this.timeout = options.timeout || 30000;
-    this.logger = options.logger || console;
+    this.mockInfrastructure = options.mockInfrastructure !== false;
+    this.timeout = options.timeout;
+    if (!this.timeout || typeof this.timeout !== 'number' || this.timeout <= 0) {
+      throw new Error('[CookbookTestRunner] timeout is required — Expected positive number (ms)');
+    }
+    this.logger = options.logger;
     // Initialize mocked infrastructure
     if (this.mockInfrastructure) {

package/src/ServiceReadinessValidator.js CHANGED Viewed

@@ -12,8 +12,11 @@ const { resolveHeaders } = require('./utils/resolveHeaders');
  */
 class ServiceReadinessValidator {
   constructor(options = {}) {
+    if (!options.logger || typeof options.logger.warn !== 'function') {
+      throw new Error('[ServiceReadinessValidator] Logger is required — Expected object with warn() method');
+    }
     this.validator = new ServiceValidator(options);
-    this.logger = options.logger || console;
+    this.logger = options.logger;
     // Readiness checks: core (80 points) + optional (20 points) = 100 points max
     // Core checks ALWAYS run, optional checks run if testCookbook/registry provided
@@ -347,64 +350,44 @@ class ServiceReadinessValidator {
   }
   /**
-   * Generate test input based on operation input schema
-   * Supports Content Descriptor types (content, file) with proper test values
+   * Generate test input based on operation input schema.
+   *
+   * Resolution order per field: example > default > enum[0]
+   * If none found for a required field, throws with actionable message.
+   *
+   * Contract: every required field in operations.json MUST have 'example' or 'default'.
+   * See: docs/standards/validation-probe-contract.md
    */
   generateTestInput(inputSchema) {
     const testData = {};
     for (const [fieldName, fieldSpec] of Object.entries(inputSchema)) {
-      if (fieldSpec.required) {
-        // Generate appropriate test value based on type
-        switch (fieldSpec.type) {
-          case 'string':
-            testData[fieldName] = fieldSpec.default || 'Test';
-            break;
-          case 'number':
-            testData[fieldName] = fieldSpec.default || 0;
-            break;
-          case 'boolean':
-            testData[fieldName] = fieldSpec.default || false;
-            break;
-          case 'array':
-            testData[fieldName] = fieldSpec.default || [];
-            break;
-          case 'object':
-            testData[fieldName] = fieldSpec.default || {};
-            break;
-          // Content Descriptor types - generate valid test content
-          case 'content':
-            // Generate content based on field name hints
-            if (fieldName.toLowerCase().includes('html')) {
-              testData[fieldName] = fieldSpec.default || '<html><body><h1>Test Validation</h1><p>Auto-generated test content.</p></body></html>';
-            } else if (fieldName.toLowerCase().includes('markdown') || fieldName.toLowerCase().includes('md')) {
-              testData[fieldName] = fieldSpec.default || '# Test Validation\n\nAuto-generated test content.';
-            } else {
-              testData[fieldName] = fieldSpec.default || 'Test content for validation';
-            }
-            break;
-          case 'file':
-            // For file types, generate a VALID Content Descriptor object (type=file)
-            // This keeps endpoint checks predictable and avoids service-specific file upload flows.
-            testData[fieldName] = fieldSpec.default || {
-              _descriptor: true,
-              type: 'file',
-              storage_ref: 'minio://test/validation/placeholder.txt',
-              filename: 'placeholder.txt',
-              content_type: 'text/plain',
-              size: 1,
-              fingerprint: 'test-fingerprint'
-            };
-            break;
-          default:
-            testData[fieldName] = null;
-        }
-      }
+      if (!fieldSpec.required) continue;
+      const value = this._resolveTestValue(fieldName, fieldSpec);
+      testData[fieldName] = value;
     }
     return testData;
   }
+  /**
+   * Resolve a single test value for a required input field.
+   * Throws if no value can be determined — forces service authors to provide examples.
+   * @private
+   */
+  _resolveTestValue(fieldName, fieldSpec) {
+    if (fieldSpec.example !== undefined) return fieldSpec.example;
+    if (fieldSpec.default !== undefined) return fieldSpec.default;
+    if (Array.isArray(fieldSpec.enum) && fieldSpec.enum.length > 0) return fieldSpec.enum[0];
+    throw new Error(
+      `[ServiceReadinessValidator] No test value for required field '${fieldName}' ` +
+      `(type: ${fieldSpec.type}) — Add 'example' or 'default' to operations.json input schema. ` +
+      `See: docs/standards/validation-probe-contract.md`
+    );
+  }
   /**
    * Get recommendation based on results
    */

package/src/TestOrchestrator.js CHANGED Viewed

@@ -17,8 +17,14 @@ class TestOrchestrator {
     this.service = options.service;
     this.serviceName = options.serviceName;
     this.openApiSpec = options.openApiSpec;
-    this.logger = options.logger || console;
-    this.integrationConfig = options.integrationConfig || {};
+    if (!options.logger || typeof options.logger.warn !== 'function') {
+      throw new Error('[TestOrchestrator] Logger is required — Expected object with warn() method');
+    }
+    this.logger = options.logger;
+    if (!options.integrationConfig) {
+      throw new Error('[TestOrchestrator] integrationConfig is required');
+    }
+    this.integrationConfig = options.integrationConfig;
     // Test configuration
     this.testLevels = {
@@ -227,7 +233,7 @@ class TestOrchestrator {
       const config = this.getIntegrationTestConfig();
       // Run readiness validator (uses real endpoints)
-      const validator = new ServiceReadinessValidator();
+      const validator = new ServiceReadinessValidator({ logger: this.logger });
       const readinessTest = await validator.validateReadiness({
         name: this.serviceName,
         url: config.serviceUrl,

package/src/ValidationOrchestrator.js CHANGED Viewed

@@ -22,11 +22,13 @@ class ValidationOrchestrator {
     this.serviceName = options.serviceName;
     this.serviceVersion = options.serviceVersion;
     this.serviceUrl = options.serviceUrl; // NEW: Service URL for HTTP calls
-    this.logger = options.logger || console;
+    if (!options.logger || typeof options.logger.warn !== 'function') {
+      throw new Error('[ValidationOrchestrator] Logger is required — Expected object with warn() method');
+    }
+    this.logger = options.logger;
-    // Validate required options
     if (!this.serviceUrl) {
-      throw new Error('serviceUrl is required for ValidationOrchestrator');
+      throw new Error('[ValidationOrchestrator] serviceUrl is required');
     }
     // Paths — prefer new config/service/ layout, fall back to legacy conn-config/
@@ -39,11 +41,13 @@ class ValidationOrchestrator {
     // Validators
     this.structureValidator = new ServiceStructureValidator(this.serviceRoot);
-    this.readinessValidator = new ServiceReadinessValidator();
+    this.readinessValidator = new ServiceReadinessValidator({ logger: this.logger });
     this.cookbookRunner = new CookbookTestRunner({
       servicePath: this.serviceRoot,
       serviceName: this.serviceName,
-      serviceUrl: this.serviceUrl // Pass serviceUrl to CookbookTestRunner
+      serviceUrl: this.serviceUrl,
+      logger: this.logger,
+      timeout: 30000
     });
   }

package/src/helpers/createServiceReadinessTests.js CHANGED Viewed

@@ -138,7 +138,7 @@ function createServiceReadinessTests(testsDir, options = {}) {
       }
       // Run readiness validation
-      const validator = new ServiceReadinessValidator();
+      const validator = new ServiceReadinessValidator({ logger: console });
       const result = await validator.validateReadiness({
         name: serviceName,
         version: serviceVersion,