@onlineapps/conn-orch-validator 2.0.13 → 2.0.15

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/conn-orch-validator",
-  "version": "2.0.13",
+  "version": "2.0.15",
   "description": "Validation orchestrator for OA Drive microservices - coordinates validation across all layers (base, infra, orch, business)",
   "main": "src/index.js",
   "scripts": {
@@ -22,6 +22,7 @@
   "license": "PROPRIETARY",
   "dependencies": {
     "@onlineapps/service-validator-core": "^1.0.4",
+    "@onlineapps/runtime-config": "1.0.2",
     "ajv": "^8.12.0",
     "ajv-formats": "^2.1.1",
     "amqplib": "^0.10.9",

package/src/ServiceReadinessValidator.js

@@ -369,8 +369,17 @@ class ServiceReadinessValidator {
             }
             break;
           case 'file':
-            // For file types, generate a placeholder - actual file handling depends on implementation
-            testData[fieldName] = fieldSpec.default || 'minio://test/validation/placeholder.txt';
+            // For file types, generate a VALID Content Descriptor object (type=file)
+            // This keeps endpoint checks predictable and avoids service-specific file upload flows.
+            testData[fieldName] = fieldSpec.default || {
+              _descriptor: true,
+              type: 'file',
+              storage_ref: 'minio://test/validation/placeholder.txt',
+              filename: 'placeholder.txt',
+              content_type: 'text/plain',
+              size: 1,
+              fingerprint: 'test-fingerprint'
+            };
             break;
           default:
             testData[fieldName] = null;

package/src/ServiceValidator.js

@@ -184,13 +184,21 @@ class ServiceValidator {
       case 'object':
         const obj = {};
         if (schema.properties) {
-          Object.entries(schema.properties).forEach(([key, prop]) => {
+          const entries = Object.entries(schema.properties);
+          entries.forEach(([key, prop]) => {
             if (schema.required && schema.required.includes(key)) {
               obj[key] = this.generateTestValue(prop);
             } else if (Math.random() > 0.5) {
               obj[key] = this.generateTestValue(prop);
             }
           });
+
+          // If schema has properties but nothing was picked (e.g., no required fields and randomness skipped),
+          // pick the first property to keep requests deterministic and non-empty.
+          if (Object.keys(obj).length === 0 && entries.length > 0) {
+            const [firstKey, firstSchema] = entries[0];
+            obj[firstKey] = this.generateTestValue(firstSchema);
+          }
         }
         return obj;
 

package/src/TestOrchestrator.js

@@ -4,6 +4,7 @@ const ServiceValidator = require('./ServiceValidator');
 const WorkflowTestRunner = require('./WorkflowTestRunner');
 const ServiceTestHarness = require('./ServiceTestHarness');
 const ServiceReadinessValidator = require('./ServiceReadinessValidator');
+const runtimeCfg = require('./config');
 
 /**
  * TestOrchestrator - Three-tier testing strategy
@@ -17,6 +18,7 @@ class TestOrchestrator {
     this.serviceName = options.serviceName;
     this.openApiSpec = options.openApiSpec;
     this.logger = options.logger || console;
+    this.integrationConfig = options.integrationConfig || {};
 
     // Test configuration
     this.testLevels = {
@@ -628,11 +630,12 @@ class TestOrchestrator {
 
   getIntegrationTestConfig() {
     // Get configuration for integration tests
+    const resolved = runtimeCfg.resolve(this.integrationConfig);
     return {
-      serviceUrl: process.env.TEST_SERVICE_URL || `http://localhost:${process.env.PORT || 3000}`,
-      mqUrl: process.env.TEST_MQ_URL || process.env.RABBITMQ_URL,
-      registryUrl: process.env.TEST_REGISTRY_URL || 'http://localhost:8080',
-      storageUrl: process.env.TEST_STORAGE_URL || process.env.MINIO_URL,
+      serviceUrl: resolved.serviceUrl,
+      mqUrl: resolved.mqUrl,
+      registryUrl: resolved.registryUrl,
+      storageUrl: resolved.storageUrl,
       registry: null, // Would be real registry instance
       mqClient: null  // Would be real MQ client instance
     };

package/src/ValidationOrchestrator.js

@@ -117,7 +117,9 @@ class ValidationOrchestrator {
 
       return true;
     } catch (error) {
-      console.error(`[ValidationOrchestrator] Proof validation error: ${error.message}`);
+      if (this.logger && typeof this.logger.error === 'function') {
+        this.logger.error(`[ValidationOrchestrator] Proof validation error: ${error.message}`);
+      }
       return false;
     }
   }

package/src/config.js

@@ -0,0 +1,29 @@
+'use strict';
+
+/**
+ * Runtime configuration schema for @onlineapps/conn-orch-validator.
+ *
+ * Uses @onlineapps/runtime-config for unified priority:
+ * 1. Explicit config (passed to TestOrchestrator options)
+ * 2. Environment variable
+ * 3. Module-owned defaults (none for topology)
+ *
+ * IMPORTANT: Integration test topology is FAIL-FAST (no defaults).
+ */
+
+const { createRuntimeConfig } = require('@onlineapps/runtime-config');
+const DEFAULTS = require('./defaults');
+
+const runtimeCfg = createRuntimeConfig({
+  defaults: DEFAULTS,
+  schema: {
+    serviceUrl: { env: 'TEST_SERVICE_URL', required: true },
+    mqUrl: { env: 'TEST_MQ_URL', required: true },
+    registryUrl: { env: 'TEST_REGISTRY_URL', required: true },
+    storageUrl: { env: 'TEST_STORAGE_URL', required: true },
+  }
+});
+
+module.exports = runtimeCfg;
+
+

package/src/defaults.js

@@ -0,0 +1,11 @@
+'use strict';
+
+/**
+ * Module-owned defaults for @onlineapps/conn-orch-validator.
+ *
+ * NOTE: Integration test topology (URLs) is FAIL-FAST and has NO defaults.
+ */
+
+module.exports = {};
+
+

package/src/mocks/MockMQClient.js

@@ -53,6 +53,33 @@ class MockMQClient {
     this.queues[queue].push(messageWrapper);
     this.publishedMessages.push({ queue, message, options, timestamp: Date.now() });
 
+    // Auto-reply simulation for workflow task requests:
+    // When a task is published to service.*.request, publish a deterministic response
+    // to workflow.<workflow_id>.response so WorkflowTestRunner unit tests can run
+    // end-to-end with mocked MQ.
+    if (
+      typeof queue === 'string' &&
+      queue.startsWith('service.') &&
+      queue.endsWith('.request') &&
+      message &&
+      typeof message === 'object' &&
+      message.workflow_id &&
+      message.step_id
+    ) {
+      const responseQueue = `workflow.${message.workflow_id}.response`;
+      const response = {
+        step_id: message.step_id,
+        result: {
+          processed: true,
+          operation: message.operation,
+          input: message.input,
+          output: { mocked: true }
+        }
+      };
+      // Enqueue response (does not recurse into auto-reply because queue prefix differs)
+      await this.publish(responseQueue, response);
+    }
+
     // Trigger consumers if any
     if (this.consumers[queue]) {
       const consumer = this.consumers[queue];
@@ -114,9 +141,10 @@ class MockMQClient {
 
     if (requeue && message.fields) {
       const queue = message.fields.routingKey;
-      if (this.queues[queue]) {
-        this.queues[queue].push(message);
+      if (!this.queues[queue]) {
+        this.queues[queue] = [];
       }
+      this.queues[queue].push(message);
     }
 
     return Promise.resolve();