@onlineapps/conn-orch-validator 2.0.10 → 2.0.12

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/conn-orch-validator",
-  "version": "2.0.10",
+  "version": "2.0.12",
   "description": "Validation orchestrator for OA Drive microservices - coordinates validation across all layers (base, infra, orch, business)",
   "main": "src/index.js",
   "scripts": {

package/src/CookbookTestRunner.js

@@ -421,13 +421,16 @@ class CookbookTestRunner {
       throw new Error('Cookbook must have steps (array or object)');
     }
 
-    if (cookbook.steps.length === 0) {
+    // Normalize steps to array for validation
+    const stepsArray = this.normalizeSteps(cookbook.steps);
+
+    if (stepsArray.length === 0) {
       throw new Error('Cookbook must have at least one step');
     }
 
-    for (const step of cookbook.steps) {
-      if (!step.service) throw new Error('Step must have service');
-      if (!step.operation) throw new Error('Step must have operation');
+    for (const step of stepsArray) {
+      if (!step.service) throw new Error(`Step ${step.step_id || step.id || 'unknown'} must have service`);
+      if (!step.operation) throw new Error(`Step ${step.step_id || step.id || 'unknown'} must have operation`);
     }
 
     return true;

package/src/ValidationOrchestrator.js

@@ -478,7 +478,7 @@ class ValidationOrchestrator {
       }
     } else {
       console.error(`[ValidationOrchestrator] ❌ Validation FAILED (${duration}ms)`);
-      console.error(`[ValidationOrchestrator] Errors: ${JSON.stringify(results.errors, null, 2)}`);
+      console.error(`[ValidationOrchestrator] Errors: ${JSON.stringify(results.errors, null, 2)}(', ')}`);
     }
 
     return results;

package/src/validators/ServiceStructureValidator.js

@@ -159,12 +159,12 @@ class ServiceStructureValidator {
 
   /**
    * Validate config.json structure
+   * Note: service.version is now read from package.json (Single Source of Truth)
    */
   validateConfigStructure(config) {
-    // Required fields
+    // Required fields (version comes from package.json, not config.json)
     const requiredFields = [
       'service.name',
-      'service.version',
       'service.port'
     ];
 
@@ -200,18 +200,23 @@ class ServiceStructureValidator {
       }
     }
 
-    // Validate version format
-    if (config.service?.version) {
-      if (!/^\d+\.\d+\.\d+$/.test(config.service.version)) {
+    // Validate version format from package.json (Single Source of Truth)
+    const packagePath = path.join(this.serviceRoot, 'package.json');
+    try {
+      const pkg = JSON.parse(fs.readFileSync(packagePath, 'utf-8'));
+      const version = pkg.version;
+      if (version && !/^\d+\.\d+\.\d+$/.test(version)) {
         this.warnings.push({
           type: 'INVALID_VERSION',
-          path: 'conn-config/config.json',
-          field: 'service.version',
-          value: config.service.version,
-          message: `Version should follow semantic versioning: ${config.service.version}`,
+          path: 'package.json',
+          field: 'version',
+          value: version,
+          message: `Version should follow semantic versioning: ${version}`,
           fix: 'Use format: MAJOR.MINOR.PATCH (e.g., "1.0.0")'
         });
       }
+    } catch (e) {
+      // package.json validation is done separately
     }
   }