@onlineapps/conn-orch-validator 2.0.0 → 2.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/conn-orch-validator",
-  "version": "2.0.0",
+  "version": "2.0.2",
   "description": "Validation orchestrator for OA Drive microservices - coordinates validation across all layers (base, infra, orch, business)",
   "main": "src/index.js",
   "scripts": {

package/src/ValidationOrchestrator.js

@@ -20,8 +20,14 @@ class ValidationOrchestrator {
     this.serviceRoot = options.serviceRoot;
     this.serviceName = options.serviceName;
     this.serviceVersion = options.serviceVersion;
+    this.serviceUrl = options.serviceUrl; // NEW: Service URL for HTTP calls
     this.logger = options.logger || console;
 
+    // Validate required options
+    if (!this.serviceUrl) {
+      throw new Error('serviceUrl is required for ValidationOrchestrator');
+    }
+
     // Paths
     this.configPath = path.join(this.serviceRoot, 'conn-config');
     this.runtimePath = path.join(this.serviceRoot, 'conn-runtime');
@@ -32,7 +38,8 @@ class ValidationOrchestrator {
     this.readinessValidator = new ServiceReadinessValidator();
     this.cookbookRunner = new CookbookTestRunner({
       servicePath: this.serviceRoot,
-      serviceName: this.serviceName
+      serviceName: this.serviceName,
+      serviceUrl: this.serviceUrl // Pass serviceUrl to CookbookTestRunner
     });
   }
 
@@ -41,12 +48,12 @@ class ValidationOrchestrator {
    * Checks if proof exists and is valid, or runs full validation
    */
   async validate() {
-    this.logger.info('[ValidationOrchestrator] Starting validation...');
+    console.log('[ValidationOrchestrator] Starting validation...');
 
     // Check if proof exists and is valid
     const existingProof = await this.loadExistingProof();
     if (existingProof && await this.isProofValid(existingProof)) {
-      this.logger.info('[ValidationOrchestrator] ✓ Valid proof found, skipping validation');
+      console.log('[ValidationOrchestrator] ✓ Valid proof found, skipping validation');
       return {
         success: true,
         proofExists: true,
@@ -56,7 +63,7 @@ class ValidationOrchestrator {
     }
 
     // Run full validation
-    this.logger.info('[ValidationOrchestrator] No valid proof, running validation...');
+    console.log('[ValidationOrchestrator] No valid proof, running validation...');
     return await this.runFullValidation();
   }
 
@@ -74,7 +81,7 @@ class ValidationOrchestrator {
 
       return proof;
     } catch (error) {
-      this.logger.warn(`[ValidationOrchestrator] Failed to load proof: ${error.message}`);
+      console.warn(`[ValidationOrchestrator] Failed to load proof: ${error.message}`);
       return null;
     }
   }
@@ -90,7 +97,7 @@ class ValidationOrchestrator {
 
       // Check if fingerprint matches
       if (proof.fingerprint !== currentFingerprint) {
-        this.logger.info('[ValidationOrchestrator] Fingerprint mismatch (service changed)');
+        console.log('[ValidationOrchestrator] Fingerprint mismatch (service changed)');
         return false;
       }
 
@@ -100,20 +107,20 @@ class ValidationOrchestrator {
       const daysSinceValidation = (now - proofDate) / (1000 * 60 * 60 * 24);
 
       if (daysSinceValidation > 30) {
-        this.logger.info('[ValidationOrchestrator] Proof expired (>30 days old)');
+        console.log('[ValidationOrchestrator] Proof expired (>30 days old)');
         return false;
       }
 
       // Verify proof signature
       const isValid = ValidationProofCodec.verify(proof);
       if (!isValid) {
-        this.logger.warn('[ValidationOrchestrator] Proof signature invalid');
+        console.warn('[ValidationOrchestrator] Proof signature invalid');
         return false;
       }
 
       return true;
     } catch (error) {
-      this.logger.error(`[ValidationOrchestrator] Proof validation error: ${error.message}`);
+      console.error(`[ValidationOrchestrator] Proof validation error: ${error.message}`);
       return false;
     }
   }
@@ -170,7 +177,7 @@ class ValidationOrchestrator {
 
     try {
       // Step 1: Service Structure
-      this.logger.info('[ValidationOrchestrator] Step 1/6: Service Structure');
+      console.log('[ValidationOrchestrator] Step 1/6: Service Structure');
       results.steps.structure = await this.validateStructure();
       if (!results.steps.structure.valid) {
         results.success = false;
@@ -180,7 +187,7 @@ class ValidationOrchestrator {
       }
 
       // Step 2: Config Files
-      this.logger.info('[ValidationOrchestrator] Step 2/6: Config Files');
+      console.log('[ValidationOrchestrator] Step 2/6: Config Files');
       results.steps.config = await this.validateConfig();
       if (!results.steps.config.valid) {
         results.success = false;
@@ -188,7 +195,7 @@ class ValidationOrchestrator {
       }
 
       // Step 3: Operations Compliance
-      this.logger.info('[ValidationOrchestrator] Step 3/6: Operations Compliance');
+      console.log('[ValidationOrchestrator] Step 3/6: Operations Compliance');
       results.steps.operations = await this.validateOperations();
       if (!results.steps.operations.valid) {
         results.success = false;
@@ -196,7 +203,7 @@ class ValidationOrchestrator {
       }
 
       // Step 4: Cookbook Tests
-      this.logger.info('[ValidationOrchestrator] Step 4/6: Cookbook Tests');
+      console.log('[ValidationOrchestrator] Step 4/6: Cookbook Tests');
       results.steps.cookbooks = await this.runCookbookTests();
       results.totalTests += results.steps.cookbooks.total || 0;
       results.passedTests += results.steps.cookbooks.passed || 0;
@@ -207,7 +214,7 @@ class ValidationOrchestrator {
       }
 
       // Step 5: Service Readiness
-      this.logger.info('[ValidationOrchestrator] Step 5/6: Service Readiness');
+      console.log('[ValidationOrchestrator] Step 5/6: Service Readiness');
       results.steps.readiness = await this.validateReadiness();
       if (!results.steps.readiness.valid) {
         results.success = false;
@@ -215,7 +222,7 @@ class ValidationOrchestrator {
       }
 
       // Step 6: Connector Integration
-      this.logger.info('[ValidationOrchestrator] Step 6/6: Connector Integration');
+      console.log('[ValidationOrchestrator] Step 6/6: Connector Integration');
       results.steps.connectors = this.validateConnectors();
       if (!results.steps.connectors.valid) {
         // Non-critical - just warnings
@@ -226,7 +233,7 @@ class ValidationOrchestrator {
       return await this.finalizeResults(results, startTime);
 
     } catch (error) {
-      this.logger.error(`[ValidationOrchestrator] Validation failed: ${error.message}`);
+      console.error(`[ValidationOrchestrator] Validation failed: ${error.message}`);
       results.success = false;
       results.errors.push(`Validation error: ${error.message}`);
       return this.finalizeResults(results, startTime);
@@ -240,7 +247,7 @@ class ValidationOrchestrator {
     try {
       const result = this.structureValidator.validate();
 
-      this.logger.info(`[ValidationOrchestrator] ✓ Service structure: ${result.valid ? 'PASS' : 'FAIL'}`);
+      console.log(`[ValidationOrchestrator] ✓ Service structure: ${result.valid ? 'PASS' : 'FAIL'}`);
       return result;
     } catch (error) {
       return {
@@ -278,7 +285,7 @@ class ValidationOrchestrator {
         }
       }
 
-      this.logger.info(`[ValidationOrchestrator] ✓ Config files: ${errors.length === 0 ? 'PASS' : 'FAIL'}`);
+      console.log(`[ValidationOrchestrator] ✓ Config files: ${errors.length === 0 ? 'PASS' : 'FAIL'}`);
       return {
         valid: errors.length === 0,
         errors: errors
@@ -322,7 +329,7 @@ class ValidationOrchestrator {
         }
       }
 
-      this.logger.info(`[ValidationOrchestrator] ✓ Operations compliance: ${errors.length === 0 ? 'PASS' : 'FAIL'}`);
+      console.log(`[ValidationOrchestrator] ✓ Operations compliance: ${errors.length === 0 ? 'PASS' : 'FAIL'}`);
       return {
         valid: errors.length === 0,
         errors: errors
@@ -343,7 +350,7 @@ class ValidationOrchestrator {
       const cookbooksPath = path.join(this.serviceRoot, 'tests', 'cookbooks');
 
       if (!fs.existsSync(cookbooksPath)) {
-        this.logger.warn('[ValidationOrchestrator] No cookbook tests found (tests/cookbooks/ missing)');
+        console.warn('[ValidationOrchestrator] No cookbook tests found (tests/cookbooks/ missing)');
         return {
           success: true,
           total: 0,
@@ -355,7 +362,7 @@ class ValidationOrchestrator {
 
       const result = await this.cookbookRunner.runCookbooks(cookbooksPath);
 
-      this.logger.info(`[ValidationOrchestrator] ✓ Cookbook tests: ${result.passed}/${result.total} passed`);
+      console.log(`[ValidationOrchestrator] ✓ Cookbook tests: ${result.passed}/${result.total} passed`);
       return {
         success: result.failed === 0,
         total: result.total,
@@ -389,7 +396,7 @@ class ValidationOrchestrator {
         operations: operations.operations
       });
 
-      this.logger.info(`[ValidationOrchestrator] ✓ Service readiness: ${result.ready ? 'PASS' : 'FAIL'}`);
+      console.log(`[ValidationOrchestrator] ✓ Service readiness: ${result.ready ? 'PASS' : 'FAIL'}`);
       return {
         valid: result.ready,
         errors: result.ready ? [] : result.errors || ['Service not ready']
@@ -410,7 +417,7 @@ class ValidationOrchestrator {
       // This is validated implicitly through cookbook tests
       // which test ServiceWrapper + all connectors
 
-      this.logger.info('[ValidationOrchestrator] ✓ Connector integration: PASS (via cookbook tests)');
+      console.log('[ValidationOrchestrator] ✓ Connector integration: PASS (via cookbook tests)');
       return {
         valid: true,
         warnings: []
@@ -464,16 +471,16 @@ class ValidationOrchestrator {
         results.proof = encodedProof;
         results.fingerprint = fingerprint;
 
-        this.logger.info(`[ValidationOrchestrator] ✅ Validation PASSED (${duration}ms)`);
-        this.logger.info(`[ValidationOrchestrator] Proof saved to: ${this.proofPath}`);
+        console.log(`[ValidationOrchestrator] ✅ Validation PASSED (${duration}ms)`);
+        console.log(`[ValidationOrchestrator] Proof saved to: ${this.proofPath}`);
       } catch (error) {
-        this.logger.error(`[ValidationOrchestrator] Failed to generate proof: ${error.message}`);
+        console.error(`[ValidationOrchestrator] Failed to generate proof: ${error.message}`);
         results.success = false;
         results.errors.push(`Proof generation failed: ${error.message}`);
       }
     } else {
-      this.logger.error(`[ValidationOrchestrator] ❌ Validation FAILED (${duration}ms)`);
-      this.logger.error(`[ValidationOrchestrator] Errors: ${results.errors.join(', ')}`);
+      console.error(`[ValidationOrchestrator] ❌ Validation FAILED (${duration}ms)`);
+      console.error(`[ValidationOrchestrator] Errors: ${results.errors.join(', ')}`);
     }
 
     return results;
@@ -496,7 +503,7 @@ class ValidationOrchestrator {
       // Save proof
       fs.writeFileSync(this.proofPath, JSON.stringify(proof, null, 2));
 
-      this.logger.info(`[ValidationOrchestrator] Proof saved: ${this.proofPath}`);
+      console.log(`[ValidationOrchestrator] Proof saved: ${this.proofPath}`);
     } catch (error) {
       throw new Error(`Failed to save proof: ${error.message}`);
     }