@onlineapps/conn-orch-registry 1.1.18 → 1.1.20

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/conn-orch-registry",
-  "version": "1.1.18",
+    "version": "1.1.20",
   "license": "MIT",
   "description": "Connector-registry-client provides the core communication mechanism for microservices in this environment. It enables them to interact with a services_registry to receive and fulfill tasks by submitting heartbeats or their API descriptions.",
   "keywords": [

package/src/queueManager.js

@@ -43,6 +43,8 @@ class QueueManager {
    */
   async init() {
     this.conn = await amqp.connect(this.amqpUrl);
+    // Use regular channel instead of ConfirmChannel to avoid RPC reply queue issues
+    // ConfirmChannel uses RPC pattern which requires reply queues that may not exist
     this.channel = await this.conn.createChannel();
   }
 

package/src/registryClient.js

@@ -84,14 +84,28 @@ class ServiceRegistryClient extends EventEmitter {
     // Start consuming service response queue for registry responses
     await this.queueManager.channel.consume(
       this.serviceResponseQueue,
-      msg => this._handleRegistryMessage(msg),
+      msg => {
+        // Handle null message (queue deleted, connection closed, consumer canceled)
+        if (!msg) {
+          console.warn(`[RegistryClient] ${this.serviceName}: Received null message from ${this.serviceResponseQueue} (queue may be deleted or connection closed)`);
+          return;
+        }
+        this._handleRegistryMessage(msg);
+      },
       { noAck: false }
     );
 
     // CRITICAL: Also listen on registry event queue for certificate delivery
     await this.queueManager.channel.consume(
       this.serviceRegistryQueue,
-      msg => this._handleRegistryMessage(msg),
+      msg => {
+        // Handle null message (queue deleted, connection closed, consumer canceled)
+        if (!msg) {
+          console.warn(`[RegistryClient] ${this.serviceName}: Received null message from ${this.serviceRegistryQueue} (queue may be deleted or connection closed)`);
+          return;
+        }
+        this._handleRegistryMessage(msg);
+      },
       { noAck: false }
     );
   }
@@ -104,12 +118,26 @@ class ServiceRegistryClient extends EventEmitter {
    * @private
    */
   _handleRegistryMessage(msg) {
+    // CRITICAL: Handle null message (queue deleted, connection closed, consumer canceled)
+    if (!msg) {
+      console.warn(`[RegistryClient] ${this.serviceName}: Received null message (queue may be deleted or connection closed)`);
+      return; // Don't try to parse or ack null message
+    }
+    
     let payload;
     try {
       payload = JSON.parse(msg.content.toString());
     } catch (err) {
       this.emit('error', err);
-      return this.queueManager.channel.nack(msg, false, false);
+      // Only nack if message is not null
+      if (msg) {
+        try {
+          this.queueManager.channel.nack(msg, false, false);
+        } catch (nackErr) {
+          console.error(`[RegistryClient] ${this.serviceName}: Failed to nack message:`, nackErr.message);
+        }
+      }
+      return;
     }
 
     // Handle API description request from registry
@@ -152,8 +180,14 @@ class ServiceRegistryClient extends EventEmitter {
       }
     }
 
-    // Acknowledge all messages
-    this.queueManager.channel.ack(msg);
+    // Acknowledge all messages (only if message is not null)
+    if (msg) {
+      try {
+        this.queueManager.channel.ack(msg);
+      } catch (ackErr) {
+        console.error(`[RegistryClient] ${this.serviceName}: Failed to ack message:`, ackErr.message);
+      }
+    }
   }
 
   /**