@onlineapps/conn-orch-registry 1.1.11 → 1.1.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/conn-orch-registry",
-  "version": "1.1.11",
+  "version": "1.1.13",
   "license": "MIT",
   "description": "Connector-registry-client provides the core communication mechanism for microservices in this environment. It enables them to interact with a services_registry to receive and fulfill tasks by submitting heartbeats or their API descriptions.",
   "keywords": [
@@ -39,7 +39,6 @@
   },
   "dependencies": {
     "@onlineapps/conn-base-storage": "^1.0.0",
-    "@onlineapps/conn-orch-registry": "^1.1.10",
     "amqplib": "^0.10.3",
     "axios": "^1.5.0",
     "dotenv": "^16.1.4",

package/src/registryClient.js

@@ -19,8 +19,6 @@ const EventEmitter = require('events');
 const QueueManager = require('./queueManager');
 const RegistryEventConsumer = require('./registryEventConsumer');
 const { v4: uuidv4 } = require('uuid');
-const fs = require('fs');
-const path = require('path');
 
 class ServiceRegistryClient extends EventEmitter {
   /**
@@ -32,10 +30,11 @@ class ServiceRegistryClient extends EventEmitter {
    * @param {number} [opts.heartbeatInterval=10000] - Heartbeat interval in milliseconds
    * @param {string} [opts.apiQueue='api_services_queuer'] - Queue name for heartbeat and API traffic
    * @param {string} [opts.registryQueue='registry_office'] - Queue name for registry messages
+   * @param {Object} [opts.validationProof=null] - Validation proof object {hash, data} (injected from outside)
    */
   constructor({ amqpUrl, serviceName, version, specificationEndpoint = '/api/v1/specification',
                 heartbeatInterval = 10000, apiQueue = 'api_services_queuer', registryQueue = 'registry.register',
-                redis = null, storageConfig = {} }) {
+                redis = null, storageConfig = {}, validationProof = null }) {
     super();
     if (!amqpUrl || !serviceName || !version) {
       throw new Error('amqpUrl, serviceName, and version are required');
@@ -54,8 +53,8 @@ class ServiceRegistryClient extends EventEmitter {
     this.redis = redis;
     this.storageConfig = storageConfig;
 
-    // Validation proof (loaded from .validation-proof.json)
-    this.validationProof = null;
+    // Validation proof (injected via constructor - DEPENDENCY INJECTION)
+    this.validationProof = validationProof;
   }
 
   /**
@@ -65,10 +64,13 @@ class ServiceRegistryClient extends EventEmitter {
   async init() {
     await this.queueManager.init();
 
-    // Load validation proof if exists
-    console.error(`[RegistryClient] ${this.serviceName}: === CALLING _loadValidationProof() ===`);
-    await this._loadValidationProof();
-    console.error(`[RegistryClient] ${this.serviceName}: === FINISHED _loadValidationProof() ===`);
+    // Validation proof is now injected via constructor (not loaded here)
+    if (this.validationProof) {
+      console.log(`[RegistryClient] ${this.serviceName}: ✅ Validation proof provided via constructor`);
+      console.log(`[RegistryClient] ${this.serviceName}:    Proof hash: ${this.validationProof.hash.substring(0, 32)}...`);
+    } else {
+      console.log(`[RegistryClient] ${this.serviceName}: ⚠️  No validation proof - will use Tier 2 validation`);
+    }
 
     // Create service-specific response queue
     this.serviceResponseQueue = `${this.serviceName}.responses`;
@@ -94,93 +96,6 @@ class ServiceRegistryClient extends EventEmitter {
     );
   }
 
-  /**
-   * Loads validation proof from .validation-proof.json in service root directory.
-   * Called during initialization.
-   * @private
-   * @returns {Promise<void>}
-   */
-  async _loadValidationProof() {
-    console.log(`[RegistryClient] ${this.serviceName}: >>> ENTERING _loadValidationProof() <<<`);
-
-    const proofPath = path.join(process.cwd(), '.validation-proof.json');
-    const debugLogPath = path.join(process.cwd(), '.validation-debug.log');
-
-    console.log(`[RegistryClient] ${this.serviceName}: CWD = ${process.cwd()}`);
-    console.log(`[RegistryClient] ${this.serviceName}: Proof path = ${proofPath}`);
-
-    // Write to file for debugging (append mode)
-    const log = (msg) => {
-      const timestamp = new Date().toISOString();
-      const logLine = `${timestamp} [${this.serviceName}] ${msg}\n`;
-      try {
-        fs.appendFileSync(debugLogPath, logLine);
-      } catch (err) {
-        console.error(`[RegistryClient] Failed to write debug log: ${err.message}`);
-      }
-      console.log(`[RegistryClient] ${msg}`);
-    };
-
-    log('=== _loadValidationProof() CALLED ===');
-    log(`CWD: ${process.cwd()}`);
-    log(`Proof path: ${proofPath}`);
-
-    try {
-      // Check file existence explicitly
-      if (!fs.existsSync(proofPath)) {
-        log(`⚠️  Validation proof file NOT FOUND`);
-        log(`Service will use Tier 2 validation`);
-        this.validationProof = null;
-        return;
-      }
-
-      log(`✓ Proof file exists, reading...`);
-
-      // Read and parse file
-      const fileContent = fs.readFileSync(proofPath, 'utf8');
-      log(`✓ File read, size: ${fileContent.length} bytes`);
-
-      const proofData = JSON.parse(fileContent);
-      log(`✓ JSON parsed successfully`);
-
-      // Validate structure
-      if (!proofData.validationProof) {
-        log(`❌ ERROR: Missing 'validationProof' field`);
-        log(`Available fields: ${Object.keys(proofData).join(', ')}`);
-        this.validationProof = null;
-        return;
-      }
-
-      if (!proofData.validationData) {
-        log(`❌ ERROR: Missing 'validationData' field`);
-        log(`Available fields: ${Object.keys(proofData).join(', ')}`);
-        this.validationProof = null;
-        return;
-      }
-
-      // Store proof
-      this.validationProof = {
-        hash: proofData.validationProof,
-        data: proofData.validationData
-      };
-
-      log(`✅ SUCCESS - Validation proof loaded`);
-      log(`   Proof hash: ${this.validationProof.hash.substring(0, 32)}...`);
-      log(`   Validator: ${this.validationProof.data.validator}`);
-      log(`   Tests passed: ${this.validationProof.data.testsPassed}/${this.validationProof.data.testsRun}`);
-      log(`   Validated at: ${this.validationProof.data.validatedAt}`);
-
-    } catch (error) {
-      // Non-critical error - service can still register without proof (will trigger Tier 2 validation)
-      log(`❌ EXCEPTION while loading validation proof`);
-      log(`   Error: ${error.message}`);
-      log(`   Stack: ${error.stack}`);
-      log(`   Path attempted: ${proofPath}`);
-      log(`Service will use Tier 2 validation`);
-      this.validationProof = null;
-    }
-  }
-
   /**
    * Internal handler for incoming messages from the registry queue.
    * Emits 'apiDescriptionRequest' when appropriate.