@onlineapps/conn-orch-orchestrator 2.0.1 → 2.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/conn-orch-orchestrator",
-  "version": "2.0.1",
+  "version": "2.0.3",
   "description": "Workflow orchestration connector for OA Drive - handles message routing and workflow execution",
   "main": "src/index.js",
   "scripts": {
@@ -24,7 +24,7 @@
     "@onlineapps/conn-base-monitoring": "1.0.12",
     "@onlineapps/conn-infra-mq": "1.1.70",
     "@onlineapps/conn-orch-registry": "1.2.1",
-    "@onlineapps/conn-orch-cookbook": "2.1.2"
+    "@onlineapps/conn-orch-cookbook": "2.1.3"
   },
   "devDependencies": {
     "jest": "^29.5.0",

package/src/WorkflowOrchestrator.js

@@ -79,6 +79,8 @@ class WorkflowOrchestrator {
    * legacy placements from transports that move AMQP headers onto the
    * parsed message object. Returns undefined if none are set - the caller
    * is responsible for fail-fast.
+   *
+   * @see api/docs/standards/workflow-message-contract.md
    * @private
    * @param {Object} message - Inbound workflow message
    * @returns {string|undefined}
@@ -173,23 +175,30 @@ class WorkflowOrchestrator {
   async processWorkflowMessage(message, serviceName) {
     const { workflow_id, cookbook: cookbookDef, current_step } = message;
     const startTime = Date.now();
-
-    // Fail-fast: correlation_id MUST be present on every workflow message.
-    // A workflow without a correlation_id is malformed per RFC §5.8
-    // (ContextBuilder._validateMqMessage rejects empty strings too).
-    // The gateway must publish it; if it does not, that is a gateway bug
-    // we want to surface loudly rather than silently produce 500s inside
-    // invokeOperation's ContextBuilder.
+    // correlation_id is required by RFC §5.8 — validated below inside the
+    // try block so malformed messages flow through the retry/DLQ pipeline
+    // and a `failed` monitoring event is emitted (no silent redelivery).
+    // @see api/docs/standards/workflow-message-contract.md
     const correlationId = this._extractCorrelationId(message);
-    if (typeof correlationId !== 'string' || correlationId.length === 0) {
-      throw new Error(
-        '[WorkflowOrchestrator] message.correlation_id is required - ' +
-        `Expected non-empty string on inbound workflow message (workflow_id='${workflow_id}', step='${current_step}'). ` +
-        'Fix: ensure publisher (gateway / router) sets correlation_id on message body per RFC §5.8.'
-      );
-    }
 
     try {
+      // Fail-fast: correlation_id MUST be present on every workflow message.
+      // (ContextBuilder._validateMqMessage rejects empty strings too.)
+      // Gateway is expected to publish it; if it does not, that is a gateway
+      // bug we want to surface loudly rather than silently produce 500s
+      // inside invokeOperation's ContextBuilder.
+      if (typeof correlationId !== 'string' || correlationId.length === 0) {
+        const err = new Error(
+          '[WorkflowOrchestrator] message.correlation_id is required - ' +
+          `Expected non-empty string on inbound workflow message (workflow_id='${workflow_id}', step='${current_step}'). ` +
+          'Fix: ensure publisher (gateway / router) sets correlation_id on message body per RFC §5.8.'
+        );
+        err.errorCode = 'MISSING_CORRELATION_ID';
+        err.statusCode = 400;
+        err.type = 'VALIDATION';
+        throw err;
+      }
+
       // Validate cookbook structure
       this.cookbook.validateCookbook(cookbookDef);
 
@@ -629,7 +638,8 @@ class WorkflowOrchestrator {
       data: context,
       workflow_id: context?.workflow_id || null,
       step_id: stepId,
-      service: serviceName || null
+      service: serviceName || null,
+      logger: this.logger
     };
 
     const resolvedInput = await this._resolveInputReferencesAsync(step.input, context, helperContext);
@@ -961,7 +971,8 @@ class WorkflowOrchestrator {
       data: context,
       workflow_id: context?.workflow_id || null,
       step_id: stepId,
-      service: serviceName || null
+      service: serviceName || null,
+      logger: this.logger
     };
 
     const iteratorResolved = await this._resolveInputReferencesAsync(step.iterator, context, helperContext);
@@ -1015,7 +1026,8 @@ class WorkflowOrchestrator {
       data: context,
       workflow_id: context?.workflow_id || null,
       step_id: stepId,
-      service: serviceName || null
+      service: serviceName || null,
+      logger: this.logger
     };
 
     const value = await this._evaluateSwitchExpression(step.expression, context, helperContext);