@onlineapps/conn-orch-orchestrator 1.0.25 → 1.0.27

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/conn-orch-orchestrator",
-  "version": "1.0.25",
+  "version": "1.0.27",
   "description": "Workflow orchestration connector for OA Drive - handles message routing and workflow execution",
   "main": "src/index.js",
   "scripts": {
@@ -24,7 +24,7 @@
     "@onlineapps/conn-infra-mq": "^1.1.0",
     "@onlineapps/conn-orch-registry": "^1.1.4",
     "@onlineapps/conn-orch-cookbook": "^2.0.0",
-    "@onlineapps/conn-orch-api-mapper": "^1.0.6"
+    "@onlineapps/conn-orch-api-mapper": "^1.0.8"
   },
   "devDependencies": {
     "jest": "^29.5.0",

package/src/WorkflowOrchestrator.js

@@ -155,6 +155,21 @@ class WorkflowOrchestrator {
         completed_at: new Date().toISOString()
       };
       
+      // === STRUCTURED LOG: Context update ===
+      console.log(`[WorkflowOrchestrator:CONTEXT_UPDATE] ${JSON.stringify({
+        layer: 'orchestrator',
+        workflow_id: workflow_id,
+        step_id: stepId,
+        stored_output: {
+          _descriptor: result?._descriptor,
+          type: result?.type,
+          storage_ref: result?.storage_ref,
+          outputKeys: result && typeof result === 'object' ? Object.keys(result) : null
+        },
+        timestamp: new Date().toISOString()
+      })}`);
+
+      
       const updatedContext = {
         ...enrichedContext,
         steps: existingSteps  // Object keyed by step_id
@@ -280,9 +295,34 @@ class WorkflowOrchestrator {
    * @returns {Promise<Object>} API call result
    */
   async _executeTaskStep(step, context) {
+    // FAIL-FAST: Verify context exists
+    if (!context) {
+      const error = new Error(`Context is missing for step ${step.step_id}`);
+      this.logger.error('[WorkflowOrchestrator] [FAIL-FAST] Missing context', { step_id: step.step_id });
+      throw error;
+    }
+    
     // Debug: log context keys and api_input
     console.log(`[WorkflowOrchestrator] [RESOLVE] Step ${step.step_id} - context keys:`, Object.keys(context || {}));
-    console.log(`[WorkflowOrchestrator] [RESOLVE] Step ${step.step_id} - context.api_input:`, JSON.stringify(context?.api_input || {}));
+    
+    // FAIL-FAST: Log api_input state (but don't fail if missing - it might not be needed)
+    if (context.api_input === undefined) {
+      console.warn(`[WorkflowOrchestrator] [WARNING] Step ${step.step_id} - context.api_input is undefined - template references like {{api_input.field}} will fail`);
+    } else if (context.api_input === null) {
+      console.warn(`[WorkflowOrchestrator] [WARNING] Step ${step.step_id} - context.api_input is null - template references like {{api_input.field}} will fail`);
+    } else if (typeof context.api_input !== 'object' || Array.isArray(context.api_input)) {
+      const error = new Error(`Invalid api_input type for step ${step.step_id}: expected object, got ${typeof context.api_input}`);
+      console.error(`[WorkflowOrchestrator] [FAIL-FAST] Invalid api_input type:`, {
+        step_id: step.step_id,
+        api_input_type: typeof context.api_input,
+        api_input_value: context.api_input,
+        is_array: Array.isArray(context.api_input)
+      });
+      throw error;
+    } else {
+      console.log(`[WorkflowOrchestrator] [RESOLVE] Step ${step.step_id} - context.api_input:`, JSON.stringify(context.api_input));
+    }
+    
     console.log(`[WorkflowOrchestrator] [RESOLVE] Step ${step.step_id} - context.steps keys:`, 
       context.steps ? Object.keys(context.steps) : 'NO STEPS');
     
@@ -291,6 +331,18 @@ class WorkflowOrchestrator {
     const resolvedInput = this._resolveInputReferences(step.input, context);
     console.log(`[WorkflowOrchestrator] [RESOLVE] Step ${step.step_id} input AFTER:`, JSON.stringify(resolvedInput));
     
+    // FAIL-FAST: Check if template references were resolved
+    const inputStr = JSON.stringify(resolvedInput);
+    if (inputStr.includes('{{api_input.') || inputStr.includes('${api_input.')) {
+      console.error(`[WorkflowOrchestrator] [FAIL-FAST] Unresolved api_input template in step ${step.step_id}:`, {
+        step_id: step.step_id,
+        resolved_input: resolvedInput,
+        context_api_input: context.api_input,
+        context_keys: Object.keys(context)
+      });
+      throw new Error(`Template reference to api_input not resolved in step ${step.step_id} - check that api_input is in context`);
+    }
+    
     // Use API mapper to call the service with resolved input
     const result = await this.apiMapper.callOperation(
       step.operation,
@@ -298,6 +350,21 @@ class WorkflowOrchestrator {
       context
     );
 
+    // === STRUCTURED LOG: Step result ===
+    console.log(`[WorkflowOrchestrator:STEP_RESULT] ${JSON.stringify({
+      layer: 'orchestrator',
+      step_id: step.step_id,
+      service: step.service,
+      operation: step.operation,
+      result: {
+        _descriptor: result?._descriptor,
+        type: result?.type,
+        storage_ref: result?.storage_ref,
+        resultKeys: result && typeof result === 'object' ? Object.keys(result) : null
+      },
+      timestamp: new Date().toISOString()
+    })}`);
+
     this.logger.info(`Task step executed`, {
       step: step.step_id,
       service: step.service,
@@ -378,6 +445,12 @@ class WorkflowOrchestrator {
    * @returns {*} Resolved value or undefined
    */
   _getValueFromPath(path, context) {
+    // FAIL-FAST: Verify context exists
+    if (!context) {
+      console.error('[WorkflowOrchestrator] [FAIL-FAST] _getValueFromPath called with null/undefined context', { path });
+      throw new Error(`Cannot resolve path '${path}': context is null or undefined`);
+    }
+    
     // V2: steps is an object keyed by step_id, not an array
     // Support both formats for backward compatibility during migration:
     // - steps.step_id.output.field (V2, preferred)
@@ -402,9 +475,36 @@ class WorkflowOrchestrator {
     
     const parts = normalized.split('.');
     
+    // FAIL-FAST: Log api_input access attempts
+    if (normalized.startsWith('api_input.')) {
+      console.log(`[WorkflowOrchestrator] [GET_VALUE] Resolving api_input path: ${path} -> ${normalized}`);
+      console.log(`[WorkflowOrchestrator] [GET_VALUE] context.api_input exists:`, context.api_input !== undefined);
+      console.log(`[WorkflowOrchestrator] [GET_VALUE] context.api_input type:`, typeof context.api_input);
+      if (context.api_input) {
+        console.log(`[WorkflowOrchestrator] [GET_VALUE] context.api_input keys:`, Object.keys(context.api_input));
+      }
+    }
+    
     let current = context;
     for (const part of parts) {
-      if (current === undefined || current === null) return undefined;
+      if (current === undefined || current === null) {
+        // FAIL-FAST: Log failed resolution for api_input
+        if (normalized.startsWith('api_input.')) {
+          console.error(`[WorkflowOrchestrator] [FAIL-FAST] Failed to resolve api_input path: ${path}`, {
+            path,
+            normalized,
+            parts,
+            failed_at_part: part,
+            current_type: typeof current,
+            context_keys: Object.keys(context),
+            context_has_api_input: 'api_input' in context,
+            api_input_type: typeof context.api_input,
+            api_input_keys: context.api_input ? Object.keys(context.api_input) : null
+          });
+          throw new Error(`Failed to resolve api_input path '${path}': '${part}' is undefined in context`);
+        }
+        return undefined;
+      }
       
       // Special handling for steps: if accessing by numeric index and steps is object,
       // try to find step by index in cookbook (fallback for legacy)