@onlineapps/conn-orch-orchestrator 1.0.17 → 1.0.19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/conn-orch-orchestrator",
-  "version": "1.0.17",
+  "version": "1.0.19",
   "description": "Workflow orchestration connector for OA Drive - handles message routing and workflow execution",
   "main": "src/index.js",
   "scripts": {

package/src/WorkflowOrchestrator.js

@@ -86,11 +86,14 @@ class WorkflowOrchestrator {
         delivery: context?.delivery || cookbookDef?.delivery || { handler: 'none' }
       };
 
-      // Find current step
-      const step = cookbookDef.steps.find(s => s.id === current_step);
+      // Find current step (V2: step_id only)
+      const step = cookbookDef.steps.find(s => s.step_id === current_step);
       if (!step) {
         throw new Error(`Step not found: ${current_step}`);
       }
+      
+      // Get step_id (V2)
+      const stepId = step.step_id;
 
       // Check if this step is for this service
       if (step.type === 'task' && step.service !== serviceName) {
@@ -112,7 +115,7 @@ class WorkflowOrchestrator {
         result = await this.cache.get(cacheKey);
 
         if (result) {
-          this.logger.info('Cache hit', { step: step.id, cacheKey });
+          this.logger.info('Cache hit', { step: stepId, cacheKey });
         } else {
           // Execute the step
           result = await this._executeStep(step, enrichedContext, cookbookDef);
@@ -123,19 +126,27 @@ class WorkflowOrchestrator {
         result = await this._executeStep(step, enrichedContext, cookbookDef);
       }
 
-      // Update context with result - steps as ARRAY (consistent with cookbook.steps)
-      // Each step preserves its definition (id, type, service, operation, input) and adds output
-      const currentIndex = cookbookDef.steps.findIndex(s => s.id === current_step);
+      // Update context with result - steps as OBJECT (V2 format, keyed by step_id)
+      // Each step preserves its definition (step_id, type, service, operation, input) and adds output
+      const currentIndex = cookbookDef.steps.findIndex(s => s.step_id === current_step);
       const stepDefinition = cookbookDef.steps[currentIndex];
       
-      // Initialize steps array from cookbook if not present
-      const existingSteps = Array.isArray(enrichedContext.steps) 
-        ? [...enrichedContext.steps] 
-        : cookbookDef.steps.map(s => ({ ...s }));  // Deep copy of step definitions
+      // Initialize steps object from cookbook if not present
+      // V2: steps is an object keyed by step_id, not an array
+      let existingSteps = enrichedContext.steps || {};
+      
+      // Initialize from cookbook if empty
+      if (Object.keys(existingSteps).length === 0) {
+        cookbookDef.steps.forEach(s => {
+          if (s.step_id) {
+            existingSteps[s.step_id] = { ...s };
+          }
+        });
+      }
       
-      // Update the current step with output (preserve id, type, service, operation, input)
-      existingSteps[currentIndex] = {
-        ...stepDefinition,           // id, type, service, operation, input
+      // Update the current step with output (preserve step_id, type, service, operation, input)
+      existingSteps[stepId] = {
+        ...stepDefinition,           // step_id, type, service, operation, input
         output: result,              // Add output from operation
         status: 'completed',
         completed_at: new Date().toISOString()
@@ -143,7 +154,7 @@ class WorkflowOrchestrator {
       
       const updatedContext = {
         ...enrichedContext,
-        steps: existingSteps
+        steps: existingSteps  // Object keyed by step_id
       };
 
       // Publish workflow.progress AFTER execution (so we have step output)
@@ -177,10 +188,11 @@ class WorkflowOrchestrator {
 
       if (nextStep) {
         // Route to next step
-        await this._routeToNextStep(nextStep, cookbookDef, updatedContext, workflow_id);
+        const nextStepId = nextStep.step_id;
+        await this._routeToNextStep(nextStep, cookbookDef, updatedContext, workflow_id, nextStepId);
       } else {
         // Workflow completed - pass serviceName, cookbook and last step info for monitoring
-        await this._completeWorkflow(workflow_id, updatedContext, cookbookDef, serviceName, current_step, currentIndex);
+        await this._completeWorkflow(workflow_id, updatedContext, cookbookDef, serviceName, stepId, currentIndex);
       }
 
       return {
@@ -271,13 +283,13 @@ class WorkflowOrchestrator {
     
     // Use API mapper to call the service with resolved input
     const result = await this.apiMapper.callOperation(
-      step.operation || step.id,
+      step.operation,
       resolvedInput,
       context
     );
 
     this.logger.info(`Task step executed`, {
-      step: step.id,
+      step: step.step_id,
       service: step.service,
       operation: step.operation,
       inputResolved: !!resolvedInput
@@ -322,16 +334,28 @@ class WorkflowOrchestrator {
   /**
    * Get value from dot/bracket notation path
    * @private
-   * @param {string} path - Path like "steps[0].output.message" or "api_input.name"
+   * @param {string} path - Path like "steps.step_id.output.message" or "api_input.name"
    * @param {Object} context - Context object
    * @returns {*} Resolved value or undefined
    */
   _getValueFromPath(path, context) {
-    // Normalize bracket notation to dot notation: steps[0] -> steps.0
-    let normalized = path.replace(/\[(\d+)\]/g, '.$1');
+    // V2: steps is an object keyed by step_id, not an array
+    // Support both formats for backward compatibility during migration:
+    // - steps.step_id.output.field (V2, preferred)
+    // - steps[0].output.field (legacy, deprecated)
+    
+    // Normalize bracket notation to dot notation: steps[0] -> steps.0 (legacy)
+    // But prefer step_id access: steps.step_id -> steps.step_id (V2)
+    let normalized = path;
+    
+    // Handle legacy array access steps[N] - convert to numeric key
+    // But only if steps is actually an array (fallback for old data)
+    if (normalized.includes('[') && normalized.includes(']')) {
+      normalized = normalized.replace(/\[(\d+)\]/g, '.$1');
+    }
     
     // Strip prefixes - we're already searching in context object
-    // Supports: ${context.X}, ${api_input.X}, ${steps[N].X}
+    // Supports: ${context.X}, ${api_input.X}, ${steps.step_id.X} (V2)
     if (normalized.startsWith('context.')) {
       normalized = normalized.substring(8); // Remove 'context.'
     }
@@ -342,6 +366,16 @@ class WorkflowOrchestrator {
     let current = context;
     for (const part of parts) {
       if (current === undefined || current === null) return undefined;
+      
+      // Special handling for steps: if accessing by numeric index and steps is object,
+      // try to find step by index in cookbook (fallback for legacy)
+      if (part === 'steps' && parts.length > 1) {
+        current = current.steps;
+        // If steps is object (V2), next part is step_id
+        // If steps is array (legacy), next part is numeric index
+        continue;
+      }
+      
       current = current[part];
     }
     return current;
@@ -376,7 +410,7 @@ class WorkflowOrchestrator {
     const result = await executor.executeStep(step);
 
     this.logger.info(`Control flow step executed`, {
-      step: step.id,
+      step: step.step_id,
       type: step.type
     });
 
@@ -391,12 +425,13 @@ class WorkflowOrchestrator {
    * @param {Object} cookbookDef - Full cookbook definition
    * @param {Object} context - Updated context
    * @param {string} workflow_id - Workflow ID
+   * @param {string} nextStepId - Next step step_id (V2) or id (V1 fallback)
    */
-  async _routeToNextStep(nextStep, cookbookDef, context, workflow_id) {
+  async _routeToNextStep(nextStep, cookbookDef, context, workflow_id, nextStepId) {
     const message = {
       workflow_id,
       cookbook: cookbookDef,
-      current_step: nextStep.id,
+      current_step: nextStepId,
       context
     };
 
@@ -405,21 +440,21 @@ class WorkflowOrchestrator {
       if (this.router?.routeToService) {
         await this.router.routeToService(nextStep.service, message);
         this.logger.info(`Routed to service: ${nextStep.service}`, {
-          step: nextStep.id
+          step: nextStepId
         });
       } else {
         // Fallback: publish to service's workflow queue directly
         const serviceQueue = `${nextStep.service}.workflow`;
         await this.mqClient.publish(serviceQueue, message);
         this.logger.info(`Published to queue: ${serviceQueue}`, {
-          step: nextStep.id
+          step: nextStepId
         });
       }
     } else {
       // Control flow steps handled by workflow init queue
       await this.mqClient.publish('workflow.init', message);
       this.logger.info(`Routed control flow to workflow.init`, {
-        step: nextStep.id
+        step: nextStepId
       });
     }
   }
@@ -490,12 +525,12 @@ class WorkflowOrchestrator {
     const crypto = require('crypto');
     const data = JSON.stringify({
       service: step.service,
-      operation: step.operation || step.id,
+      operation: step.operation,
       input: step.input,
       contextInput: context.api_input
     });
     const hash = crypto.createHash('sha256').update(data).digest('hex');
-    return `workflow:step:${step.service}:${step.operation || step.id}:${hash}`;
+    return `workflow:step:${step.service}:${step.operation}:${hash}`;
   }
 
   /**