@onlineapps/conn-infra-mq 1.1.5 → 1.1.7

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@onlineapps/conn-infra-mq",
-    "version": "1.1.5",
+    "version": "1.1.7",
     "description": "A promise-based, broker-agnostic client for sending and receiving messages via RabbitMQ",
     "main": "src/index.js",
     "repository": {

package/src/transports/rabbitmqClient.js

@@ -160,30 +160,41 @@ class RabbitMQClient extends EventEmitter {
       // Skip assertQueue for reply queues (they're already created with specific settings)
       // Reply queues start with 'rpc.reply.' and are created as non-durable
       if (!queue.startsWith('rpc.reply.')) {
-        // Use central config for infrastructure queues
-        const queueOptions = this._getQueueOptions(queue, { durable });
+        // Check if this is an infrastructure queue - services should NEVER create these
+        const isInfraQueue = queueConfig.isInfrastructureQueue(queue);
         
-        // Try to assert queue with our config
-        // If it fails with 406 (PRECONDITION-FAILED), queue exists with different args - use it as-is
-        try {
-          await this._channel.assertQueue(queue, queueOptions);
-        } catch (assertErr) {
-          // If queue exists with different arguments (406), use it as-is
-          if (assertErr.code === 406) {
-            console.warn(`[RabbitMQClient] Queue ${queue} exists with different arguments, using as-is:`, assertErr.message);
-            // Try to assert with minimal options (just durable) to verify queue exists
-            try {
-              await this._channel.assertQueue(queue, { durable: durable !== false });
-            } catch (minErr) {
-              // If even minimal assert fails, queue might not exist - log and proceed
-              console.warn(`[RabbitMQClient] Could not assert queue ${queue} with minimal options:`, minErr.message);
+        if (isInfraQueue) {
+          // Infrastructure queue - should already exist, created by infrastructure initialization
+          // Only check if it exists, don't try to create or assert with arguments
+          try {
+            await this._channel.checkQueue(queue);
+            // Queue exists - proceed to consume
+          } catch (checkErr) {
+            if (checkErr.code === 404) {
+              // Queue doesn't exist - infrastructure problem
+              throw new Error(`Infrastructure queue '${queue}' not found. Queue should be created during infrastructure initialization.`);
             }
-          } else if (assertErr.code === 404) {
-            // Queue doesn't exist - this shouldn't happen with assertQueue, but handle it
-            throw assertErr;
-          } else {
             // Other error - rethrow
-            throw assertErr;
+            throw checkErr;
+          }
+        } else {
+          // Business queue - may need to be created, but use unified config
+          const queueOptions = this._getQueueOptions(queue, { durable });
+          
+          // Try to assert queue with our config
+          // If it fails with 406 (PRECONDITION-FAILED), queue exists with different args - use it as-is
+          // IMPORTANT: Don't try to re-assert after 406, as it will close the channel
+          try {
+            await this._channel.assertQueue(queue, queueOptions);
+          } catch (assertErr) {
+            // If queue exists with different arguments (406), use it as-is without re-asserting
+            if (assertErr.code === 406) {
+              console.warn(`[RabbitMQClient] Queue ${queue} exists with different arguments, using as-is (skipping assert to avoid channel close):`, assertErr.message);
+              // Don't try to re-assert - just proceed to consume
+            } else {
+              // Other error - rethrow
+              throw assertErr;
+            }
           }
         }
       }