@onlineapps/conn-infra-mq 1.1.49 → 1.1.51

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@onlineapps/conn-infra-mq",
-    "version": "1.1.49",
+    "version": "1.1.51",
     "description": "A promise-based, broker-agnostic client for sending and receiving messages via RabbitMQ",
     "main": "src/index.js",
     "repository": {

package/src/transports/rabbitmqClient.js

@@ -294,23 +294,89 @@ class RabbitMQClient extends EventEmitter {
       // Skip assertQueue for reply queues (they're already created with specific settings)
       // Reply queues start with 'rpc.reply.' and are created as non-durable
       if (!queue.startsWith('rpc.reply.')) {
-        // Check if this is an infrastructure queue - services should NEVER create these
+        // CRITICAL: amqplib's channel.consume() may internally call assertQueue() without parameters
+        // This causes 406 errors if queue exists with different arguments
+        // Solution: Explicitly assertQueue() with correct parameters BEFORE consume()
         const isInfraQueue = queueConfig.isInfrastructureQueue(queue);
+        const isBusinessQueue = queueConfig.isBusinessQueue(queue);
+        
+        let queueOptions = { durable };
         
         if (isInfraQueue) {
-          // Infrastructure queue - should already exist, created by infrastructure initialization
-          // CRITICAL: Do NOT use checkQueue() - it closes channel on 406 if queue exists with different args
-          // Just proceed to consume() - if queue doesn't exist, consume() will fail with clear error
-          // This avoids channel closure from checkQueue() on infrastructure queues
-          console.log(`[RabbitMQClient] DEBUG: Infrastructure queue ${queue}, skipping checkQueue() - queue should already exist (created by infrastructure initialization)`);
-        } else {
-          // Business queue - should already be created by setupServiceQueues() BEFORE consume is called
-          // CRITICAL: Do NOT use checkQueue() - it closes channel on 404!
-          // If queue doesn't exist, that's a programming error (setupServiceQueues() should have created it)
-          // Just proceed to consume - if queue doesn't exist, consume will fail with a clear error
-          // This avoids channel closure from checkQueue() on non-existent queues
-          console.log(`[RabbitMQClient] DEBUG: Business queue ${queue}, skipping checkQueue() - queue should already exist`);
+          // Infrastructure queue - use central config
+          try {
+            const infraConfig = queueConfig.getInfrastructureQueueConfig(queue);
+            queueOptions = {
+              durable: infraConfig.durable !== false,
+              arguments: { ...infraConfig.arguments }
+            };
+            console.log(`[RabbitMQClient] [CONSUMER] Asserting infrastructure queue ${queue} with config from queueConfig`);
+          } catch (configErr) {
+            console.warn(`[RabbitMQClient] [CONSUMER] Infrastructure queue config not found for ${queue}, using default:`, configErr.message);
+          }
+        } else if (isBusinessQueue) {
+          // Business queue - use central config
+          try {
+            const parsed = queueConfig.parseBusinessQueue(queue);
+            if (parsed) {
+              const businessConfig = queueConfig.getBusinessQueueConfig(parsed.queueType, parsed.serviceName);
+              queueOptions = {
+                durable: businessConfig.durable !== false,
+                arguments: { ...businessConfig.arguments }
+              };
+              console.log(`[RabbitMQClient] [CONSUMER] Asserting business queue ${queue} with config from queueConfig`);
+            }
+          } catch (configErr) {
+            console.warn(`[RabbitMQClient] [CONSUMER] Business queue config not found for ${queue}, using default:`, configErr.message);
+          }
         }
+        
+        // CRITICAL: Assert queue with correct parameters BEFORE consume()
+        // This prevents amqplib from calling assertQueue() internally without parameters
+        const assertStartTime = Date.now();
+        console.log(`[RabbitMQClient] [CONSUMER] Asserting queue ${queue} before consume() at ${new Date().toISOString()}`);
+        console.log(`[RabbitMQClient] [CONSUMER] Queue options:`, JSON.stringify(queueOptions, null, 2));
+        
+        // CRITICAL: Ensure _queueChannel is open before using it
+        // If it's closed (e.g., due to 406 error), recreate it
+        if (!this._queueChannel || this._queueChannel.closed) {
+          console.warn(`[RabbitMQClient] [CONSUMER] _queueChannel is closed or null, recreating...`);
+          try {
+            this._queueChannel = await this._connection.createChannel();
+            this._queueChannel._createdAt = new Date().toISOString();
+            this._queueChannel._closeReason = null;
+            this._queueChannel._lastOperation = null;
+            
+            // Re-attach event listeners
+            this._queueChannel.on('error', (err) => {
+              console.error('[RabbitMQClient] Queue channel error:', err.message);
+              console.error('[RabbitMQClient] Error code:', err.code);
+              console.error('[RabbitMQClient] Channel created at:', this._queueChannel._createdAt);
+              console.error('[RabbitMQClient] Last operation:', this._queueChannel._lastOperation);
+              this._queueChannel._closeReason = `Error: ${err.message} (code: ${err.code})`;
+            });
+            this._queueChannel.on('close', () => {
+              console.error('[RabbitMQClient] Queue channel closed');
+              console.error('[RabbitMQClient] Channel created at:', this._queueChannel._createdAt);
+              console.error('[RabbitMQClient] Close reason:', this._queueChannel._closeReason || 'Unknown');
+              console.error('[RabbitMQClient] Last operation:', this._queueChannel._lastOperation);
+            });
+            
+            console.log(`[RabbitMQClient] [CONSUMER] ✓ _queueChannel recreated`);
+          } catch (recreateErr) {
+            console.error(`[RabbitMQClient] [CONSUMER] ✗ Failed to recreate _queueChannel:`, recreateErr.message);
+            throw new Error(`Cannot assertQueue: _queueChannel is closed and recreation failed: ${recreateErr.message}`);
+          }
+        }
+        
+        // Use queueChannel for assertQueue to avoid RPC reply queue issues
+        const channelForAssert = this._queueChannel;
+        this._queueChannel._lastOperation = `About to assertQueue ${queue}`;
+        await channelForAssert.assertQueue(queue, queueOptions);
+        this._queueChannel._lastOperation = `assertQueue ${queue} succeeded`;
+        
+        const assertEndTime = Date.now();
+        console.log(`[RabbitMQClient] [CONSUMER] ✓ Queue ${queue} asserted (took ${assertEndTime - assertStartTime}ms)`);
       }
       // Set prefetch if provided
       if (typeof prefetch === 'number') {
@@ -322,6 +388,15 @@ class RabbitMQClient extends EventEmitter {
       console.log(`[RabbitMQClient] [CONSUMER] Options: prefetch=${prefetch}, noAck=${noAck}, durable=${durable}`);
       console.log(`[RabbitMQClient] [CONSUMER] Channel state before consume: closed=${this._channel.closed}`);
       
+      // CRITICAL WARNING: amqplib's channel.consume() may internally call assertQueue() WITHOUT parameters
+      // This happens if the queue doesn't exist or if amqplib needs to verify queue existence
+      // If queue exists with different arguments (e.g., x-message-ttl), this will cause 406 PRECONDITION-FAILED
+      // and close the channel. That's why we assertQueue() with correct parameters BEFORE consume() above.
+      console.log(`[RabbitMQClient] [CONSUMER] ⚠ WARNING: About to call amqplib's channel.consume() for queue: ${queue}`);
+      console.log(`[RabbitMQClient] [CONSUMER] ⚠ WARNING: amqplib may internally call assertQueue() WITHOUT parameters if queue doesn't exist`);
+      console.log(`[RabbitMQClient] [CONSUMER] ⚠ WARNING: If queue exists with different arguments, this will cause 406 PRECONDITION-FAILED and close channel`);
+      console.log(`[RabbitMQClient] [CONSUMER] ⚠ WARNING: We already asserted queue with correct parameters above - this should prevent 406`);
+      
       const consumeResult = await this._channel.consume(
         queue,
         async (msg) => {