@onlineapps/conn-infra-mq 1.1.46 → 1.1.48

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@onlineapps/conn-infra-mq",
-    "version": "1.1.46",
+    "version": "1.1.48",
     "description": "A promise-based, broker-agnostic client for sending and receiving messages via RabbitMQ",
     "main": "src/index.js",
     "repository": {

package/src/transports/rabbitmqClient.js

@@ -211,23 +211,34 @@ class RabbitMQClient extends EventEmitter {
     try {
       // Ensure queue exists if publishing directly to queue and using default exchange
       if (!exchange) {
-        // CRITICAL: For business queues, do NOT use checkQueue() - it closes channel on 404!
-        // Business queues should already be created by setupServiceQueues() BEFORE publish is called
-        // If queue doesn't exist, that's a programming error - just proceed to publish
-        // publish() will fail with a clear error if queue doesn't exist
         const isBusinessQueue = queueConfig.isBusinessQueue(queue);
         
         if (isBusinessQueue) {
-          // Business queue - should already exist, skip checkQueue() to avoid channel closure
-          console.log(`[RabbitMQClient] DEBUG: Business queue ${queue}, skipping checkQueue() in publish() - queue should already exist`);
+          // CRITICAL: Business queues MUST exist before publish
+          // sendToQueue() automatically creates queue with DEFAULT arguments if it doesn't exist
+          // This would create queue with wrong TTL, no DLQ, etc. - we MUST prevent this!
+          // Business queues must be created via setupServiceQueues() AFTER registration
+          // Use queueChannel (regular channel) to check existence without closing channel on 404
+          try {
+            await this._queueChannel.checkQueue(queue);
+            // Queue exists - safe to publish
+            console.log(`[RabbitMQClient] ✓ Business queue ${queue} exists, publishing...`);
+          } catch (checkErr) {
+            if (checkErr.code === 404) {
+              // Queue doesn't exist - this is a programming error
+              // Business queue should have been created by setupServiceQueues() after registration
+              throw new Error(`Business queue '${queue}' does not exist. Queue must be created via setupServiceQueues() AFTER successful registration. Cannot publish to non-existent business queue (would create it with wrong arguments).`);
+            }
+            // Other error - rethrow
+            throw checkErr;
+          }
         } else {
-          // Infrastructure queue - skip assertQueue() to avoid 406 channel closure
-          // Infrastructure queues are created by monitoring consumer at startup
-          // If queue doesn't exist, publish() will fail with a clear error
-          // This matches the pattern used for business queues - early creation, no runtime checks
-          console.log(`[RabbitMQClient] DEBUG: Infrastructure queue ${queue}, skipping assertQueue() - queue should already exist (created by monitoring consumer)`);
+          // Infrastructure queue - should already exist, created by infrastructure initialization
+          // If queue doesn't exist, that's an infrastructure problem
+          console.log(`[RabbitMQClient] DEBUG: Infrastructure queue ${queue}, assuming it exists (created by infrastructure initialization)`);
         }
         // Publish using ConfirmChannel (for publisher confirms)
+        // Queue exists, so sendToQueue() won't create it with wrong arguments
         this._channel.sendToQueue(queue, buffer, { persistent, headers, routingKey });
       } else {
         // If exchange is specified, assert exchange and publish to it
@@ -271,22 +282,10 @@ class RabbitMQClient extends EventEmitter {
         
         if (isInfraQueue) {
           // Infrastructure queue - should already exist, created by infrastructure initialization
-          // Use queueChannel (regular channel) for queue operations to avoid RPC reply queue issues
-          // Only check if it exists, don't try to create or assert with arguments
-          console.log(`[RabbitMQClient] DEBUG: Infrastructure queue ${queue}, checking existence...`);
-          try {
-            await this._queueChannel.checkQueue(queue);
-            console.log(`[RabbitMQClient] DEBUG: Infrastructure queue ${queue} exists`);
-            // Queue exists - proceed to consume
-          } catch (checkErr) {
-            console.error(`[RabbitMQClient] DEBUG: checkQueue failed for infrastructure queue ${queue}:`, checkErr.message);
-            if (checkErr.code === 404) {
-              // Queue doesn't exist - infrastructure problem
-              throw new Error(`Infrastructure queue '${queue}' not found. Queue should be created during infrastructure initialization.`);
-            }
-            // Other error - rethrow
-            throw checkErr;
-          }
+          // CRITICAL: Do NOT use checkQueue() - it closes channel on 406 if queue exists with different args
+          // Just proceed to consume() - if queue doesn't exist, consume() will fail with clear error
+          // This avoids channel closure from checkQueue() on infrastructure queues
+          console.log(`[RabbitMQClient] DEBUG: Infrastructure queue ${queue}, skipping checkQueue() - queue should already exist (created by infrastructure initialization)`);
         } else {
           // Business queue - should already be created by setupServiceQueues() BEFORE consume is called
           // CRITICAL: Do NOT use checkQueue() - it closes channel on 404!