@onlineapps/conn-infra-mq 1.1.45 → 1.1.47

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@onlineapps/conn-infra-mq",
-    "version": "1.1.45",
+    "version": "1.1.47",
     "description": "A promise-based, broker-agnostic client for sending and receiving messages via RabbitMQ",
     "main": "src/index.js",
     "repository": {

package/src/layers/QueueManager.js

@@ -36,6 +36,14 @@ class QueueManager {
     if (!transport || !transport.channel) {
       throw new Error('MQ client not connected');
     }
+    
+    // CRITICAL: Business queues MUST be created via setupServiceQueues() AFTER registration
+    // Business queues should NOT be created via ensureQueue() before registration
+    // This prevents queues from being created with wrong arguments or before service is registered
+    if (queueConfig.isBusinessQueue(queueName)) {
+      throw new Error(`Business queue ${queueName} must be created via setupServiceQueues() after successful registration. Do not use ensureQueue() for business queues.`);
+    }
+    
     // Use queueChannel for queue operations to avoid RPC reply queue issues
     // queueChannel is a regular channel, not ConfirmChannel
     const channel = transport.queueChannel || transport.channel;
@@ -55,25 +63,6 @@ class QueueManager {
         console.warn(`[QueueManager] Infrastructure queue config not found for ${queueName}, using provided options:`, error.message);
         queueOptions = this._buildQueueOptions(queueName, options);
       }
-    } else if (queueConfig.isBusinessQueue(queueName)) {
-      // Business queue - use central business queue config
-      try {
-        const parsed = queueConfig.parseBusinessQueue(queueName);
-        if (parsed) {
-          const businessConfig = queueConfig.getBusinessQueueConfig(parsed.queueType, parsed.serviceName);
-          queueOptions = {
-            durable: businessConfig.durable !== false,
-            arguments: { ...businessConfig.arguments }
-          };
-        } else {
-          // Fallback to provided options
-          queueOptions = this._buildQueueOptions(queueName, options);
-        }
-      } catch (error) {
-        // If config not found, fall back to provided options
-        console.warn(`[QueueManager] Business queue config not found for ${queueName}, using provided options:`, error.message);
-        queueOptions = this._buildQueueOptions(queueName, options);
-      }
     } else {
       // Unknown queue type - use provided options
       queueOptions = this._buildQueueOptions(queueName, options);

package/src/transports/rabbitmqClient.js

@@ -211,23 +211,34 @@ class RabbitMQClient extends EventEmitter {
     try {
       // Ensure queue exists if publishing directly to queue and using default exchange
       if (!exchange) {
-        // CRITICAL: For business queues, do NOT use checkQueue() - it closes channel on 404!
-        // Business queues should already be created by setupServiceQueues() BEFORE publish is called
-        // If queue doesn't exist, that's a programming error - just proceed to publish
-        // publish() will fail with a clear error if queue doesn't exist
         const isBusinessQueue = queueConfig.isBusinessQueue(queue);
         
         if (isBusinessQueue) {
-          // Business queue - should already exist, skip checkQueue() to avoid channel closure
-          console.log(`[RabbitMQClient] DEBUG: Business queue ${queue}, skipping checkQueue() in publish() - queue should already exist`);
+          // CRITICAL: Business queues MUST exist before publish
+          // sendToQueue() automatically creates queue with DEFAULT arguments if it doesn't exist
+          // This would create queue with wrong TTL, no DLQ, etc. - we MUST prevent this!
+          // Business queues must be created via setupServiceQueues() AFTER registration
+          // Use queueChannel (regular channel) to check existence without closing channel on 404
+          try {
+            await this._queueChannel.checkQueue(queue);
+            // Queue exists - safe to publish
+            console.log(`[RabbitMQClient] ✓ Business queue ${queue} exists, publishing...`);
+          } catch (checkErr) {
+            if (checkErr.code === 404) {
+              // Queue doesn't exist - this is a programming error
+              // Business queue should have been created by setupServiceQueues() after registration
+              throw new Error(`Business queue '${queue}' does not exist. Queue must be created via setupServiceQueues() AFTER successful registration. Cannot publish to non-existent business queue (would create it with wrong arguments).`);
+            }
+            // Other error - rethrow
+            throw checkErr;
+          }
         } else {
-          // Infrastructure queue - skip assertQueue() to avoid 406 channel closure
-          // Infrastructure queues are created by monitoring consumer at startup
-          // If queue doesn't exist, publish() will fail with a clear error
-          // This matches the pattern used for business queues - early creation, no runtime checks
-          console.log(`[RabbitMQClient] DEBUG: Infrastructure queue ${queue}, skipping assertQueue() - queue should already exist (created by monitoring consumer)`);
+          // Infrastructure queue - should already exist, created by infrastructure initialization
+          // If queue doesn't exist, that's an infrastructure problem
+          console.log(`[RabbitMQClient] DEBUG: Infrastructure queue ${queue}, assuming it exists (created by infrastructure initialization)`);
         }
         // Publish using ConfirmChannel (for publisher confirms)
+        // Queue exists, so sendToQueue() won't create it with wrong arguments
         this._channel.sendToQueue(queue, buffer, { persistent, headers, routingKey });
       } else {
         // If exchange is specified, assert exchange and publish to it