@onlineapps/conn-infra-mq 1.1.34 → 1.1.35

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@onlineapps/conn-infra-mq",
-    "version": "1.1.34",
+    "version": "1.1.35",
     "description": "A promise-based, broker-agnostic client for sending and receiving messages via RabbitMQ",
     "main": "src/index.js",
     "repository": {

package/src/layers/QueueManager.js

@@ -249,27 +249,37 @@ class QueueManager {
     for (const queueInfo of queueNames) {
       // CRITICAL: Check if channel is closed before each queue operation (may have been closed by previous 406)
       // Channel closes SYNCHRONOUSLY on 406, so we must check before each assertQueue
+      // amqplib's channel.closed may be undefined, so we test by trying a no-op operation
       if (!channel) {
         console.warn(`[QueueManager] DEBUG: Channel is null before ${queueInfo.name}, recreating...`);
         channel = await transport._connection.createChannel();
         transport.queueChannel = channel;
         console.log(`[QueueManager] DEBUG: Channel recreated (was null) before ${queueInfo.name}`);
       } else {
-        // Check if channel is closed - amqplib may set closed property or throw on use
+        // Test if channel is usable by trying a no-op (checkQueue on a known queue)
+        // This will throw if channel is closed
+        let channelUsable = false;
         try {
-          // Try a no-op to see if channel is usable
-          if (channel.closed === true) {
-            console.warn(`[QueueManager] DEBUG: Channel is closed before ${queueInfo.name}, recreating...`);
+          // Try to check a queue that definitely exists (workflow.init) - this tests channel usability
+          // If channel is closed, this will throw immediately
+          await channel.checkQueue('workflow.init');
+          channelUsable = true;
+          console.log(`[QueueManager] DEBUG: Channel is usable before ${queueInfo.name}`);
+        } catch (testErr) {
+          // Channel is closed or unusable - recreate it
+          console.warn(`[QueueManager] DEBUG: Channel test failed before ${queueInfo.name} (${testErr.message}), recreating...`);
+          try {
             channel = await transport._connection.createChannel();
             transport.queueChannel = channel;
-            console.log(`[QueueManager] DEBUG: Channel recreated (was closed) before ${queueInfo.name}`);
+            console.log(`[QueueManager] DEBUG: Channel recreated (test failed) before ${queueInfo.name}`);
+            channelUsable = true;
+          } catch (recreateErr) {
+            throw new Error(`Failed to recreate channel before ${queueInfo.name}: ${recreateErr.message}`);
           }
-        } catch (checkErr) {
-          // Channel may throw on access if closed - recreate it
-          console.warn(`[QueueManager] DEBUG: Channel check failed before ${queueInfo.name}, recreating...`);
-          channel = await transport._connection.createChannel();
-          transport.queueChannel = channel;
-          console.log(`[QueueManager] DEBUG: Channel recreated (check failed) before ${queueInfo.name}`);
+        }
+        
+        if (!channelUsable) {
+          throw new Error(`Channel is not usable before ${queueInfo.name} and recreation failed`);
         }
       }