@onlineapps/conn-infra-mq 1.1.29 → 1.1.31

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@onlineapps/conn-infra-mq",
-    "version": "1.1.29",
+    "version": "1.1.31",
     "description": "A promise-based, broker-agnostic client for sending and receiving messages via RabbitMQ",
     "main": "src/index.js",
     "repository": {

package/src/layers/QueueManager.js

@@ -294,12 +294,16 @@ class QueueManager {
       }
       
       // CRITICAL: Use assertQueue directly - if queue exists with different args (406), that's OK
-      // We'll handle it gracefully, but channel should NOT close
+      // BUT: 406 PRECONDITION-FAILED closes the channel in amqplib!
+      // Solution: Catch 406, recreate channel, and continue
       try {
         // Check if channel is still open before each operation
         if (!channel || channel.closed) {
-          console.error(`[QueueManager] DEBUG: Channel closed before creating ${queueName}`);
-          throw new Error(`Channel closed before creating ${queueName} - cannot continue`);
+          console.error(`[QueueManager] DEBUG: Channel closed before creating ${queueName}, recreating...`);
+          // Recreate channel if closed
+          channel = await transport._connection.createChannel();
+          transport.queueChannel = channel;
+          console.log(`[QueueManager] DEBUG: Channel recreated for ${queueName}`);
         }
         
         console.log(`[QueueManager] DEBUG: About to assertQueue ${queueName} with options:`, JSON.stringify(queueOptions, null, 2));
@@ -313,22 +317,36 @@ class QueueManager {
       } catch (assertErr) {
         console.error(`[QueueManager] DEBUG: assertQueue failed for ${queueName}:`, assertErr.message);
         console.error(`[QueueManager] DEBUG: Error code: ${assertErr.code}, channel closed: ${channel ? channel.closed : 'N/A'}`);
-        console.error(`[QueueManager] DEBUG: Stack trace:`, assertErr.stack);
         
-        // If channel closed, this is a critical error
-        if (!channel || channel.closed) {
-          console.error(`[QueueManager] DEBUG: Channel was closed during assertQueue for ${queueName}`);
-          throw new Error(`Channel closed during assertQueue for ${queueName} - cannot create remaining queues`);
-        }
-        
-        // If 406 PRECONDITION-FAILED, queue exists with different args - use it as-is
-        // CRITICAL: Do NOT use checkQueue() here - it closes channel on 404!
-        // If assertQueue() returned 406, queue exists (just with different args) - that's OK
+        // If 406 PRECONDITION-FAILED, queue exists with different args - channel is closed, recreate it
+        // CRITICAL: amqplib closes channel on 406, so we MUST recreate it to continue
         if (assertErr.code === 406) {
-          console.warn(`[QueueManager] Queue ${queueName} exists with different arguments, using as-is:`, assertErr.message);
+          console.warn(`[QueueManager] Queue ${queueName} exists with different arguments (406), channel closed. Recreating channel...`);
+          
+          // Recreate channel - 406 closes it
+          try {
+            channel = await transport._connection.createChannel();
+            transport.queueChannel = channel;
+            console.log(`[QueueManager] DEBUG: Channel recreated after 406 for ${queueName}, channel closed=${channel.closed}`);
+          } catch (recreateErr) {
+            throw new Error(`Failed to recreate channel after 406 for ${queueName}: ${recreateErr.message}`);
+          }
+          
           // Queue exists (just with different args) - accept it
           queues[queueInfo.type] = queueName;
         } else {
+          // Other error - check if channel closed
+          if (!channel || channel.closed) {
+            console.error(`[QueueManager] DEBUG: Channel was closed during assertQueue for ${queueName}`);
+            // Try to recreate channel
+            try {
+              channel = await transport._connection.createChannel();
+              transport.queueChannel = channel;
+              console.log(`[QueueManager] DEBUG: Channel recreated after error for ${queueName}`);
+            } catch (recreateErr) {
+              throw new Error(`Channel closed during assertQueue for ${queueName} and failed to recreate: ${recreateErr.message}`);
+            }
+          }
           // Other error - critical, cannot continue
           throw new Error(`Failed to create business queue ${queueName}: ${assertErr.message}`);
         }
@@ -336,25 +354,62 @@ class QueueManager {
     }
 
     // Setup DLQ exchange and bindings
-    await channel.assertExchange(this.config.dlxExchange, 'direct', {
-      durable: true
-    });
+    console.log(`[QueueManager] DEBUG: Setting up DLQ exchange: ${this.config.dlxExchange}`);
+    console.log(`[QueueManager] DEBUG: Channel state before assertExchange: closed=${channel.closed}`);
+    
+    try {
+      await channel.assertExchange(this.config.dlxExchange, 'direct', {
+        durable: true
+      });
+      console.log(`[QueueManager] DEBUG: DLQ exchange asserted, channel closed=${channel.closed}`);
+    } catch (exErr) {
+      console.error(`[QueueManager] DEBUG: assertExchange failed:`, exErr.message);
+      if (!channel || channel.closed) {
+        throw new Error(`Channel closed during assertExchange for ${this.config.dlxExchange}`);
+      }
+      throw exErr;
+    }
 
     // Bind DLQ
-    await channel.bindQueue(
-      queues.dlq,
-      this.config.dlxExchange,
-      `${serviceName}.queue.dlq`
-    );
-
-    if (queues.workflow) {
+    console.log(`[QueueManager] DEBUG: Binding DLQ: ${queues.dlq} to ${this.config.dlxExchange}`);
+    console.log(`[QueueManager] DEBUG: Channel state before bindQueue: closed=${channel.closed}`);
+    
+    try {
       await channel.bindQueue(
         queues.dlq,
         this.config.dlxExchange,
-        `${serviceName}.workflow.dlq`
+        `${serviceName}.queue.dlq`
       );
+      console.log(`[QueueManager] DEBUG: DLQ bound, channel closed=${channel.closed}`);
+    } catch (bindErr) {
+      console.error(`[QueueManager] DEBUG: bindQueue failed:`, bindErr.message);
+      if (!channel || channel.closed) {
+        throw new Error(`Channel closed during bindQueue for ${queues.dlq}`);
+      }
+      throw bindErr;
+    }
+
+    if (queues.workflow) {
+      console.log(`[QueueManager] DEBUG: Binding workflow DLQ: ${queues.dlq} to ${this.config.dlxExchange}`);
+      console.log(`[QueueManager] DEBUG: Channel state before workflow bindQueue: closed=${channel.closed}`);
+      
+      try {
+        await channel.bindQueue(
+          queues.dlq,
+          this.config.dlxExchange,
+          `${serviceName}.workflow.dlq`
+        );
+        console.log(`[QueueManager] DEBUG: Workflow DLQ bound, channel closed=${channel.closed}`);
+      } catch (bindErr) {
+        console.error(`[QueueManager] DEBUG: workflow bindQueue failed:`, bindErr.message);
+        if (!channel || channel.closed) {
+          throw new Error(`Channel closed during workflow bindQueue`);
+        }
+        throw bindErr;
+      }
     }
 
+    console.log(`[QueueManager] DEBUG: setupServiceQueues completed successfully, channel closed=${channel.closed}`);
     return queues;
   }