@onlineapps/conn-infra-mq 1.1.28 → 1.1.30

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@onlineapps/conn-infra-mq",
-    "version": "1.1.28",
+    "version": "1.1.30",
     "description": "A promise-based, broker-agnostic client for sending and receiving messages via RabbitMQ",
     "main": "src/index.js",
     "repository": {

package/src/layers/QueueManager.js

@@ -336,25 +336,62 @@ class QueueManager {
     }
 
     // Setup DLQ exchange and bindings
-    await channel.assertExchange(this.config.dlxExchange, 'direct', {
-      durable: true
-    });
+    console.log(`[QueueManager] DEBUG: Setting up DLQ exchange: ${this.config.dlxExchange}`);
+    console.log(`[QueueManager] DEBUG: Channel state before assertExchange: closed=${channel.closed}`);
+    
+    try {
+      await channel.assertExchange(this.config.dlxExchange, 'direct', {
+        durable: true
+      });
+      console.log(`[QueueManager] DEBUG: DLQ exchange asserted, channel closed=${channel.closed}`);
+    } catch (exErr) {
+      console.error(`[QueueManager] DEBUG: assertExchange failed:`, exErr.message);
+      if (!channel || channel.closed) {
+        throw new Error(`Channel closed during assertExchange for ${this.config.dlxExchange}`);
+      }
+      throw exErr;
+    }
 
     // Bind DLQ
-    await channel.bindQueue(
-      queues.dlq,
-      this.config.dlxExchange,
-      `${serviceName}.queue.dlq`
-    );
-
-    if (queues.workflow) {
+    console.log(`[QueueManager] DEBUG: Binding DLQ: ${queues.dlq} to ${this.config.dlxExchange}`);
+    console.log(`[QueueManager] DEBUG: Channel state before bindQueue: closed=${channel.closed}`);
+    
+    try {
       await channel.bindQueue(
         queues.dlq,
         this.config.dlxExchange,
-        `${serviceName}.workflow.dlq`
+        `${serviceName}.queue.dlq`
       );
+      console.log(`[QueueManager] DEBUG: DLQ bound, channel closed=${channel.closed}`);
+    } catch (bindErr) {
+      console.error(`[QueueManager] DEBUG: bindQueue failed:`, bindErr.message);
+      if (!channel || channel.closed) {
+        throw new Error(`Channel closed during bindQueue for ${queues.dlq}`);
+      }
+      throw bindErr;
+    }
+
+    if (queues.workflow) {
+      console.log(`[QueueManager] DEBUG: Binding workflow DLQ: ${queues.dlq} to ${this.config.dlxExchange}`);
+      console.log(`[QueueManager] DEBUG: Channel state before workflow bindQueue: closed=${channel.closed}`);
+      
+      try {
+        await channel.bindQueue(
+          queues.dlq,
+          this.config.dlxExchange,
+          `${serviceName}.workflow.dlq`
+        );
+        console.log(`[QueueManager] DEBUG: Workflow DLQ bound, channel closed=${channel.closed}`);
+      } catch (bindErr) {
+        console.error(`[QueueManager] DEBUG: workflow bindQueue failed:`, bindErr.message);
+        if (!channel || channel.closed) {
+          throw new Error(`Channel closed during workflow bindQueue`);
+        }
+        throw bindErr;
+      }
     }
 
+    console.log(`[QueueManager] DEBUG: setupServiceQueues completed successfully, channel closed=${channel.closed}`);
     return queues;
   }
 

package/src/transports/rabbitmqClient.js

@@ -154,19 +154,29 @@ class RabbitMQClient extends EventEmitter {
     try {
       // Ensure queue exists if publishing directly to queue and using default exchange
       if (!exchange) {
-        // Use queueChannel (regular channel) for queue operations to avoid RPC reply queue issues
-        // Use central config for infrastructure queues
-        const queueOptions = this._getQueueOptions(queue);
-        try {
-          await this._queueChannel.checkQueue(queue);
-          // Queue exists - proceed to publish
-        } catch (checkErr) {
-          // If queue doesn't exist (404), create it
-          if (checkErr.code === 404) {
-            await this._queueChannel.assertQueue(queue, queueOptions);
-          } else {
-            // Other error (including 406) - queue exists with different args, proceed
-            console.warn(`[RabbitMQClient] Queue ${queue} exists with different arguments, using as-is`);
+        // CRITICAL: For business queues, do NOT use checkQueue() - it closes channel on 404!
+        // Business queues should already be created by setupServiceQueues() BEFORE publish is called
+        // If queue doesn't exist, that's a programming error - just proceed to publish
+        // publish() will fail with a clear error if queue doesn't exist
+        const isBusinessQueue = queueConfig.isBusinessQueue(queue);
+        
+        if (isBusinessQueue) {
+          // Business queue - should already exist, skip checkQueue() to avoid channel closure
+          console.log(`[RabbitMQClient] DEBUG: Business queue ${queue}, skipping checkQueue() in publish() - queue should already exist`);
+        } else {
+          // Infrastructure queue - check if it exists
+          const queueOptions = this._getQueueOptions(queue);
+          try {
+            await this._queueChannel.checkQueue(queue);
+            // Queue exists - proceed to publish
+          } catch (checkErr) {
+            // If queue doesn't exist (404), create it
+            if (checkErr.code === 404) {
+              await this._queueChannel.assertQueue(queue, queueOptions);
+            } else {
+              // Other error (including 406) - queue exists with different args, proceed
+              console.warn(`[RabbitMQClient] Queue ${queue} exists with different arguments, using as-is`);
+            }
           }
         }
         // Publish using ConfirmChannel (for publisher confirms)