@onlineapps/conn-infra-mq 1.1.23 → 1.1.25

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@onlineapps/conn-infra-mq",
-    "version": "1.1.23",
+    "version": "1.1.25",
     "description": "A promise-based, broker-agnostic client for sending and receiving messages via RabbitMQ",
     "main": "src/index.js",
     "repository": {

package/src/layers/QueueManager.js

@@ -311,18 +311,12 @@ class QueueManager {
         }
         
         // If 406 PRECONDITION-FAILED, queue exists with different args - use it as-is
+        // CRITICAL: Do NOT use checkQueue() here - it closes channel on 404!
+        // If assertQueue() returned 406, queue exists (just with different args) - that's OK
         if (assertErr.code === 406) {
           console.warn(`[QueueManager] Queue ${queueName} exists with different arguments, using as-is:`, assertErr.message);
-          // Verify queue exists
-          if (!channel || channel.closed) {
-            throw new Error(`Channel closed after 406 error for ${queueName}`);
-          }
-          try {
-            await channel.checkQueue(queueName);
-            queues[queueInfo.type] = queueName;
-          } catch (checkErr) {
-            throw new Error(`Failed to verify existing queue ${queueName}: ${checkErr.message}`);
-          }
+          // Queue exists (just with different args) - accept it
+          queues[queueInfo.type] = queueName;
         } else {
           // Other error - critical, cannot continue
           throw new Error(`Failed to create business queue ${queueName}: ${assertErr.message}`);

package/src/transports/rabbitmqClient.js

@@ -223,25 +223,10 @@ class RabbitMQClient extends EventEmitter {
           }
         } else {
           // Business queue - should already be created by setupServiceQueues() BEFORE consume is called
-          // Use queueChannel (regular channel) for queue operations to avoid RPC reply queue issues
-          // Only check if it exists - don't try to create it here (that's setupServiceQueues() responsibility)
-          try {
-            await this._queueChannel.checkQueue(queue);
-            // Queue exists - proceed to consume
-          } catch (checkErr) {
-            if (checkErr.code === 404) {
-              // Queue doesn't exist - this is an error, queue should have been created by setupServiceQueues()
-              throw new Error(`Business queue '${queue}' not found. Queue should be created by setupServiceQueues() before consuming.`);
-            }
-            // Other error (including 406) - queue exists with different args, use it as-is
-            if (checkErr.code === 406) {
-              console.warn(`[RabbitMQClient] Queue ${queue} exists with different arguments, using as-is:`, checkErr.message);
-              // Proceed to consume - queue exists, just with different args
-            } else {
-              // Other error - rethrow
-              throw checkErr;
-            }
-          }
+          // CRITICAL: Do NOT use checkQueue() - it closes channel on 404!
+          // If queue doesn't exist, that's a programming error (setupServiceQueues() should have created it)
+          // Just proceed to consume - if queue doesn't exist, consume will fail with a clear error
+          // This avoids channel closure from checkQueue() on non-existent queues
         }
       }
       // Set prefetch if provided