@onlineapps/conn-infra-mq 1.1.20 → 1.1.21

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@onlineapps/conn-infra-mq",
-    "version": "1.1.20",
+    "version": "1.1.21",
     "description": "A promise-based, broker-agnostic client for sending and receiving messages via RabbitMQ",
     "main": "src/index.js",
     "repository": {

package/src/layers/QueueManager.js

@@ -103,17 +103,40 @@ class QueueManager {
         throw new Error('Channel closed during checkQueue - cannot verify queue');
       }
       
-      // If queue doesn't exist (404), we'll let it be created lazily on first publish
-      // This avoids RPC reply queue issues with assertQueue()
+      // If queue doesn't exist (404), create it using assertQueue with proper error handling
+      // Business queues MUST be created with specific arguments (TTL, DLQ, max-length) from queueConfig
+      // Lazy creation via sendToQueue() is NOT suitable - it creates queue with default arguments
       if (checkErr.code === 404) {
-        // Queue doesn't exist - will be created on first sendToQueue()
-        // Return a mock queue info to indicate queue will be created lazily
-        console.info(`[QueueManager] Queue ${queueName} doesn't exist - will be created on first publish`);
-        return {
-          queue: queueName,
-          messageCount: 0,
-          consumerCount: 0
-        };
+        // CRITICAL: Business queues MUST be created explicitly with correct arguments
+        // Use assertQueue() on regular channel (queueChannel) - this should work without RPC issues
+        // If it fails, it's a real problem that needs to be fixed, not worked around
+        try {
+          if (!channel || channel.closed) {
+            throw new Error('Channel closed - cannot create queue');
+          }
+          
+          // For business queues: use assertQueue with queueOptions from queueConfig
+          // This ensures correct TTL, DLQ, max-length arguments
+          return await channel.assertQueue(queueName, queueOptions);
+        } catch (assertErr) {
+          // If channel closed during assertQueue, it's a real error
+          if (!channel || channel.closed) {
+            throw new Error(`Channel closed during assertQueue for ${queueName} - check channel management`);
+          }
+          
+          // If 406 PRECONDITION-FAILED, queue exists with different args
+          if (assertErr.code === 406) {
+            console.warn(`[QueueManager] Queue ${queueName} exists with different arguments:`, assertErr.message);
+            // Try to get queue info anyway
+            if (!channel || channel.closed) {
+              throw new Error('Channel closed - cannot check existing queue');
+            }
+            return await channel.checkQueue(queueName);
+          }
+          
+          // Other errors - rethrow
+          throw assertErr;
+        }
       } else {
         // Other error (including 406) - queue exists with different args
         // Log warning and return queue info without asserting

package/src/transports/rabbitmqClient.js

@@ -222,23 +222,24 @@ class RabbitMQClient extends EventEmitter {
             throw checkErr;
           }
         } else {
-          // Business queue - may need to be created, but use unified config
+          // Business queue - should already be created by setupServiceQueues() BEFORE consume is called
           // Use queueChannel (regular channel) for queue operations to avoid RPC reply queue issues
-          const queueOptions = this._getQueueOptions(queue, { durable });
-          
-          // Try to assert queue with our config
-          // If it fails with 406 (PRECONDITION-FAILED), queue exists with different args - use it as-is
-          // IMPORTANT: Don't try to re-assert after 406, as it will close the channel
+          // Only check if it exists - don't try to create it here (that's setupServiceQueues() responsibility)
           try {
-            await this._queueChannel.assertQueue(queue, queueOptions);
-          } catch (assertErr) {
-            // If queue exists with different arguments (406), use it as-is without re-asserting
-            if (assertErr.code === 406) {
-              console.warn(`[RabbitMQClient] Queue ${queue} exists with different arguments, using as-is (skipping assert to avoid channel close):`, assertErr.message);
-              // Don't try to re-assert - just proceed to consume
+            await this._queueChannel.checkQueue(queue);
+            // Queue exists - proceed to consume
+          } catch (checkErr) {
+            if (checkErr.code === 404) {
+              // Queue doesn't exist - this is an error, queue should have been created by setupServiceQueues()
+              throw new Error(`Business queue '${queue}' not found. Queue should be created by setupServiceQueues() before consuming.`);
+            }
+            // Other error (including 406) - queue exists with different args, use it as-is
+            if (checkErr.code === 406) {
+              console.warn(`[RabbitMQClient] Queue ${queue} exists with different arguments, using as-is:`, checkErr.message);
+              // Proceed to consume - queue exists, just with different args
             } else {
               // Other error - rethrow
-              throw assertErr;
+              throw checkErr;
             }
           }
         }