@onlineapps/conn-base-cache 1.0.3 → 1.0.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onlineapps/conn-base-cache",
-  "version": "1.0.3",
+  "version": "1.0.5",
   "description": "Redis cache connector with TTL, invalidation, and namespace support for OA Drive microservices",
   "main": "src/index.js",
   "scripts": {
@@ -20,7 +20,7 @@
   "author": "OA Drive Team",
   "license": "MIT",
   "dependencies": {
-    "@onlineapps/runtime-config": "1.0.1",
+    "@onlineapps/runtime-config": "1.0.2",
     "ioredis": "^5.3.2"
   },
   "devDependencies": {

package/src/config.js

@@ -26,9 +26,9 @@ const DEFAULTS = require('./defaults');
 const runtimeCfg = createRuntimeConfig({
   defaults: DEFAULTS,
   schema: {
-    // Connection settings (dev-friendly defaults, ENV override)
-    host: { env: 'REDIS_HOST', defaultKey: 'defaultHost' },
-    port: { env: 'REDIS_PORT', defaultKey: 'defaultPort', type: 'number' },
+    // Redis topology (FAIL-FAST)
+    host: { env: 'REDIS_HOST', required: true },
+    port: { env: 'REDIS_PORT', required: true, type: 'number' },
     password: { env: 'REDIS_PASSWORD' },
     db: { env: 'REDIS_DB', defaultKey: 'defaultDb', type: 'number' },
 

package/src/defaults.js

@@ -4,13 +4,11 @@
  * Module-owned defaults for @onlineapps/conn-base-cache.
  *
  * Ownership rule:
- * - Defaults that belong to this cache connector live here (host/port for dev/test, TTL, retry policy, key prefix, db).
+ * - Defaults that belong to this cache connector live here (TTL, retry policy, key prefix, db).
  * - Callers can override via explicit config or environment variables.
  */
 
 module.exports = {
-  defaultHost: 'localhost',
-  defaultPort: 6379,
   keyPrefix: 'cache:',
   defaultDb: 0,
   defaultTTLSeconds: 3600,

package/src/index.js

@@ -23,11 +23,8 @@ const runtimeCfg = require('./config');
  * @class CacheConnector
  *
  * @example <caption>Basic Usage</caption>
- * const cache = new CacheConnector({
- *   host: 'localhost',
- *   port: 6379,
- *   defaultTTL: 3600
- * });
+ * // FAIL-FAST: requires REDIS_HOST and REDIS_PORT env (or pass explicit host/port)
+ * const cache = new CacheConnector({ defaultTTL: 3600 });
  * await cache.connect();
  * await cache.set('user:123', { name: 'John' }, 600);
  * const user = await cache.get('user:123');
@@ -44,8 +41,8 @@ class CacheConnector {
    *
    * @constructor
    * @param {Object} [config={}] - Configuration options
-   * @param {string} [config.host='localhost'] - Redis server host
-   * @param {number} [config.port=6379] - Redis server port
+   * @param {string} config.host - Redis server host (or set REDIS_HOST env)
+   * @param {number} config.port - Redis server port (or set REDIS_PORT env)
    * @param {string} [config.password] - Redis password for authentication
    * @param {number} [config.db=0] - Redis database number to use
    * @param {number} [config.defaultTTL=3600] - Default TTL in seconds for cached items
@@ -59,8 +56,8 @@ class CacheConnector {
    *
    * @example <caption>Full Configuration</caption>
    * const cache = new CacheConnector({
-   *   host: 'redis.example.com',
-   *   port: 6380,
+   *   host: 'redis.internal',
+   *   port: 6379,
    *   password: 'secret',
    *   namespace: 'my-service',
    *   defaultTTL: 1800,
@@ -877,8 +874,8 @@ class CacheConnector {
 
 /**
  * @typedef {Object} CacheConfig
- * @property {string} [host='localhost'] - Redis host
- * @property {number} [port=6379] - Redis port
+ * @property {string} host - Redis host (or set REDIS_HOST env)
+ * @property {number} port - Redis port (or set REDIS_PORT env)
  * @property {string} [password] - Redis password
  * @property {number} [db=0] - Redis database
  * @property {number} [defaultTTL=3600] - Default TTL in seconds
@@ -932,7 +929,7 @@ module.exports = CacheConnector;
  *
  * @example
  * const cache = CacheConnector.create({
- *   host: 'localhost',
+ *   // FAIL-FAST: requires REDIS_HOST + REDIS_PORT env (or pass host + port)
  *   namespace: 'my-service'
  * });
  */

package/tests/integration/cache.integration.test.js

@@ -8,11 +8,11 @@
 const CacheConnector = require('../../src/index');
 
 const SKIP_INTEGRATION = process.env.SKIP_INTEGRATION === 'true';
-const REDIS_HOST = process.env.REDIS_HOST || 'localhost';
-const REDIS_PORT = process.env.REDIS_PORT || 6379;
+const REDIS_HOST = process.env.REDIS_HOST;
+const REDIS_PORT = process.env.REDIS_PORT ? parseInt(process.env.REDIS_PORT, 10) : undefined;
 
 describe('CacheConnector - Integration Tests @integration', () => {
-  if (SKIP_INTEGRATION) {
+  if (SKIP_INTEGRATION || !REDIS_HOST || !REDIS_PORT) {
     it.skip('Skipping integration tests (SKIP_INTEGRATION=true)', () => {});
     return;
   }

package/tests/unit/CacheConnector.edge.test.js

@@ -12,8 +12,18 @@ const CacheConnector = require('../../src/index');
 describe('CacheConnector - Edge Cases & Full Coverage @unit', () => {
   let cacheConnector;
   let mockRedisClient;
+  let oldEnv;
 
   beforeEach(() => {
+    oldEnv = {
+      REDIS_HOST: process.env.REDIS_HOST,
+      REDIS_PORT: process.env.REDIS_PORT,
+      REDIS_PASSWORD: process.env.REDIS_PASSWORD,
+      REDIS_DB: process.env.REDIS_DB,
+    };
+    process.env.REDIS_HOST = '127.0.0.1';
+    process.env.REDIS_PORT = '6379';
+
     mockRedisClient = {
       get: jest.fn(),
       set: jest.fn(),
@@ -39,13 +49,17 @@ describe('CacheConnector - Edge Cases & Full Coverage @unit', () => {
 
   afterEach(() => {
     jest.clearAllMocks();
+    for (const k of Object.keys(oldEnv)) {
+      if (oldEnv[k] === undefined) delete process.env[k];
+      else process.env[k] = oldEnv[k];
+    }
   });
 
   describe('Constructor Edge Cases', () => {
     it('should handle undefined config', () => {
       const cache = new CacheConnector(undefined);
       expect(cache.config).toBeDefined();
-      expect(cache.config.host).toBe('localhost');
+      expect(cache.config.host).toBe('127.0.0.1');
     });
 
     it('should handle null config', () => {
@@ -87,7 +101,7 @@ describe('CacheConnector - Edge Cases & Full Coverage @unit', () => {
 
   describe('Connection Edge Cases', () => {
     beforeEach(() => {
-      cacheConnector = new CacheConnector({ host: 'localhost', port: 6379 });
+      cacheConnector = new CacheConnector({ host: '127.0.0.1', port: 6379 });
     });
 
     it('should handle connection timeout', async () => {

package/tests/unit/CacheConnector.test.js

@@ -12,8 +12,18 @@ const CacheConnector = require('../../src/index');
 describe('CacheConnector - Unit Tests @unit', () => {
   let cacheConnector;
   let mockRedisClient;
+  let oldEnv;
 
   beforeEach(() => {
+    oldEnv = {
+      REDIS_HOST: process.env.REDIS_HOST,
+      REDIS_PORT: process.env.REDIS_PORT,
+      REDIS_PASSWORD: process.env.REDIS_PASSWORD,
+      REDIS_DB: process.env.REDIS_DB,
+    };
+    process.env.REDIS_HOST = '127.0.0.1';
+    process.env.REDIS_PORT = '6379';
+
     // Create mock Redis client with all methods
     mockRedisClient = {
       get: jest.fn(),
@@ -43,12 +53,16 @@ describe('CacheConnector - Unit Tests @unit', () => {
 
   afterEach(() => {
     jest.clearAllMocks();
+    for (const k of Object.keys(oldEnv)) {
+      if (oldEnv[k] === undefined) delete process.env[k];
+      else process.env[k] = oldEnv[k];
+    }
   });
 
   describe('constructor', () => {
     it('should initialize with default configuration', () => {
       const cache = new CacheConnector();
-      expect(cache.config.host).toBe('localhost');
+      expect(cache.config.host).toBe('127.0.0.1');
       expect(cache.config.port).toBe(6379);
       expect(cache.config.keyPrefix).toBe('cache:');
       expect(cache.config.defaultTTL).toBe(3600);