@onewelcome/react-lib-components 0.2.3 → 0.2.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onewelcome/react-lib-components",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "license": "Apache-2.0",
   "author": "OneWelcome B.V.",
   "main": "dist/index.js",
@@ -18,7 +18,7 @@
     "build": "dts build",
     "build-storybook": "build-storybook",
     "dev": "npm-run-all -p start test:watch storybook",
-    "lint": "eslint --fix 'src/**/*.{ts,tsx}'",
+    "lint": "eslint --fix '**/*.{ts,tsx}'",
     "prepare": "husky install && dts build",
     "size": "size-limit",
     "start": "dts watch",

package/src/ContextMenu/ContextMenu.test.tsx

@@ -85,7 +85,7 @@ describe("ContextMenu should render", () => {
 
     const child = getByRole("menuitem");
 
-    expect(child).toHaveClass("custom");
+    expect(child.parentElement).toHaveClass("custom");
   });
 
   it("should throw an error", () => {

package/src/ContextMenu/ContextMenuItem.tsx

@@ -46,8 +46,9 @@ export const ContextMenuItem = React.forwardRef<HTMLButtonElement, Props>(
     }, [hasFocus, innerButtonRef, contextMenuOpened]);
 
     return (
-      <li role="menuitem" className={`${classes["context-menu-item"]} ${className ?? ""}`}>
+      <li role="none" className={`${classes["context-menu-item"]} ${className ?? ""}`}>
         <button
+          role="menuitem"
           {...rest}
           ref={innerButtonRef}
           data-focus={hasFocus}

package/src/DataGrid/DataGrid.tsx

@@ -8,7 +8,7 @@ import { ColumnName, HeaderCell, OnSortFunction, Sort } from "./datagrid.interfa
 import { Pagination, Props as PaginationProps } from "../Pagination/Pagination";
 import { Spacing, useSpacing } from "../hooks/useSpacing";
 
-export interface Props<T> extends ComponentPropsWithRef<"div"> {
+export interface Props<T> extends Omit<ComponentPropsWithRef<"div">, "children"> {
   children: ({ item, index }: { item: T; index: number }) => ReactElement;
   data?: T[];
   initialSort?: Sort;

package/src/DataGrid/DataGridBody/DataGridRow.tsx

@@ -23,7 +23,7 @@ export const DataGridRow = React.forwardRef<HTMLTableRowElement, Props>(
           disableContextMenuColumn
         });
 
-        const visible = headers?.length! > index ? !headers![index].hidden : true;
+        const visible = headers && headers.length > index ? !headers[index].hidden : true;
         return visible && cellWithSpacing;
       }
       return null;

package/src/Form/form.interfaces.ts

@@ -11,5 +11,5 @@ export interface FormSelector extends FormElement {
 /** Default form elements */
 export interface FormElement {
   error?: boolean;
-  [dataAttribute: DataAttributeKey]: any;
+  [dataAttribute: DataAttributeKey]: unknown;
 }

package/src/Link/types.d.ts

@@ -2,7 +2,7 @@ import * as H from "history";
 
 export interface LinkProps<S = H.LocationState>
   extends React.AnchorHTMLAttributes<HTMLAnchorElement> {
-  component?: React.ComponentType<any> | undefined;
+  component?: React.ComponentType<unknown> | undefined;
   to: H.LocationDescriptor<S> | ((location: H.Location<S>) => H.LocationDescriptor<S>);
   replace?: boolean | undefined;
   innerRef?: React.Ref<HTMLAnchorElement> | undefined;

package/src/hooks/usePosition.ts

@@ -8,7 +8,7 @@ export interface ConfigObject {
   offset?: Offset;
 }
 
-export type HorizontalPlacment = "left" | "center" | "centerh" | "right";
+export type HorizontalPlacement = "left" | "center" | "centerh" | "right";
 export type VerticalPlacement = "top" | "center" | "centerv" | "bottom";
 
 type Axis = "vertical" | "horizontal";
@@ -29,7 +29,7 @@ interface DomRectObject {
 }
 
 export interface Placement {
-  horizontal: HorizontalPlacment;
+  horizontal: HorizontalPlacement;
   vertical: VerticalPlacement;
 }
 
@@ -73,6 +73,7 @@ const defaultConfigObject: ConfigObject = {
   }
 };
 
+/* eslint-disable @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-non-null-asserted-optional-chain*/
 export const usePosition = (providedConfigObject: ConfigObject = defaultConfigObject) => {
   const configObject = { ...defaultConfigObject, ...providedConfigObject };
 
@@ -198,7 +199,7 @@ export const usePosition = (providedConfigObject: ConfigObject = defaultConfigOb
     transformOrigin: Placement,
     requestedReturnValue: Axis,
     relEl: DomRectObject,
-    placementOriginDefinition: HorizontalPlacment | VerticalPlacement,
+    placementOriginDefinition: HorizontalPlacement | VerticalPlacement,
     elDimensions: Dimensions
   ) => {
     let value = 0;
@@ -236,13 +237,13 @@ export const usePosition = (providedConfigObject: ConfigObject = defaultConfigOb
       return "centerv";
     }
     throw new Error(
-      `the requested return value isn\'t "vertical" or "horizontal" ${requestedReturnValue} was given.`
+      `the requested return value isn't "vertical" or "horizontal" ${requestedReturnValue} was given.`
     );
   };
 
   const _calculatePlacementValue = (
     transformOrigin: Placement,
-    placement: HorizontalPlacment | VerticalPlacement,
+    placement: HorizontalPlacement | VerticalPlacement,
     requestedReturnValue: Axis,
     relEl: DomRectObject,
     elDimensions: Dimensions

package/src/interfaces.ts

@@ -1,5 +1,5 @@
 export type DataAttributeKey = `data-${string}`;
 
 export interface KeyValuePair {
-  [dataAttribute: DataAttributeKey]: any;
+  [dataAttribute: DataAttributeKey]: unknown;
 }