@onewelcome/react-lib-components 0.1.3-alpha → 0.1.4-alpha

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onewelcome/react-lib-components",
-  "version": "0.1.3-alpha",
+  "version": "0.1.4-alpha",
   "license": "Apache-2.0",
   "author": "OneWelcome B.V.",
   "main": "dist/index.js",

package/src/Form/FormGroup/FormGroup.test.tsx

@@ -85,3 +85,27 @@ describe('Correct error state', () => {
     expect(errorMessage?.querySelector('#error_id')).toHaveTextContent('example error message');
   });
 });
+
+describe('no helpertext, but errorMessage is defined', () => {
+  it("doesn't show the div with 'default-helper' class when there's no error and no helpertext defined", () => {
+    const { formgroup } = createFormGroup((defaultParams) => ({
+      ...defaultParams,
+      error: false,
+      helperText: undefined,
+      errorMessage: 'example error message',
+    }));
+
+    expect(formgroup.querySelector('.default-helper')).toBeFalsy();
+  });
+
+  it("does show the div with 'default-helper' class when there's an error and no helpertext defined", () => {
+    const { formgroup } = createFormGroup((defaultParams) => ({
+      ...defaultParams,
+      error: true,
+      helperText: undefined,
+      errorMessage: 'example error message',
+    }));
+
+    expect(formgroup.querySelector('.default-helper')).toBeTruthy();
+  });
+});

package/src/Form/FormGroup/FormGroup.tsx

@@ -45,7 +45,7 @@ export const FormGroup = React.forwardRef<HTMLDivElement, Props>(
       >
         {children}
 
-        {(helperText || errorMessage) && (
+        {(helperText || (errorMessage && error)) && (
           <div
             style={{ marginLeft: `${helperIndent}px` }}
             className={`${classes['default-helper']} ${

package/src/Link/Link.tsx

@@ -1,11 +1,16 @@
-import React, { ComponentPropsWithRef, ForwardRefExoticComponent, RefAttributes } from 'react';
+import React, {
+  ComponentPropsWithRef,
+  ForwardRefExoticComponent,
+  ReactNode,
+  RefAttributes,
+} from 'react';
 import classes from './Link.module.scss';
 import { LinkProps } from './types';
 
 type AnchorType = 'external' | 'internal' | 'download';
 
 export interface Props extends ComponentPropsWithRef<'a'> {
-  children?: string;
+  children?: ReactNode;
   color?: 'primary' | 'secondary' | 'tertiary';
   type?: AnchorType;
   to: string;

package/src/index.ts

@@ -13,6 +13,9 @@ export {
 } from './Pagination/Pagination';
 export { Icon, Icons } from './Icon/Icon';
 
+export { Tabs, Props as TabsProps } from './Tabs/Tabs';
+export { Tab, Props as TabProps } from './Tabs/Tab';
+
 export { Dialog } from './Notifications/Dialog/Dialog';
 export { Modal } from './Notifications/Modal/Modal';
 export { ModalActions } from './Notifications/Modal/ModalActions/ModalActions';