@oneuptime/common 14.0.11 → 14.0.12

package/Server/Services/ProjectService.ts

@@ -144,6 +144,44 @@ export type ProjectBalanceColumnName =
  */
 export const MAX_BALANCE_ADJUSTMENT_IN_USD_CENTS: number = 10_000 * 100;
 
+/*
+ * The per-feature AI switches a new project starts with ON (see
+ * applyNewProjectAiDefaults). Every boolean AI feature switch on Project
+ * belongs here; Enable AI is not listed because its column already defaults
+ * to true. A switch added to Project later is added here too, or new
+ * projects get it off.
+ */
+export type NewProjectAiDefaultColumn =
+  | "enableAutomaticIncidentInvestigation"
+  | "enableAutomaticAlertInvestigation"
+  | "enableAutomaticPostmortemDraft"
+  | "enableIncidentInstrumentationFixTasks"
+  | "enableAlertInstrumentationFixTasks"
+  | "enableAutomaticIncidentCodeFixes"
+  | "enableAutomaticAlertCodeFixes"
+  | "enableAiInsights"
+  | "enableInsightFixTasks"
+  | "autoArchiveNonActionableExceptions";
+
+export const NEW_PROJECT_AI_DEFAULT_COLUMNS: ReadonlyArray<NewProjectAiDefaultColumn> =
+  [
+    "enableAutomaticIncidentInvestigation",
+    "enableAutomaticAlertInvestigation",
+    "enableAutomaticPostmortemDraft",
+    "enableIncidentInstrumentationFixTasks",
+    "enableAlertInstrumentationFixTasks",
+    "enableAutomaticIncidentCodeFixes",
+    "enableAutomaticAlertCodeFixes",
+    "enableAiInsights",
+    "enableInsightFixTasks",
+    "autoArchiveNonActionableExceptions",
+  ];
+
+// The AI switches of a project being created; unset or null means "not said".
+export type NewProjectAiDefaults = {
+  [column in NewProjectAiDefaultColumn]?: boolean | null | undefined;
+};
+
 // The project columns that decide what the audit log records and keeps.
 export interface ProjectAuditLogSettings {
   enableAuditLogs: boolean;
@@ -550,32 +588,23 @@ export class ProjectService extends DatabaseService<Model> {
   }
 
   /*
-   * A new project starts with AI investigating its incidents and alerts:
-   * both automatic-investigation opt-ins are turned on unless the create
-   * request set them itself (a request that says false keeps false). The
-   * columns' database default stays false, so projects that existed before
-   * this are never switched on by an upgrade, and a create that bypasses
-   * this hook entirely gets the old behaviour rather than a surprise.
+   * A new project starts with every AI feature on: each per-feature switch
+   * in NEW_PROJECT_AI_DEFAULT_COLUMNS is turned on unless the create request
+   * set it itself (a request that says false keeps false). The columns'
+   * database default stays false, so projects that existed before this are
+   * never switched on by an upgrade, and a create that bypasses this hook
+   * entirely gets the old behaviour rather than a surprise.
    *
-   * Postmortem drafting is deliberately NOT turned on here: it is its own
-   * opt-in (enableAutomaticPostmortemDraft), off by default.
+   * On means allowed, not running: each feature still needs what it always
+   * needed (an LLM provider, AI balance, a connected repository and a
+   * capable Runner for the ones that open pull requests), and Enable AI
+   * turns all of them off at once.
    */
-  public applyNewProjectAiDefaults(data: {
-    enableAutomaticIncidentInvestigation?: boolean | null | undefined;
-    enableAutomaticAlertInvestigation?: boolean | null | undefined;
-  }): void {
-    if (
-      data.enableAutomaticIncidentInvestigation === undefined ||
-      data.enableAutomaticIncidentInvestigation === null
-    ) {
-      data.enableAutomaticIncidentInvestigation = true;
-    }
-
-    if (
-      data.enableAutomaticAlertInvestigation === undefined ||
-      data.enableAutomaticAlertInvestigation === null
-    ) {
-      data.enableAutomaticAlertInvestigation = true;
+  public applyNewProjectAiDefaults(data: NewProjectAiDefaults): void {
+    for (const column of NEW_PROJECT_AI_DEFAULT_COLUMNS) {
+      if (data[column] === undefined || data[column] === null) {
+        data[column] = true;
+      }
     }
   }
 

package/Server/Services/ResourceAiAccessService.ts

@@ -69,9 +69,9 @@ import VMwareVCenterService from "./VMwareVCenterService";
  * agent. There are no Runners and no credentials here — the agent holds the
  * resource's credentials itself and never receives one from OneUptime.
  *
- * The project-wide gates (AI on, a provider, a balance, auto-remediation)
- * are the Kubernetes service's, read once per call and shared, so a project
- * setting reads the same for a cluster and for every other resource.
+ * The project-wide gates (AI on, a provider, a balance) are the Kubernetes
+ * service's, read once per call and shared, so a project setting reads the
+ * same for a cluster and for every other resource.
  */
 
 export type ResourceAiAccessProjectGates =
@@ -585,17 +585,6 @@ export class ResourceAiAccessServiceClass {
       });
     }
 
-    if (!gates.isAutoRemediationEnabled) {
-      gaps.push({
-        code: "auto_remediation_disabled_for_project",
-        title: "Auto-remediation is disabled for this project",
-        nextStep:
-          "Enable auto-remediation under Project Settings → AI Features.",
-        blocksInvestigation: false,
-        blocksRemediation: true,
-      });
-    }
-
     const blocksInvestigation: boolean = gaps.some(
       (gap: ResourceAiAccessGap): boolean => {
         return gap.blocksInvestigation;

package/Server/Services/RunnerJobService.ts

@@ -781,7 +781,7 @@ export class Service extends DatabaseService<Model> {
     // The one "is an agent row" rule: the name marker or an agent posture.
     if (RunnerServiceClass.isKubernetesAgentRunnerRow(targetRunner)) {
       throw new BadDataException(
-        `Runner "${targetRunner.name}" is a cluster's in-cluster Runner: it runs kubectl through its cluster only, never ${data.stepType} commands. Target the Kubernetes cluster instead, or pick a Runner you created under Project Settings → Runners.`,
+        `Runner "${targetRunner.name}" is a cluster's in-cluster Runner: it runs kubectl through its cluster only, never ${data.stepType} commands. Target the Kubernetes cluster instead, or pick a Runner you created under Runbooks → Runners.`,
       );
     }
 
@@ -1162,7 +1162,7 @@ export class Service extends DatabaseService<Model> {
          */
         if (RunnerServiceClass.isKubernetesAgentRunnerRow(targetRunner)) {
           throw new BadDataException(
-            `Runner "${targetRunner.name}" is a cluster's in-cluster Runner and is never given a credential, so a kubectl command for cluster "${clusterLabel}" that needs one cannot run on it. Create a Runner under Project Settings → Runners, assign the Kubernetes credential to it and select both on the cluster's AI agent page (AI → Agent).`,
+            `Runner "${targetRunner.name}" is a cluster's in-cluster Runner and is never given a credential, so a kubectl command for cluster "${clusterLabel}" that needs one cannot run on it. Create a Runner under Runbooks → Runners, assign the Kubernetes credential to it and select both on the cluster's AI agent page (AI → Agent).`,
           );
         }
 

package/Server/Services/RunnerService.ts

@@ -302,7 +302,7 @@ export class Service extends DatabaseService<Model> {
         throw new BadDataException(
           `Runner "${runner.name}" is the in-cluster Runner the Kubernetes agent chart installed: it runs kubectl for its cluster only, so ${turnsOnCapabilities.join(
             " and ",
-          )} cannot be turned on for it — and doing so would stop it re-registering after its pod restarts. Create a Runner under Project Settings → Runners for runbooks or code fixes instead.`,
+          )} cannot be turned on for it — and doing so would stop it re-registering after its pod restarts. Create a Runner under Runbooks → Runners for runbooks or code fixes instead.`,
         );
       }
     }
@@ -483,7 +483,7 @@ export class Service extends DatabaseService<Model> {
 
     if (agentRunner) {
       throw new BadDataException(
-        `Runner "${agentRunner.name}" is the in-cluster Runner the Kubernetes agent chart installed. It runs kubectl with its own ServiceAccount only and is never given a ${data.assignedWhat}, because its identity is issued with the project's telemetry ingestion key. Assign this ${data.assignedWhat} to a Runner you created under Project Settings → Runners instead.`,
+        `Runner "${agentRunner.name}" is the in-cluster Runner the Kubernetes agent chart installed. It runs kubectl with its own ServiceAccount only and is never given a ${data.assignedWhat}, because its identity is issued with the project's telemetry ingestion key. Assign this ${data.assignedWhat} to a Runner you created under Runbooks → Runners instead.`,
       );
     }
   }

package/Server/Services/StatusPageService.ts

@@ -83,6 +83,12 @@ import { resolveClientIp } from "../Utils/ClientIp";
 import OwnerRuleAssignment from "../Utils/Rules/OwnerRuleAssignment";
 import NotAuthenticatedException from "../../Types/Exception/NotAuthenticatedException";
 import ForbiddenException from "../../Types/Exception/ForbiddenException";
+import NotFoundException from "../../Types/Exception/NotFoundException";
+import ArchivedMonitorResources from "../../Utils/StatusPage/ArchivedMonitorResources";
+import {
+  STATUS_PAGE_ARCHIVED_SENDS_NOTHING_MESSAGE,
+  STATUS_PAGE_NOT_FOUND_MESSAGE,
+} from "../../Types/StatusPage/StatusPageArchive";
 import MasterPasswordRequiredException from "../../Types/Exception/MasterPasswordRequiredException";
 import {
   MASTER_PASSWORD_COOKIE_IDENTIFIER,
@@ -263,6 +269,8 @@ export class Service extends DatabaseService<StatusPage> {
       query: {
         _id: statusPageId,
         enableMcpServer: true,
+        // An archived status page is offline, its MCP server included.
+        isArchived: false,
       },
       select: {
         _id: true,
@@ -275,6 +283,27 @@ export class Service extends DatabaseService<StatusPage> {
     return Boolean(statusPage);
   }
 
+  /*
+   * Whether this status page exists and is archived. For the places that
+   * find nothing because archived pages are filtered out, and want to say
+   * so to a dashboard user rather than report the page missing.
+   */
+  @CaptureSpan()
+  public async isStatusPageArchived(statusPageId: ObjectID): Promise<boolean> {
+    const statusPage: StatusPage | null = await this.findOneById({
+      id: statusPageId,
+      select: {
+        _id: true,
+        isArchived: true,
+      },
+      props: {
+        isRoot: true,
+      },
+    });
+
+    return statusPage?.isArchived === true;
+  }
+
   public static getDefaultEmailFooterText(): string {
     return "This is an automated email sent to you because you are subscribed to this Status Page.";
   }
@@ -593,7 +622,7 @@ export class Service extends DatabaseService<StatusPage> {
     req: ExpressRequest;
   }): Promise<{
     hasReadAccess: boolean;
-    error?: NotAuthenticatedException | ForbiddenException;
+    error?: NotAuthenticatedException | ForbiddenException | NotFoundException;
   }> {
     const statusPageId: ObjectID = data.statusPageId;
     const req: ExpressRequest = data.req;
@@ -611,9 +640,24 @@ export class Service extends DatabaseService<StatusPage> {
           ipWhitelist: true,
           enableMasterPassword: true,
           masterPassword: true,
+          isArchived: true,
         },
       });
 
+      /*
+       * An archived status page is offline: nobody reads it, signed in or
+       * not, and it answers exactly as a page that does not exist would, so
+       * a visitor cannot tell an archived page from a missing one. This is
+       * the gate every public read goes through (StatusPageAPI's
+       * checkHasReadAccess), so one check takes the whole page down.
+       */
+      if (statusPage?.isArchived) {
+        return {
+          hasReadAccess: false,
+          error: new NotFoundException(STATUS_PAGE_NOT_FOUND_MESSAGE),
+        };
+      }
+
       if (statusPage?.ipWhitelist && statusPage.ipWhitelist.length > 0) {
         const ipWhitelist: Array<string> = statusPage.ipWhitelist?.split("\n");
 
@@ -1209,6 +1253,15 @@ export class Service extends DatabaseService<StatusPage> {
       ]);
 
     if (statusPages.length === 0) {
+      /*
+       * getStatusPagesToSendNotification leaves archived pages out, so a
+       * test report sent from the dashboard for one lands here. Say why,
+       * rather than "not found" for a page the sender is looking at.
+       */
+      if (await this.isStatusPageArchived(data.statusPageId)) {
+        throw new BadDataException(STATUS_PAGE_ARCHIVED_SENDS_NOTHING_MESSAGE);
+      }
+
       throw new BadDataException("Status page not found");
     }
 
@@ -2104,6 +2157,7 @@ export class Service extends DatabaseService<StatusPage> {
           monitor: {
             _id: true,
             currentMonitorStatusId: true,
+            isArchived: true,
           },
           monitorGroupId: true,
           order: true,
@@ -2121,13 +2175,17 @@ export class Service extends DatabaseService<StatusPage> {
         },
       });
 
-    // sort by order and then return
-
-    return statusPageResources.sort(
-      (a: StatusPageResource, b: StatusPageResource) => {
-        return a.order! - b.order!;
-      },
-    );
+    /*
+     * An archived monitor is retired and its status frozen, so it is not
+     * shown (see ArchivedMonitorResources). Everything that works out which
+     * monitors are on the page - incidents, maintenance, reports - reads it
+     * from here and so skips it too.
+     */
+    return ArchivedMonitorResources.withoutArchivedMonitors(
+      statusPageResources,
+    ).sort((a: StatusPageResource, b: StatusPageResource) => {
+      return a.order! - b.order!;
+    });
   }
 
   @CaptureSpan()

package/Server/Services/StatusPageSubscriberService.ts

@@ -19,6 +19,7 @@ import ProjectCallSMSConfigService from "./ProjectCallSMSConfigService";
 import ProjectService, { CurrentPlan } from "./ProjectService";
 import SmsService from "./SmsService";
 import StatusPageService from "./StatusPageService";
+import { STATUS_PAGE_ARCHIVED_NO_NEW_SUBSCRIBERS_MESSAGE } from "../../Types/StatusPage/StatusPageArchive";
 import { StatusPageApiRoute } from "../../ServiceRoute";
 import Hostname from "../../Types/API/Hostname";
 import Protocol from "../../Types/API/Protocol";
@@ -422,6 +423,20 @@ export class Service extends DatabaseService<Model> {
         projectId: data.data.projectId?.toString(),
         statusPageId: data.data.statusPageId?.toString(),
       } as LogAttributes);
+
+      /*
+       * An archived page is left out above. Someone adding a subscriber to
+       * it from the dashboard should hear why, not "not found".
+       */
+      if (
+        data.data.statusPageId &&
+        (await StatusPageService.isStatusPageArchived(data.data.statusPageId))
+      ) {
+        throw new BadDataException(
+          STATUS_PAGE_ARCHIVED_NO_NEW_SUBSCRIBERS_MESSAGE,
+        );
+      }
+
       throw new BadDataException("Status Page not found");
     }
 
@@ -2443,6 +2458,14 @@ Stay informed about service availability! 🚀`;
     const statusPages: Array<StatusPage> = await StatusPageService.findBy({
       query: {
         _id: QueryHelper.any(statusPageIds),
+        /*
+         * Every subscriber notification - incidents, episodes, notes,
+         * postmortems, scheduled maintenance, announcements, reports, and the
+         * confirmation a new subscription sends - finds its status pages
+         * here, so leaving archived pages out is what makes an archived page
+         * send nothing at all.
+         */
+        isArchived: false,
       },
       props: {
         isRoot: true,