@oneuptime/common 14.0.0 → 14.0.1

package/Tests/Server/Services/DatabaseServiceRuleCriteriaValidation.test.ts

@@ -1,5 +1,7 @@
 import AlertReminderRule from "../../../Models/DatabaseModels/AlertReminderRule";
 import StatusPageMonitorRule from "../../../Models/DatabaseModels/StatusPageMonitorRule";
+import ServiceLevelObjectiveMonitorRule from "../../../Models/DatabaseModels/ServiceLevelObjectiveMonitorRule";
+import MonitorType from "../../../Types/Monitor/MonitorType";
 import DatabaseService from "../../../Server/Services/DatabaseService";
 import DatabaseCommonInteractionProps from "../../../Types/BaseDatabase/DatabaseCommonInteractionProps";
 import FilterCondition from "../../../Types/Filter/FilterCondition";
@@ -520,3 +522,105 @@ describe("DatabaseService rule criteria validation", () => {
     );
   });
 });
+
+describe("DatabaseService SLO monitor type criteria validation", () => {
+  const sloService: DatabaseService<ServiceLevelObjectiveMonitorRule> =
+    new DatabaseService<ServiceLevelObjectiveMonitorRule>(
+      ServiceLevelObjectiveMonitorRule,
+    );
+  const sanitizeSlo: SanitizeFunction = async (
+    data: unknown,
+    props: DatabaseCommonInteractionProps = { isRoot: true },
+    isUpdate: boolean = true,
+  ): Promise<JSONObject> => {
+    return (await (
+      sloService as unknown as { sanitizeCreateOrUpdate: SanitizeFunction }
+    ).sanitizeCreateOrUpdate(data, props, isUpdate)) as JSONObject;
+  };
+
+  it.each([true, false])(
+    "persists valid type criteria with a fail-closed compatibility shadow on update=%p",
+    async (isUpdate: boolean) => {
+      const criteria: JSONObject = criteriaFor({
+        field: "monitorType",
+        operator: RuleCriteriaOperator.Equals,
+        value: MonitorType.Docker,
+      });
+      const result: JSONObject = await sanitizeSlo(
+        {
+          criteria,
+          monitorType: MonitorType.API,
+          monitorNamePattern: ".*",
+          monitorLabels: ["11111111-1111-4111-8111-111111111111"],
+        },
+        { isRoot: true },
+        isUpdate,
+      );
+      expect(result).toMatchObject({
+        criteria,
+        monitorType: null,
+        monitorNamePattern: "(?!)",
+      });
+      expect(result["monitorLabels"]).toBeUndefined();
+    },
+  );
+
+  it.each(Object.values(MonitorType))(
+    "accepts equality and inequality for %s",
+    async (monitorType: MonitorType) => {
+      for (const operator of [
+        RuleCriteriaOperator.Equals,
+        RuleCriteriaOperator.NotEquals,
+      ]) {
+        await expect(
+          sanitizeSlo({
+            criteria: criteriaFor({
+              field: "monitorType",
+              operator,
+              value: monitorType,
+            }),
+          }),
+        ).resolves.toBeDefined();
+      }
+    },
+  );
+
+  it.each(["Unknown", "api", "API.*", 1, true])(
+    "rejects invalid type value %p",
+    async (value: string | number | boolean) => {
+      await expect(
+        sanitizeSlo({
+          criteria: criteriaFor({
+            field: "monitorType",
+            operator: RuleCriteriaOperator.NotEquals,
+            value,
+          }),
+        }),
+      ).rejects.toThrow("valid monitor type");
+    },
+  );
+
+  it.each([
+    RuleCriteriaOperator.Contains,
+    RuleCriteriaOperator.DoesNotContain,
+    RuleCriteriaOperator.StartsWith,
+    RuleCriteriaOperator.EndsWith,
+    RuleCriteriaOperator.MatchesPattern,
+    RuleCriteriaOperator.DoesNotMatchPattern,
+    RuleCriteriaOperator.HasAnyOf,
+    RuleCriteriaOperator.HasAllOf,
+    RuleCriteriaOperator.HasNoneOf,
+  ])(
+    "rejects unsupported type operator %s",
+    async (operator: RuleCriteriaOperator) => {
+      const value: string | Array<string> = operator.startsWith("Has")
+        ? [MonitorType.API]
+        : MonitorType.API;
+      await expect(
+        sanitizeSlo({
+          criteria: criteriaFor({ field: "monitorType", operator, value }),
+        }),
+      ).rejects.toThrow("only support Equals");
+    },
+  );
+});

package/Tests/Server/Services/RuleRun/LabelRuleEnginesGroupBRun.test.ts

@@ -28,6 +28,10 @@ import ServiceFeedService from "../../../../Server/Services/ServiceFeedService";
 import ServiceLabelRuleEngineService from "../../../../Server/Services/ServiceLabelRuleEngineService";
 import ServiceLabelRuleService from "../../../../Server/Services/ServiceLabelRuleService";
 import ServiceService from "../../../../Server/Services/ServiceService";
+import ServiceLevelObjectiveFeedService from "../../../../Server/Services/ServiceLevelObjectiveFeedService";
+import ServiceLevelObjectiveLabelRuleEngineService from "../../../../Server/Services/ServiceLevelObjectiveLabelRuleEngineService";
+import ServiceLevelObjectiveLabelRuleService from "../../../../Server/Services/ServiceLevelObjectiveLabelRuleService";
+import ServiceLevelObjectiveService from "../../../../Server/Services/ServiceLevelObjectiveService";
 import StatusPageLabelRuleEngineService from "../../../../Server/Services/StatusPageLabelRuleEngineService";
 import StatusPageLabelRuleService from "../../../../Server/Services/StatusPageLabelRuleService";
 import StatusPageService from "../../../../Server/Services/StatusPageService";
@@ -61,6 +65,8 @@ import ServerlessFunction from "../../../../Models/DatabaseModels/ServerlessFunc
 import ServerlessFunctionLabelRule from "../../../../Models/DatabaseModels/ServerlessFunctionLabelRule";
 import Service from "../../../../Models/DatabaseModels/Service";
 import ServiceLabelRule from "../../../../Models/DatabaseModels/ServiceLabelRule";
+import ServiceLevelObjective from "../../../../Models/DatabaseModels/ServiceLevelObjective";
+import ServiceLevelObjectiveLabelRule from "../../../../Models/DatabaseModels/ServiceLevelObjectiveLabelRule";
 import StatusPage from "../../../../Models/DatabaseModels/StatusPage";
 import StatusPageLabelRule from "../../../../Models/DatabaseModels/StatusPageLabelRule";
 import VMwareVCenter from "../../../../Models/DatabaseModels/VMwareVCenter";
@@ -397,6 +403,47 @@ const cases: Array<LabelEngineCase> = [
     },
     feedResourceIdKey: "serviceId",
   }),
+  labelEngineCase<ServiceLevelObjective, ServiceLevelObjectiveLabelRule>({
+    name: "ServiceLevelObjectiveLabelRuleEngineService",
+    engine: ServiceLevelObjectiveLabelRuleEngineService,
+    applyOnCreate: (resource: ServiceLevelObjective): Promise<void> => {
+      return ServiceLevelObjectiveLabelRuleEngineService.applyRulesToServiceLevelObjective(
+        resource,
+      );
+    },
+    ruleService:
+      ServiceLevelObjectiveLabelRuleService as unknown as RuleReadService,
+    resourceService: ServiceLevelObjectiveService as unknown as ResourceService,
+    resourceModel: ServiceLevelObjective,
+    textField: "name",
+    patternField: "serviceLevelObjectiveNamePattern",
+    labelMatchField: "serviceLevelObjectiveLabels",
+    matchesHandedResource: false,
+    syncsInMemoryLabels: true,
+    severity: null,
+    expectedRuleSelect: {
+      _id: true,
+      name: true,
+      criteria: true,
+      serviceLevelObjectiveLabels: { _id: true },
+      serviceLevelObjectiveNamePattern: true,
+      serviceLevelObjectiveDescriptionPattern: true,
+      labelsToAdd: { _id: true },
+    },
+    expectedResourceSelect: IDS_ONLY_RESOURCE_SELECT,
+    mockFeed: (): jest.SpyInstance => {
+      jest
+        .spyOn(ServiceLevelObjectiveService, "getSloMarkdownLink")
+        .mockResolvedValue(MARKDOWN_LINK);
+      return jest
+        .spyOn(
+          ServiceLevelObjectiveFeedService,
+          "createServiceLevelObjectiveFeedItem",
+        )
+        .mockResolvedValue(undefined);
+    },
+    feedResourceIdKey: "serviceLevelObjectiveId",
+  }),
   labelEngineCase<StatusPage, StatusPageLabelRule>({
     name: "StatusPageLabelRuleEngineService",
     engine: StatusPageLabelRuleEngineService,
@@ -797,7 +844,7 @@ describe("label rule engines (group B) - applying a rule to existing resources",
       cases.map((c: LabelEngineCase) => {
         return c.name;
       }),
-    ).toHaveLength(11);
+    ).toHaveLength(12);
   });
 
   describe.each(cases)("$name", (c: LabelEngineCase) => {

package/Tests/Server/Services/RuleRun/OwnerRuleEnginesGroupBRun.test.ts

@@ -43,6 +43,12 @@ import ServiceOwnerRuleService from "../../../../Server/Services/ServiceOwnerRul
 import ServiceOwnerTeamService from "../../../../Server/Services/ServiceOwnerTeamService";
 import ServiceOwnerUserService from "../../../../Server/Services/ServiceOwnerUserService";
 import ServiceService from "../../../../Server/Services/ServiceService";
+import ServiceLevelObjectiveFeedService from "../../../../Server/Services/ServiceLevelObjectiveFeedService";
+import ServiceLevelObjectiveOwnerRuleEngineService from "../../../../Server/Services/ServiceLevelObjectiveOwnerRuleEngineService";
+import ServiceLevelObjectiveOwnerRuleService from "../../../../Server/Services/ServiceLevelObjectiveOwnerRuleService";
+import ServiceLevelObjectiveOwnerTeamService from "../../../../Server/Services/ServiceLevelObjectiveOwnerTeamService";
+import ServiceLevelObjectiveOwnerUserService from "../../../../Server/Services/ServiceLevelObjectiveOwnerUserService";
+import ServiceLevelObjectiveService from "../../../../Server/Services/ServiceLevelObjectiveService";
 import StatusPageOwnerRuleEngineService from "../../../../Server/Services/StatusPageOwnerRuleEngineService";
 import StatusPageOwnerRuleService from "../../../../Server/Services/StatusPageOwnerRuleService";
 import StatusPageOwnerTeamService from "../../../../Server/Services/StatusPageOwnerTeamService";
@@ -78,6 +84,8 @@ import ServerlessFunctionOwnerTeam from "../../../../Models/DatabaseModels/Serve
 import ServerlessFunctionOwnerUser from "../../../../Models/DatabaseModels/ServerlessFunctionOwnerUser";
 import ServiceOwnerTeam from "../../../../Models/DatabaseModels/ServiceOwnerTeam";
 import ServiceOwnerUser from "../../../../Models/DatabaseModels/ServiceOwnerUser";
+import ServiceLevelObjectiveOwnerTeam from "../../../../Models/DatabaseModels/ServiceLevelObjectiveOwnerTeam";
+import ServiceLevelObjectiveOwnerUser from "../../../../Models/DatabaseModels/ServiceLevelObjectiveOwnerUser";
 import StatusPageOwnerTeam from "../../../../Models/DatabaseModels/StatusPageOwnerTeam";
 import StatusPageOwnerUser from "../../../../Models/DatabaseModels/StatusPageOwnerUser";
 import VMwareVCenterOwnerTeam from "../../../../Models/DatabaseModels/VMwareVCenterOwnerTeam";
@@ -336,6 +344,28 @@ const ENGINE_CASES: Array<EngineCase> = [
     }),
     prepare: noop,
   },
+  {
+    name: "SLO",
+    engine: ServiceLevelObjectiveOwnerRuleEngineService,
+    createHook: "applyRulesToServiceLevelObjective",
+    ruleService: ServiceLevelObjectiveOwnerRuleService,
+    rereadService: ServiceLevelObjectiveService,
+    ownerUserService: ServiceLevelObjectiveOwnerUserService,
+    ownerTeamService: ServiceLevelObjectiveOwnerTeamService,
+    ownerUserModel: ServiceLevelObjectiveOwnerUser,
+    ownerTeamModel: ServiceLevelObjectiveOwnerTeam,
+    resourceIdColumn: "serviceLevelObjectiveId",
+    namePatternField: "serviceLevelObjectiveNamePattern",
+    hasNotificationFlag: true,
+    addOwnersService: null,
+    mockFeed: feedMock({
+      linkService: ServiceLevelObjectiveService,
+      linkMethod: "getSloMarkdownLink",
+      feedService: ServiceLevelObjectiveFeedService,
+      feedMethod: "createServiceLevelObjectiveFeedItem",
+    }),
+    prepare: noop,
+  },
   {
     name: "status page",
     engine: StatusPageOwnerRuleEngineService,